From: John Garry <john.garry@huawei.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: <peterz@infradead.org>, <acme@kernel.org>, <mingo@redhat.com>,
<mark.rutland@arm.com>, <jolsa@redhat.com>, <namhyung@kernel.org>,
<irogers@google.com>, <kjain@linux.ibm.com>,
<alexander.shishkin@linux.intel.com>,
<linux-kernel@vger.kernel.org>, <will@kernel.org>,
<linuxarm@huawei.com>
Subject: Re: [PATCH] perf vendor events: Remove 'type' field from mapfiles
Date: Fri, 26 Feb 2021 16:16:30 +0000 [thread overview]
Message-ID: <d2b754c2-0994-34a2-c42e-d8323beaf8c5@huawei.com> (raw)
In-Reply-To: <20210226154737.GY472138@tassilo.jf.intel.com>
On 26/02/2021 15:47, Andi Kleen wrote:
> On Fri, Feb 26, 2021 at 09:08:17PM +0800, John Garry wrote:
>> Included for each CPU entry in the per-arch mapfile.csv file is a 'type'
>> field.
> I don't like it because this will make the mapfile incompatible with
> what download.01.org uses. We originally derived it from that.
I assumed that it was this file:
https://download.01.org/perfmon/mapfile.csv
which already has a different format - extra columns - so figured that
some handcrafting was already going on. Indeed 'type' is not always
'core' there.
>
> It would be ok if it fixed something serious, but as it seems to be
> more cosmetic I don't think there's a good reason to devivate.
>
If you're against that, then ok; I suppose jevents handling could still
be removed, but I'm not enthused.
Thanks,
John
next prev parent reply other threads:[~2021-02-26 16:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 13:08 John Garry
2021-02-26 15:47 ` Andi Kleen
2021-02-26 16:16 ` John Garry [this message]
2021-02-26 20:45 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2b754c2-0994-34a2-c42e-d8323beaf8c5@huawei.com \
--to=john.garry@huawei.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®