[PATCH] cpufreq: longrun: fix typo in kernel-doc

[PATCH] cpufreq: longrun: fix typo in kernel-doc

[Manuel Ebner]

Fix typo to fix:

  $ ./scripts/kernel-doc -none drivers/cpufreq/longrun.c
  Warning: drivers/cpufreq/longrun.c:126 expecting prototype for longrun_verify_poliy(). Prototype was for longrun_verify_policy() instead

Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
---
 drivers/cpufreq/longrun.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/longrun.c b/drivers/cpufreq/longrun.c
index 82a7bb69c..7d4146d6c 100644
--- a/drivers/cpufreq/longrun.c
+++ b/drivers/cpufreq/longrun.c
@@ -117,7 +117,7 @@ static int longrun_set_policy(struct cpufreq_policy *policy)
 
 
 /**
- * longrun_verify_poliy - verifies a new CPUFreq policy
+ * longrun_verify_policy - verifies a new CPUFreq policy
  * @policy: the policy to verify
  *
  * Validates a new CPUFreq policy. This function has to be called with
-- 
2.55.0

Re: [PATCH] cpufreq: longrun: fix typo in kernel-doc

[Zhongqiu Han]

Hi Manuel,

Thanks for the patch.

On 10/17/2026 3:14 PM, Manuel Ebner wrote:
> Fix typo to fix:
> 
>    $ ./scripts/kernel-doc -none drivers/cpufreq/longrun.c
>    Warning: drivers/cpufreq/longrun.c:126 expecting prototype for longrun_verify_poliy(). Prototype was for longrun_verify_policy() instead

./scripts/checkpatch.pl reports a warning which should be acceptable to
keep unwrapped as it is tool output.

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit
description?)
#9:
   Warning: drivers/cpufreq/longrun.c:126 expecting prototype for 
longrun_verify_poliy(). Prototype was for longrun_verify_policy() instead

total: 0 errors, 1 warnings, 8 lines checked



Also, while reproducing this issue, I noticed another problem,

./scripts/kernel-doc -none drivers/cpufreq/longrun.c
Warning: drivers/cpufreq/longrun.c:21 This comment starts with '/**', 
but isn't a kernel-doc comment. Refer to 
Documentation/doc-guide/kernel-doc.rst
  * longrun_{low,high}_freq is needed for the conversion of cpufreq kHz

It should use /* instead of /** and may be worth a separate patch. But
since this patch is only intended to fix the typo, the patch itself
looks fine to me.




> 
> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>

Small nit: please consider to add the Fixes tag:
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")


Reviewed-by: Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>


> ---
>   drivers/cpufreq/longrun.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/longrun.c b/drivers/cpufreq/longrun.c
> index 82a7bb69c..7d4146d6c 100644
> --- a/drivers/cpufreq/longrun.c
> +++ b/drivers/cpufreq/longrun.c
> @@ -117,7 +117,7 @@ static int longrun_set_policy(struct cpufreq_policy *policy)
>   
>   
>   /**
> - * longrun_verify_poliy - verifies a new CPUFreq policy
> + * longrun_verify_policy - verifies a new CPUFreq policy
>    * @policy: the policy to verify
>    *
>    * Validates a new CPUFreq policy. This function has to be called with


-- 
Thx and BRs,
Zhongqiu Han

Re: [PATCH] cpufreq: longrun: fix typo in kernel-doc

[Viresh Kumar]

On 17-10-26, 09:14, Manuel Ebner wrote:
> Fix typo to fix:
> 
>   $ ./scripts/kernel-doc -none drivers/cpufreq/longrun.c
>   Warning: drivers/cpufreq/longrun.c:126 expecting prototype for longrun_verify_poliy(). Prototype was for longrun_verify_policy() instead
> 
> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
> ---
>  drivers/cpufreq/longrun.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied. Thanks.

-- 
viresh

Re: [PATCH] cpufreq: longrun: fix typo in kernel-doc

[Manuel Ebner]

On Mon, 2026-10-19 at 11:37 +0800, Zhongqiu Han wrote:
> Hi Manuel,
> 
> Thanks for the patch.
> 
> On 10/17/2026 3:14 PM, Manuel Ebner wrote:
> > Fix typo to fix:
> > 
> >    $ ./scripts/kernel-doc -none drivers/cpufreq/longrun.c
> >    Warning: drivers/cpufreq/longrun.c:126 expecting prototype for longrun_verify_poliy(). Prototype was for longrun_verify_policy() instead
> 
> ./scripts/checkpatch.pl reports a warning which should be acceptable to
> keep unwrapped as it is tool output.
> 
> WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit
> description?)
> #9:
>    Warning: drivers/cpufreq/longrun.c:126 expecting prototype for 
> longrun_verify_poliy(). Prototype was for longrun_verify_policy() instead
> 
> total: 0 errors, 1 warnings, 8 lines checked
> 
> 
> 
> Also, while reproducing this issue, I noticed another problem,
> 
> ./scripts/kernel-doc -none drivers/cpufreq/longrun.c
> Warning: drivers/cpufreq/longrun.c:21 This comment starts with '/**', 
> but isn't a kernel-doc comment. Refer to 
> Documentation/doc-guide/kernel-doc.rst
>   * longrun_{low,high}_freq is needed for the conversion of cpufreq kHz
> 
> It should use /* instead of /** and may be worth a separate patch. 

Will do.

> But
> since this patch is only intended to fix the typo, the patch itself
> looks fine to me.
> 
> > 
> > Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
> 
> Small nit: please consider to add the Fixes tag:
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")

Well, thats the init commit, should it still be added in 
future patches?
Can pre-git history be referenced?

> 
> Reviewed-by: Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>
> 

Thanks 
 Manuel

> ...

Re: [PATCH] cpufreq: longrun: fix typo in kernel-doc

[Zhongqiu Han]

On 10/19/2026 4:51 PM, Manuel Ebner wrote:
> On Mon, 2026-10-19 at 11:37 +0800, Zhongqiu Han wrote:
>> Hi Manuel,
>>
>> Thanks for the patch.
>>
>> On 10/17/2026 3:14 PM, Manuel Ebner wrote:
>>> Fix typo to fix:
>>>
>>>     $ ./scripts/kernel-doc -none drivers/cpufreq/longrun.c
>>>     Warning: drivers/cpufreq/longrun.c:126 expecting prototype for longrun_verify_poliy(). Prototype was for longrun_verify_policy() instead
>>
>> ./scripts/checkpatch.pl reports a warning which should be acceptable to
>> keep unwrapped as it is tool output.
>>
>> WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit
>> description?)
>> #9:
>>     Warning: drivers/cpufreq/longrun.c:126 expecting prototype for
>> longrun_verify_poliy(). Prototype was for longrun_verify_policy() instead
>>
>> total: 0 errors, 1 warnings, 8 lines checked
>>
>>
>>
>> Also, while reproducing this issue, I noticed another problem,
>>
>> ./scripts/kernel-doc -none drivers/cpufreq/longrun.c
>> Warning: drivers/cpufreq/longrun.c:21 This comment starts with '/**',
>> but isn't a kernel-doc comment. Refer to
>> Documentation/doc-guide/kernel-doc.rst
>>    * longrun_{low,high}_freq is needed for the conversion of cpufreq kHz
>>
>> It should use /* instead of /** and may be worth a separate patch.
> 
> Will do.

Thanks

> 
>> But
>> since this patch is only intended to fix the typo, the patch itself
>> looks fine to me.
>>
>>>
>>> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
>>
>> Small nit: please consider to add the Fixes tag:
>> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> 
> Well, thats the init commit, should it still be added in
> future patches?
> Can pre-git history be referenced?

AFAIK, yes, the usual approach for pre-Git history is to use
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2"), the initial Git commit.
Many patches have used this Fixes tag, for example:

https://lore.kernel.org/all/?q=1da177e4c3f4

> 
>>
>> Reviewed-by: Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>
>>
> 
> Thanks
>   Manuel
> 
>> ...


-- 
Thx and BRs,
Zhongqiu Han