From: "Arnd Bergmann" <arnd@arndb.de>
To: "Vijendar Mukunda" <vijendar.mukunda@amd.com>,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Arnd Bergmann" <arnd@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Peter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
"Bard Liao" <yung-chuan.liao@linux.intel.com>,
"Daniel Baluta" <daniel.baluta@nxp.com>,
"Mark Brown" <broonie@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>
Cc: "Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux.dev>,
sound-open-firmware@alsa-project.org,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
"Rafael J . Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH] ASoC: SOF: amd: fix building without CONFIG_ACPI
Date: Fri, 25 Sep 2026 20:10:26 +0200 [thread overview]
Message-ID: <d2d25531-d469-4050-8d74-5c7ada4cb890@app.fastmail.com> (raw)
In-Reply-To: <b76e11c8-4f0c-4ef2-ac42-f6f062a1646e@amd.com>
On Fri, Sep 25, 2026, at 18:37, Mukunda,Vijendar wrote:
> On 9/25/26 19:02, Mario Limonciello wrote:
>> On 9/25/26 08:10, Arnd Bergmann wrote:
>>> From: Arnd Bergmann <arnd@arndb.de>
>>>
>>> When ACPI is disabled, this driver runs into a build failure:
>>>
>>> sound/soc/sof/amd/acp.c:1374:13: error: call to undeclared function
>>> 'acpi_find_child_device'; ISO C99 and later do not support implicit
>>> function declarations [-Wimplicit-function-declaration]
>>> 1374 | pdm_dev = acpi_find_child_device(adev,
>>> ACP7X_DMIC_ADDR, 0);
>>>
> Hi Arnd,
>
> Thanks for catching and fixing this issue.
> As the author of the original patch, I didn't receive the
> original bug report. Was it sent to a limited recipient set,
> or could there have been a mailing list delivery issue?
No idea, my report is in the archive, and I assume that is how
Mario saw it:
https://lore.kernel.org/linux-sound/20260925131104.118993-1-arnd@kernel.org/
I only ran into the problem on today's linux-next during
randconfig testing.
Arnd
prev parent reply other threads:[~2026-09-25 18:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 13:10 Arnd Bergmann
2026-09-25 13:32 ` Mario Limonciello
2026-09-25 16:37 ` Mukunda,Vijendar
2026-09-25 18:10 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2d25531-d469-4050-8d74-5c7ada4cb890@app.fastmail.com \
--to=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=rafael@kernel.org \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=vijendar.mukunda@amd.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®