Re: [PATCH v8 07/18] media: qcom: camss: Drop legacy PHY descriptions from x1e

[Christopher Obbard <christopher.obbard@linaro.org>]

Hi Bryan,

On Wed, 2026-02-25 at 15:11 +0000, Bryan O'Donoghue wrote:
> x1e is the first CAMSS SoC to use the new PHY interface. Drop the redundant
> legacy CSIPHY descriptions.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

Reviewed-by: Christopher Obbard <christopher.obbard@linaro.org>
Tested-by: Christopher Obbard <christopher.obbard@linaro.org>

> ---
>  drivers/media/platform/qcom/camss/camss.c | 37 -------------------------------
>  1 file changed, 37 deletions(-)
> 
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index b1737b5d52160..0ebe634f5d96b 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -3895,15 +3895,6 @@ static const struct resources_icc icc_res_sa8775p[] = {
>  static const struct camss_subdev_resources csiphy_res_x1e80100[] = {
>  	/* CSIPHY0 */
>  	{
> -		.regulators = {
> -			{ .supply = "vdd-csiphy-0p8", .init_load_uA = 105000 },
> -			{ .supply = "vdd-csiphy-1p2", .init_load_uA = 58900 }
> -		},
> -		.clock = { "csiphy0", "csiphy0_timer" },
> -		.clock_rate = { { 300000000, 400000000, 480000000 },
> -				{ 266666667, 400000000 } },
> -		.reg = { "csiphy0" },
> -		.interrupt = { "csiphy0" },
>  		.csiphy = {
>  			.id = 0,
>  			.hw_ops = &csiphy_ops_3ph_1_0,
> @@ -3912,15 +3903,6 @@ static const struct camss_subdev_resources csiphy_res_x1e80100[] = {
>  	},
>  	/* CSIPHY1 */
>  	{
> -		.regulators = {
> -			{ .supply = "vdd-csiphy-0p8", .init_load_uA = 105000 },
> -			{ .supply = "vdd-csiphy-1p2", .init_load_uA = 58900 }
> -		},
> -		.clock = { "csiphy1", "csiphy1_timer" },
> -		.clock_rate = { { 300000000, 400000000, 480000000 },
> -				{ 266666667, 400000000 } },
> -		.reg = { "csiphy1" },
> -		.interrupt = { "csiphy1" },
>  		.csiphy = {
>  			.id = 1,
>  			.hw_ops = &csiphy_ops_3ph_1_0,
> @@ -3929,15 +3911,6 @@ static const struct camss_subdev_resources csiphy_res_x1e80100[] = {
>  	},
>  	/* CSIPHY2 */
>  	{
> -		.regulators = {
> -			{ .supply = "vdd-csiphy-0p8", .init_load_uA = 105000 },
> -			{ .supply = "vdd-csiphy-1p2", .init_load_uA = 58900 }
> -		},
> -		.clock = { "csiphy2", "csiphy2_timer" },
> -		.clock_rate = { { 300000000, 400000000, 480000000 },
> -				{ 266666667, 400000000 } },
> -		.reg = { "csiphy2" },
> -		.interrupt = { "csiphy2" },
>  		.csiphy = {
>  			.id = 2,
>  			.hw_ops = &csiphy_ops_3ph_1_0,
> @@ -3946,15 +3919,6 @@ static const struct camss_subdev_resources csiphy_res_x1e80100[] = {
>  	},
>  	/* CSIPHY4 */
>  	{
> -		.regulators = {
> -			{ .supply = "vdd-csiphy-0p8", .init_load_uA = 105000 },
> -			{ .supply = "vdd-csiphy-1p2", .init_load_uA = 58900 }
> -		},
> -		.clock = { "csiphy4", "csiphy4_timer" },
> -		.clock_rate = { { 300000000, 400000000, 480000000 },
> -				{ 266666667, 400000000 } },
> -		.reg = { "csiphy4" },
> -		.interrupt = { "csiphy4" },
>  		.csiphy = {
>  			.id = 4,
>  			.hw_ops = &csiphy_ops_3ph_1_0,
> @@ -5362,7 +5326,6 @@ static const struct camss_resources sm8650_resources = {
>  static const struct camss_resources x1e80100_resources = {
>  	.version = CAMSS_X1E80100,
>  	.pd_name = "top",
> -	.legacy_phy = true,
>  	.csiphy_res = csiphy_res_x1e80100,
>  	.csid_res = csid_res_x1e80100,
>  	.vfe_res = vfe_res_x1e80100,