From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Hayes Wang <hayeswang@realtek.com>, netdev@vger.kernel.org
Cc: nic_swsd@realtek.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH net-next 6/6] r8152: add byte_enable for ocp_read_word function
Date: Mon, 27 Jun 2016 13:57:22 +0300 [thread overview]
Message-ID: <d350382e-3798-f9c9-1639-45db15fceeca@cogentembedded.com> (raw)
In-Reply-To: <1394712342-15778-190-Taiwan-albertk@realtek.com>
Hello.
On 6/27/2016 8:07 AM, Hayes Wang wrote:
> Add byte_enable for ocp_read_word() to replace reading 4 bytes data
> with reading the desired 2 bytes data.
>
> This is used to avoid the issue which is described in commit:b4d99def.
scripts/checkpatch.pl now enforces certain commit citing style, yours
doesn't match.
> The origin method always reads 4 bytes data, and it may have problem
> when reading the PHY regiters.
Registers.
> The new method is supported since RTL8152B, but it doesn't influence
> the previous chips. The bits of the byte_enable for the previous chips
> are the reserved bits, and the hw would ignore them.
>
> Signed-off-by: Hayes Wang <hayeswang@realtek.com>
[...]
MBR, Sergei
next prev parent reply other threads:[~2016-06-27 10:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 5:07 [PATCH net-next 0/6] r8152: support new chips Hayes Wang
2016-06-27 5:07 ` [PATCH net-next 1/6] r8152: add aldps_enable for rtl_ops Hayes Wang
2016-06-27 5:07 ` [PATCH net-next 2/6] r8152: add u1u2_enable " Hayes Wang
2016-06-27 5:07 ` [PATCH net-next 3/6] r8152: add power_cut_en " Hayes Wang
2016-06-27 5:07 ` [PATCH net-next 4/6] r8152: support the new chip 8050 Hayes Wang
2016-06-27 5:07 ` [PATCH net-next 5/6] r8152: support RTL8153B Hayes Wang
2016-06-27 5:07 ` [PATCH net-next 6/6] r8152: add byte_enable for ocp_read_word function Hayes Wang
2016-06-27 10:57 ` Sergei Shtylyov [this message]
2016-06-28 2:45 ` [PATCH net-next v2 0/6] r8152: support new chips Hayes Wang
2016-06-28 2:45 ` [PATCH net-next v2 1/6] r8152: add aldps_enable for rtl_ops Hayes Wang
2016-06-28 2:45 ` [PATCH net-next v2 2/6] r8152: add u1u2_enable " Hayes Wang
2016-06-28 2:45 ` [PATCH net-next v2 3/6] r8152: add power_cut_en " Hayes Wang
2016-06-28 2:45 ` [PATCH net-next v2 4/6] r8152: support the new chip 8050 Hayes Wang
2016-06-28 2:45 ` [PATCH net-next v2 5/6] r8152: support RTL8153B Hayes Wang
2016-06-28 2:45 ` [PATCH net-next v2 6/6] r8152: add byte_enable for ocp_read_word function Hayes Wang
2016-06-28 12:28 ` [PATCH net-next v3 0/7] r8152: support new chips Hayes Wang
2016-06-28 12:28 ` [PATCH net-next v3 1/7] r8152: add aldps_enable for rtl_ops Hayes Wang
2016-06-28 12:28 ` [PATCH net-next v3 2/7] r8152: add u1u2_enable " Hayes Wang
2016-06-28 12:28 ` [PATCH net-next v3 3/7] r8152: add power_cut_en " Hayes Wang
2016-06-28 12:28 ` [PATCH net-next v3 4/7] r8152: add u2p3_enable " Hayes Wang
2016-06-28 12:28 ` [PATCH net-next v3 5/7] r8152: support the new chip 8050 Hayes Wang
2016-06-28 12:28 ` [PATCH net-next v3 6/7] r8152: support RTL8153B Hayes Wang
2016-06-28 12:28 ` [PATCH net-next v3 7/7] r8152: add byte_enable for ocp_read_word function Hayes Wang
2016-06-29 3:34 ` [PATCH net-next v3 0/7] r8152: support new chips Hayes Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d350382e-3798-f9c9-1639-45db15fceeca@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®