mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v3] platform/x86: ISST: Fix typo in comments
@ 2022-11-03  1:33 chen zhang
  2022-11-03  1:57 ` Randy Dunlap
  2022-11-07 14:34 ` Hans de Goede
  0 siblings, 2 replies; 4+ messages in thread
From: chen zhang @ 2022-11-03  1:33 UTC (permalink / raw)
  To: hdegoede, rdunlap, bagasdotme
  Cc: linux-kernel, chenzhang_0901, chen zhang, k2ci

Fix spelling typo in comments.

Reported-by: k2ci <kernel-bot@kylinos.cn>
Signed-off-by: chen zhang <chenzhang@kylinos.cn>
---
v3: Change "interace" to "interfaces", Change "share" to "shared"
Thanks for your advice.
v2: update the comments
There is a bug with my company's mailbox with kylinos.cn, and sometimes 
I can't receive reply emails. I cc my personal 163 mailbox, so that I can
receive feedback from reviewer on time.
---
 drivers/platform/x86/intel/speed_select_if/isst_if_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
index fd102678c75f..a7e02b24a87a 100644
--- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
+++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
@@ -623,7 +623,7 @@ static long isst_if_def_ioctl(struct file *file, unsigned int cmd,
 
 /* Lock to prevent module registration when already opened by user space */
 static DEFINE_MUTEX(punit_misc_dev_open_lock);
-/* Lock to allow one share misc device for all ISST interace */
+/* Lock to allow one shared misc device for all ISST interfaces */
 static DEFINE_MUTEX(punit_misc_dev_reg_lock);
 static int misc_usage_count;
 static int misc_device_ret;
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] platform/x86: ISST: Fix typo in comments
  2022-11-03  1:33 [PATCH v3] platform/x86: ISST: Fix typo in comments chen zhang
@ 2022-11-03  1:57 ` Randy Dunlap
  2022-11-07 14:34 ` Hans de Goede
  1 sibling, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2022-11-03  1:57 UTC (permalink / raw)
  To: chen zhang, hdegoede, bagasdotme; +Cc: linux-kernel, chenzhang_0901, k2ci



On 11/2/22 18:33, chen zhang wrote:
> Fix spelling typo in comments.
> 
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> Signed-off-by: chen zhang <chenzhang@kylinos.cn>
> ---
> v3: Change "interace" to "interfaces", Change "share" to "shared"
> Thanks for your advice.
> v2: update the comments
> There is a bug with my company's mailbox with kylinos.cn, and sometimes 
> I can't receive reply emails. I cc my personal 163 mailbox, so that I can
> receive feedback from reviewer on time.
> ---
>  drivers/platform/x86/intel/speed_select_if/isst_if_common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> index fd102678c75f..a7e02b24a87a 100644
> --- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> +++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> @@ -623,7 +623,7 @@ static long isst_if_def_ioctl(struct file *file, unsigned int cmd,
>  
>  /* Lock to prevent module registration when already opened by user space */
>  static DEFINE_MUTEX(punit_misc_dev_open_lock);
> -/* Lock to allow one share misc device for all ISST interace */
> +/* Lock to allow one shared misc device for all ISST interfaces */
>  static DEFINE_MUTEX(punit_misc_dev_reg_lock);
>  static int misc_usage_count;
>  static int misc_device_ret;

Looks good to me. Thanks.

Acked-by: Randy Dunlap <rdunlap@infradead.org>

-- 
~Randy

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] platform/x86: ISST: Fix typo in comments
  2022-11-03  1:33 [PATCH v3] platform/x86: ISST: Fix typo in comments chen zhang
  2022-11-03  1:57 ` Randy Dunlap
@ 2022-11-07 14:34 ` Hans de Goede
  1 sibling, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2022-11-07 14:34 UTC (permalink / raw)
  To: chen zhang, rdunlap, bagasdotme; +Cc: linux-kernel, chenzhang_0901, k2ci

Hi,

On 11/3/22 02:33, chen zhang wrote:
> Fix spelling typo in comments.
> 
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> Signed-off-by: chen zhang <chenzhang@kylinos.cn>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> ---
> v3: Change "interace" to "interfaces", Change "share" to "shared"
> Thanks for your advice.
> v2: update the comments
> There is a bug with my company's mailbox with kylinos.cn, and sometimes 
> I can't receive reply emails. I cc my personal 163 mailbox, so that I can
> receive feedback from reviewer on time.
> ---
>  drivers/platform/x86/intel/speed_select_if/isst_if_common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> index fd102678c75f..a7e02b24a87a 100644
> --- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> +++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> @@ -623,7 +623,7 @@ static long isst_if_def_ioctl(struct file *file, unsigned int cmd,
>  
>  /* Lock to prevent module registration when already opened by user space */
>  static DEFINE_MUTEX(punit_misc_dev_open_lock);
> -/* Lock to allow one share misc device for all ISST interace */
> +/* Lock to allow one shared misc device for all ISST interfaces */
>  static DEFINE_MUTEX(punit_misc_dev_reg_lock);
>  static int misc_usage_count;
>  static int misc_device_ret;


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v3] platform/x86: ISST: Fix typo in comments
@ 2022-11-03  1:21 chen zhang
  0 siblings, 0 replies; 4+ messages in thread
From: chen zhang @ 2022-11-03  1:21 UTC (permalink / raw)
  To: hdegoede; +Cc: linux-kernel, chenzhang_0901, chen zhang, k2ci

Fix spelling typo in comments.

Reported-by: k2ci <kernel-bot@kylinos.cn>
Signed-off-by: chen zhang <chenzhang@kylinos.cn>
---
v3: Change "interace" to "interfaces", Change "share" to "shared"
Thanks for your advice.
v2: update the comments
There is a bug with my company's mailbox with kylinos.cn, and sometimes 
I can't receive reply emails. I cc my personal 163 mailbox, so that I can
receive feedback from reviewer on time.
---
 drivers/platform/x86/intel/speed_select_if/isst_if_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
index fd102678c75f..a7e02b24a87a 100644
--- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
+++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
@@ -623,7 +623,7 @@ static long isst_if_def_ioctl(struct file *file, unsigned int cmd,
 
 /* Lock to prevent module registration when already opened by user space */
 static DEFINE_MUTEX(punit_misc_dev_open_lock);
-/* Lock to allow one share misc device for all ISST interace */
+/* Lock to allow one shared misc device for all ISST interfaces */
 static DEFINE_MUTEX(punit_misc_dev_reg_lock);
 static int misc_usage_count;
 static int misc_device_ret;
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-11-07 14:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-03  1:33 [PATCH v3] platform/x86: ISST: Fix typo in comments chen zhang
2022-11-03  1:57 ` Randy Dunlap
2022-11-07 14:34 ` Hans de Goede
  -- strict thread matches above, loose matches on Subject: below --
2022-11-03  1:21 chen zhang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®