mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2 0/2] Add Axiado AX3000 eMMC Host Controller Support
@ 2026-01-09  9:46 Tzu-Hao Wei
  2026-01-09  9:46 ` [PATCH v2 1/2] dt-bindings: mmc: arasan,sdhci: Add Axiado AX3000 SoC Tzu-Hao Wei
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Tzu-Hao Wei @ 2026-01-09  9:46 UTC (permalink / raw)
  To: SriNavmani A, Prasad Bolisetty, Vinod Koul, Neil Armstrong,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Ulf Hansson,
	Adrian Hunter, Michal Simek
  Cc: linux-phy, devicetree, linux-arm-kernel, linux-kernel, linux-mmc,
	openbmc, Tzu-Hao Wei

Axiado AX3000 SoC eMMC controller is based on Arasan eMMC controller.

This series includes:
1. Add bindings for AX3000 SoC eMMC controller
2. Add arasan sdhci support for eMMC in Axiado AX3000

Signed-off-by: Tzu-Hao Wei <twei@axiado.com>
---
Changes in v2:
- Keep host controller changes in this patchset
- Use pdata instead of mix compatible string
- Fix coding style
- Link to v1: https://lore.kernel.org/r/20251222-axiado-ax3000-add-emmc-host-driver-support-v1-0-5457d0ebcdb4@axiado.com

---
SriNavmani A (2):
      dt-bindings: mmc: arasan,sdhci: Add Axiado AX3000 SoC
      mmc: sdhci-of-arasan: add support on Axiado AX3000 SoC

 Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml |  3 +++
 drivers/mmc/host/sdhci-of-arasan.c                      | 14 ++++++++++++++
 2 files changed, 17 insertions(+)
---
base-commit: f10c325a345fef0a688a2bcdfab1540d1c924148
change-id: 20251222-axiado-ax3000-add-emmc-host-driver-support-2cc84a8f889a
prerequisite-change-id: 20260108-axiado-ax3000-add-emmc-phy-driver-support-d61aead8f622:v1
prerequisite-patch-id: 03617f4dadb7ed33653d1e0b3c03e732ed4948c5
prerequisite-patch-id: 454a64fb94f3c1b6cf6fb7fbfce97f706933b7e3
prerequisite-patch-id: 7961935b88d6c3056b55b4058c1ba878aa00490c
prerequisite-patch-id: f87b65e3c93f8f1edf2305784ea3f81a04c4ad58

Best regards,
-- 
Tzu-Hao Wei <twei@axiado.com>


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 1/2] dt-bindings: mmc: arasan,sdhci: Add Axiado AX3000 SoC
  2026-01-09  9:46 [PATCH v2 0/2] Add Axiado AX3000 eMMC Host Controller Support Tzu-Hao Wei
@ 2026-01-09  9:46 ` Tzu-Hao Wei
  2026-01-09 11:29   ` Rob Herring (Arm)
  2026-01-12  8:46   ` Krzysztof Kozlowski
  2026-01-09  9:46 ` [PATCH v2 2/2] mmc: sdhci-of-arasan: add support on " Tzu-Hao Wei
  2026-01-12  8:30 ` [PATCH v2 0/2] Add Axiado AX3000 eMMC Host Controller Support Krzysztof Kozlowski
  2 siblings, 2 replies; 10+ messages in thread
From: Tzu-Hao Wei @ 2026-01-09  9:46 UTC (permalink / raw)
  To: SriNavmani A, Prasad Bolisetty, Vinod Koul, Neil Armstrong,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Ulf Hansson,
	Adrian Hunter, Michal Simek
  Cc: linux-phy, devicetree, linux-arm-kernel, linux-kernel, linux-mmc,
	openbmc, Tzu-Hao Wei

From: SriNavmani A <srinavmani@axiado.com>

Add compatible strings for Axiado AX3000 SoC eMMC controller which
is based on Arasan eMMC controller.

Signed-off-by: SriNavmani A <srinavmani@axiado.com>
Signed-off-by: Tzu-Hao Wei <twei@axiado.com>
---
 Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
index 8e79de97b242a698a2c555b0b94e2975b1761710..17dfe220503a6722b9ab446cb6e1aeed56099caf 100644
--- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
+++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
@@ -106,6 +106,9 @@ properties:
         description:
           For this device it is strongly suggested to include
           arasan,soc-ctl-syscon.
+      - items:
+          - const: axiado,ax3000-sdhci-5.1-emmc  # Axiado AX3000 eMMC controller
+          - const: arasan,sdhci-5.1
 
   reg:
     maxItems: 1

-- 
2.34.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 2/2] mmc: sdhci-of-arasan: add support on Axiado AX3000 SoC
  2026-01-09  9:46 [PATCH v2 0/2] Add Axiado AX3000 eMMC Host Controller Support Tzu-Hao Wei
  2026-01-09  9:46 ` [PATCH v2 1/2] dt-bindings: mmc: arasan,sdhci: Add Axiado AX3000 SoC Tzu-Hao Wei
@ 2026-01-09  9:46 ` Tzu-Hao Wei
  2026-01-12  8:23   ` Adrian Hunter
  2026-01-12  8:30 ` [PATCH v2 0/2] Add Axiado AX3000 eMMC Host Controller Support Krzysztof Kozlowski
  2 siblings, 1 reply; 10+ messages in thread
From: Tzu-Hao Wei @ 2026-01-09  9:46 UTC (permalink / raw)
  To: SriNavmani A, Prasad Bolisetty, Vinod Koul, Neil Armstrong,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Ulf Hansson,
	Adrian Hunter, Michal Simek
  Cc: linux-phy, devicetree, linux-arm-kernel, linux-kernel, linux-mmc,
	openbmc, Tzu-Hao Wei

From: SriNavmani A <srinavmani@axiado.com>

Axiado AX3000 SoC eMMC controller is based on Arasan eMMC 5.1 host
controller IP.

Signed-off-by: SriNavmani A <srinavmani@axiado.com>
Signed-off-by: Tzu-Hao Wei <twei@axiado.com>
---
 drivers/mmc/host/sdhci-of-arasan.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
index ab7f0ffe7b4f007a58eb0a26868b08b0b02b40f3..5da915edd7416ab5c725a784867098c5e19236b6 100644
--- a/drivers/mmc/host/sdhci-of-arasan.c
+++ b/drivers/mmc/host/sdhci-of-arasan.c
@@ -1512,6 +1512,16 @@ static struct sdhci_arasan_of_data intel_keembay_sdio_data = {
 	.clk_ops = &arasan_clk_ops,
 };
 
+static const struct sdhci_pltfm_data sdhci_arasan_axiado_pdata = {
+	.ops = &sdhci_arasan_ops,
+	.quirks = SDHCI_QUIRK_BROKEN_CQE,
+};
+
+static struct sdhci_arasan_of_data sdhci_arasan_axiado_data = {
+	.pdata = &sdhci_arasan_axiado_pdata,
+	.clk_ops = &arasan_clk_ops,
+};
+
 static const struct of_device_id sdhci_arasan_of_match[] = {
 	/* SoC-specific compatible strings w/ soc_ctl_map */
 	{
@@ -1538,6 +1548,10 @@ static const struct of_device_id sdhci_arasan_of_match[] = {
 		.compatible = "intel,keembay-sdhci-5.1-sdio",
 		.data = &intel_keembay_sdio_data,
 	},
+	{
+		.compatible = "axiado,ax3000-sdhci-5.1-emmc",
+		.data = &sdhci_arasan_axiado_data,
+	},
 	/* Generic compatible below here */
 	{
 		.compatible = "arasan,sdhci-8.9a",

-- 
2.34.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: mmc: arasan,sdhci: Add Axiado AX3000 SoC
  2026-01-09  9:46 ` [PATCH v2 1/2] dt-bindings: mmc: arasan,sdhci: Add Axiado AX3000 SoC Tzu-Hao Wei
@ 2026-01-09 11:29   ` Rob Herring (Arm)
  2026-01-12  6:10     ` Tzu-Hao Wei
  2026-01-12  8:46   ` Krzysztof Kozlowski
  1 sibling, 1 reply; 10+ messages in thread
From: Rob Herring (Arm) @ 2026-01-09 11:29 UTC (permalink / raw)
  To: Tzu-Hao Wei
  Cc: SriNavmani A, Vinod Koul, Adrian Hunter, openbmc, Neil Armstrong,
	devicetree, Ulf Hansson, Krzysztof Kozlowski, Prasad Bolisetty,
	Conor Dooley, linux-arm-kernel, linux-phy, linux-kernel,
	Michal Simek, linux-mmc


On Fri, 09 Jan 2026 17:46:25 +0800, Tzu-Hao Wei wrote:
> From: SriNavmani A <srinavmani@axiado.com>
> 
> Add compatible strings for Axiado AX3000 SoC eMMC controller which
> is based on Arasan eMMC controller.
> 
> Signed-off-by: SriNavmani A <srinavmani@axiado.com>
> Signed-off-by: Tzu-Hao Wei <twei@axiado.com>
> ---
>  Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/axiado,ax3000-emmc-phy.yaml: properties:compatible:const: ['axiado,ax3000-emmc-phy'] is not of type 'integer', 'string'
	from schema $id: http://devicetree.org/meta-schemas/keywords.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/axiado,ax3000-emmc-phy.yaml: properties:compatible:const: ['axiado,ax3000-emmc-phy'] is not of type 'string'
	from schema $id: http://devicetree.org/meta-schemas/string-array.yaml
Documentation/devicetree/bindings/phy/axiado,ax3000-emmc-phy.example.dtb: /example-0/phy@80801c00: failed to match any schema with compatible: ['axiado,ax3000-emmc-phy']

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260109-axiado-ax3000-add-emmc-host-driver-support-v2-1-934f1a61f7c0@axiado.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: mmc: arasan,sdhci: Add Axiado AX3000 SoC
  2026-01-09 11:29   ` Rob Herring (Arm)
@ 2026-01-12  6:10     ` Tzu-Hao Wei
  0 siblings, 0 replies; 10+ messages in thread
From: Tzu-Hao Wei @ 2026-01-12  6:10 UTC (permalink / raw)
  To: Rob Herring (Arm)
  Cc: SriNavmani A, Vinod Koul, Adrian Hunter, openbmc, Neil Armstrong,
	devicetree, Ulf Hansson, Krzysztof Kozlowski, Prasad Bolisetty,
	Conor Dooley, linux-arm-kernel, linux-phy, linux-kernel,
	Michal Simek, linux-mmc

On 1/9/2026 7:29 PM, Rob Herring (Arm) wrote:
>>
>> Signed-off-by: SriNavmani A <srinavmani@axiado.com>
>> Signed-off-by: Tzu-Hao Wei <twei@axiado.com>
>> ---
>>  Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml | 3 +++
>>  1 file changed, 3 insertions(+)
>>
> 
> My bot found errors running 'make dt_binding_check' on your patch:

Thanks for catching it. I will fix it in the next version.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 2/2] mmc: sdhci-of-arasan: add support on Axiado AX3000 SoC
  2026-01-09  9:46 ` [PATCH v2 2/2] mmc: sdhci-of-arasan: add support on " Tzu-Hao Wei
@ 2026-01-12  8:23   ` Adrian Hunter
  2026-02-05  3:37     ` Tzu-Hao Wei
  0 siblings, 1 reply; 10+ messages in thread
From: Adrian Hunter @ 2026-01-12  8:23 UTC (permalink / raw)
  To: Tzu-Hao Wei, SriNavmani A, Prasad Bolisetty, Vinod Koul,
	Neil Armstrong, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Ulf Hansson, Michal Simek
  Cc: linux-phy, devicetree, linux-arm-kernel, linux-kernel, linux-mmc,
	openbmc

On 09/01/2026 11:46, Tzu-Hao Wei wrote:
> From: SriNavmani A <srinavmani@axiado.com>
> 
> Axiado AX3000 SoC eMMC controller is based on Arasan eMMC 5.1 host
> controller IP.
> 
> Signed-off-by: SriNavmani A <srinavmani@axiado.com>
> Signed-off-by: Tzu-Hao Wei <twei@axiado.com>

Apart from dt-bindings issues:

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  drivers/mmc/host/sdhci-of-arasan.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index ab7f0ffe7b4f007a58eb0a26868b08b0b02b40f3..5da915edd7416ab5c725a784867098c5e19236b6 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -1512,6 +1512,16 @@ static struct sdhci_arasan_of_data intel_keembay_sdio_data = {
>  	.clk_ops = &arasan_clk_ops,
>  };
>  
> +static const struct sdhci_pltfm_data sdhci_arasan_axiado_pdata = {
> +	.ops = &sdhci_arasan_ops,
> +	.quirks = SDHCI_QUIRK_BROKEN_CQE,
> +};
> +
> +static struct sdhci_arasan_of_data sdhci_arasan_axiado_data = {
> +	.pdata = &sdhci_arasan_axiado_pdata,
> +	.clk_ops = &arasan_clk_ops,
> +};
> +
>  static const struct of_device_id sdhci_arasan_of_match[] = {
>  	/* SoC-specific compatible strings w/ soc_ctl_map */
>  	{
> @@ -1538,6 +1548,10 @@ static const struct of_device_id sdhci_arasan_of_match[] = {
>  		.compatible = "intel,keembay-sdhci-5.1-sdio",
>  		.data = &intel_keembay_sdio_data,
>  	},
> +	{
> +		.compatible = "axiado,ax3000-sdhci-5.1-emmc",
> +		.data = &sdhci_arasan_axiado_data,
> +	},
>  	/* Generic compatible below here */
>  	{
>  		.compatible = "arasan,sdhci-8.9a",
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 0/2] Add Axiado AX3000 eMMC Host Controller Support
  2026-01-09  9:46 [PATCH v2 0/2] Add Axiado AX3000 eMMC Host Controller Support Tzu-Hao Wei
  2026-01-09  9:46 ` [PATCH v2 1/2] dt-bindings: mmc: arasan,sdhci: Add Axiado AX3000 SoC Tzu-Hao Wei
  2026-01-09  9:46 ` [PATCH v2 2/2] mmc: sdhci-of-arasan: add support on " Tzu-Hao Wei
@ 2026-01-12  8:30 ` Krzysztof Kozlowski
  2026-01-12 10:13   ` Tzu-Hao Wei
  2 siblings, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-12  8:30 UTC (permalink / raw)
  To: Tzu-Hao Wei, SriNavmani A, Prasad Bolisetty, Vinod Koul,
	Neil Armstrong, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Ulf Hansson, Adrian Hunter, Michal Simek
  Cc: linux-phy, devicetree, linux-arm-kernel, linux-kernel, linux-mmc,
	openbmc

On 09/01/2026 10:46, Tzu-Hao Wei wrote:
> Axiado AX3000 SoC eMMC controller is based on Arasan eMMC controller.
> 
> This series includes:
> 1. Add bindings for AX3000 SoC eMMC controller
> 2. Add arasan sdhci support for eMMC in Axiado AX3000
> 
> Signed-off-by: Tzu-Hao Wei <twei@axiado.com>
> ---
> Changes in v2:
> - Keep host controller changes in this patchset
> - Use pdata instead of mix compatible string
> - Fix coding style
> - Link to v1: https://lore.kernel.org/r/20251222-axiado-ax3000-add-emmc-host-driver-support-v1-0-5457d0ebcdb4@axiado.com
> 
> ---
> SriNavmani A (2):
>       dt-bindings: mmc: arasan,sdhci: Add Axiado AX3000 SoC
>       mmc: sdhci-of-arasan: add support on Axiado AX3000 SoC
> 
>  Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml |  3 +++
>  drivers/mmc/host/sdhci-of-arasan.c                      | 14 ++++++++++++++
>  2 files changed, 17 insertions(+)
> ---
> base-commit: f10c325a345fef0a688a2bcdfab1540d1c924148
> change-id: 20251222-axiado-ax3000-add-emmc-host-driver-support-2cc84a8f889a
> prerequisite-change-id: 20260108-axiado-ax3000-add-emmc-phy-driver-support-d61aead8f622:v1
> prerequisite-patch-id: 03617f4dadb7ed33653d1e0b3c03e732ed4948c5
> prerequisite-patch-id: 454a64fb94f3c1b6cf6fb7fbfce97f706933b7e3
> prerequisite-patch-id: 7961935b88d6c3056b55b4058c1ba878aa00490c
> prerequisite-patch-id: f87b65e3c93f8f1edf2305784ea3f81a04c4ad58

Huh, why and how?

It's impossible to apply this.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: mmc: arasan,sdhci: Add Axiado AX3000 SoC
  2026-01-09  9:46 ` [PATCH v2 1/2] dt-bindings: mmc: arasan,sdhci: Add Axiado AX3000 SoC Tzu-Hao Wei
  2026-01-09 11:29   ` Rob Herring (Arm)
@ 2026-01-12  8:46   ` Krzysztof Kozlowski
  1 sibling, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-12  8:46 UTC (permalink / raw)
  To: Tzu-Hao Wei, SriNavmani A, Prasad Bolisetty, Vinod Koul,
	Neil Armstrong, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Ulf Hansson, Adrian Hunter, Michal Simek
  Cc: linux-phy, devicetree, linux-arm-kernel, linux-kernel, linux-mmc,
	openbmc

On 09/01/2026 10:46, Tzu-Hao Wei wrote:
> From: SriNavmani A <srinavmani@axiado.com>
> 
> Add compatible strings for Axiado AX3000 SoC eMMC controller which
> is based on Arasan eMMC controller.
> 
> Signed-off-by: SriNavmani A <srinavmani@axiado.com>
> Signed-off-by: Tzu-Hao Wei <twei@axiado.com>
> ---
>  Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml | 3 +++
>  1 file changed, 3 insertions(+)

Your patchset is impossible to apply. Do not add fake dependencies.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 0/2] Add Axiado AX3000 eMMC Host Controller Support
  2026-01-12  8:30 ` [PATCH v2 0/2] Add Axiado AX3000 eMMC Host Controller Support Krzysztof Kozlowski
@ 2026-01-12 10:13   ` Tzu-Hao Wei
  0 siblings, 0 replies; 10+ messages in thread
From: Tzu-Hao Wei @ 2026-01-12 10:13 UTC (permalink / raw)
  To: Krzysztof Kozlowski, SriNavmani A, Prasad Bolisetty, Vinod Koul,
	Neil Armstrong, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Ulf Hansson, Adrian Hunter, Michal Simek
  Cc: linux-phy, devicetree, linux-arm-kernel, linux-kernel, linux-mmc,
	openbmc

On 1/12/2026 4:30 PM, Krzysztof Kozlowski wrote:
>> ---
>> base-commit: f10c325a345fef0a688a2bcdfab1540d1c924148
>> change-id: 20251222-axiado-ax3000-add-emmc-host-driver-support-2cc84a8f889a
>> prerequisite-change-id: 20260108-axiado-ax3000-add-emmc-phy-driver-support-d61aead8f622:v1
>> prerequisite-patch-id: 03617f4dadb7ed33653d1e0b3c03e732ed4948c5
>> prerequisite-patch-id: 454a64fb94f3c1b6cf6fb7fbfce97f706933b7e3
>> prerequisite-patch-id: 7961935b88d6c3056b55b4058c1ba878aa00490c
>> prerequisite-patch-id: f87b65e3c93f8f1edf2305784ea3f81a04c4ad58
> 
> Huh, why and how?
> 
> It's impossible to apply this.
> 
> Best regards,
> Krzysztof

Thanks. Those prerequisite lines were included from b4 after adding the deps:
change-id: 20260108-axiado-ax3000-add-emmc-phy-driver-support-d61aead8f622:v1
base-commit: v6.19-rc4
I'll remove them.

Best regards,
TH

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 2/2] mmc: sdhci-of-arasan: add support on Axiado AX3000 SoC
  2026-01-12  8:23   ` Adrian Hunter
@ 2026-02-05  3:37     ` Tzu-Hao Wei
  0 siblings, 0 replies; 10+ messages in thread
From: Tzu-Hao Wei @ 2026-02-05  3:37 UTC (permalink / raw)
  To: Adrian Hunter
  Cc: linux-phy, devicetree, linux-arm-kernel, linux-kernel, linux-mmc,
	openbmc, SriNavmani A, Prasad Bolisetty, Vinod Koul,
	Neil Armstrong, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Ulf Hansson, Michal Simek

On 1/12/2026 4:23 PM, Adrian Hunter wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
> 
> 
> On 09/01/2026 11:46, Tzu-Hao Wei wrote:
>> From: SriNavmani A <srinavmani@axiado.com>
>>
>> Axiado AX3000 SoC eMMC controller is based on Arasan eMMC 5.1 host
>> controller IP.
>>
>> Signed-off-by: SriNavmani A <srinavmani@axiado.com>
>> Signed-off-by: Tzu-Hao Wei <twei@axiado.com>
> 
> Apart from dt-bindings issues:
> 
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> 
>> ---
>>  drivers/mmc/host/sdhci-of-arasan.c | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>
>> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
>> index ab7f0ffe7b4f007a58eb0a26868b08b0b02b40f3..5da915edd7416ab5c725a784867098c5e19236b6 100644
>> --- a/drivers/mmc/host/sdhci-of-arasan.c
>> +++ b/drivers/mmc/host/sdhci-of-arasan.c
>> @@ -1512,6 +1512,16 @@ static struct sdhci_arasan_of_data intel_keembay_sdio_data = {
>>       .clk_ops = &arasan_clk_ops,
>>  };
>>
>> +static const struct sdhci_pltfm_data sdhci_arasan_axiado_pdata = {
>> +     .ops = &sdhci_arasan_ops,
>> +     .quirks = SDHCI_QUIRK_BROKEN_CQE,
>> +};
>> +
>> +static struct sdhci_arasan_of_data sdhci_arasan_axiado_data = {
>> +     .pdata = &sdhci_arasan_axiado_pdata,
>> +     .clk_ops = &arasan_clk_ops,
>> +};
>> +
>>  static const struct of_device_id sdhci_arasan_of_match[] = {
>>       /* SoC-specific compatible strings w/ soc_ctl_map */
>>       {
>> @@ -1538,6 +1548,10 @@ static const struct of_device_id sdhci_arasan_of_match[] = {
>>               .compatible = "intel,keembay-sdhci-5.1-sdio",
>>               .data = &intel_keembay_sdio_data,
>>       },
>> +     {
>> +             .compatible = "axiado,ax3000-sdhci-5.1-emmc",
>> +             .data = &sdhci_arasan_axiado_data,
>> +     },
>>       /* Generic compatible below here */
>>       {
>>               .compatible = "arasan,sdhci-8.9a",
>>
> 
Thanks for reviewing.
There is one line change in the upcoming latest patch so I didn't add your Acked-by.

Best regards,
TH

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2026-02-05  3:37 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-09  9:46 [PATCH v2 0/2] Add Axiado AX3000 eMMC Host Controller Support Tzu-Hao Wei
2026-01-09  9:46 ` [PATCH v2 1/2] dt-bindings: mmc: arasan,sdhci: Add Axiado AX3000 SoC Tzu-Hao Wei
2026-01-09 11:29   ` Rob Herring (Arm)
2026-01-12  6:10     ` Tzu-Hao Wei
2026-01-12  8:46   ` Krzysztof Kozlowski
2026-01-09  9:46 ` [PATCH v2 2/2] mmc: sdhci-of-arasan: add support on " Tzu-Hao Wei
2026-01-12  8:23   ` Adrian Hunter
2026-02-05  3:37     ` Tzu-Hao Wei
2026-01-12  8:30 ` [PATCH v2 0/2] Add Axiado AX3000 eMMC Host Controller Support Krzysztof Kozlowski
2026-01-12 10:13   ` Tzu-Hao Wei

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®