From: Paolo Abeni <pabeni@redhat.com>
To: Tiernan Hubble <thubble@thubble.ca>,
Igor Russkikh <irusskikh@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3] net: atlantic: fix reading SFP module info on some AQC100 cards
Date: Tue, 24 Feb 2026 13:06:33 +0100 [thread overview]
Message-ID: <d3831e27-9d4b-4790-a7b4-74c3e87b5392@redhat.com> (raw)
In-Reply-To: <20260223004139.1444811-1-thubble@thubble.ca>
On 2/23/26 1:41 AM, Tiernan Hubble wrote:
> @@ -992,15 +1024,15 @@ static int aq_ethtool_get_module_info(struct net_device *ndev,
>
> /* Module EEPROM is only supported for controllers with external PHY */
> if (aq_nic->aq_nic_cfg.aq_hw_caps->media_type != AQ_HW_MEDIA_TYPE_FIBRE ||
> - !aq_nic->aq_hw_ops->hw_read_module_eeprom)
> + !aq_ethtool_can_read_module_eeprom(aq_nic))
> return -EOPNOTSUPP;
>
> - err = aq_nic->aq_hw_ops->hw_read_module_eeprom(aq_nic->aq_hw,
> + err = aq_ethtool_read_module_eeprom(aq_nic,
> SFF_8472_ID_ADDR, SFF_8472_COMP_ADDR, 1, &compliance_val);
I'm sorry for nit picking, but here and later this leads a quite bad
indentation. You should reformat the whole argument list according to
the kernel coding style, i.e.
err = aq_ethtool_read_module_eeprom(aq_nic, SFF_8472_ID_ADDR,
SFF_8472_COMP_ADDR, 1,
&compliance_val);
/P
prev parent reply other threads:[~2026-02-24 12:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 0:41 Tiernan Hubble
2026-02-24 12:06 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3831e27-9d4b-4790-a7b4-74c3e87b5392@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=irusskikh@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=thubble@thubble.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®