From: Camel Guo <camelg@axis.com>
To: Rob Herring <robh@kernel.org>, Camel Guo <Camel.Guo@axis.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kernel <kernel@axis.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: hwmon: Add TMP401, TMP411 and TMP43x
Date: Wed, 13 Apr 2022 16:16:17 +0200 [thread overview]
Message-ID: <d399e1a0-1eeb-f4f5-024c-6b29546723e1@axis.com> (raw)
In-Reply-To: <YlbRdCXnPPurC2wC@robh.at.kernel.org>
On 4/13/22 15:34, Rob Herring wrote:
> On Wed, Apr 13, 2022 at 09:13:39AM +0000, Camel Guo wrote:
>> On 4/12/22 23:36, Rob Herring wrote:
>> > On Tue, Apr 12, 2022 at 03:52:31PM +0200, Camel Guo wrote:
>> >> Document the TMP401, TMP411 and TMP43x device devicetree bindings
>> >>
>> >> + maximum: 15
>> >
>> > Drop 'items'. It is not an array.
>>
>> Not sure if I understand correctly. Do you means it should be like this?
>> If so, I guess ti,n-factor should also be changed like this. Am I right?
>>
>> ti,beta-compensation:
>> description:
>> value to select beta correction range.
>> $ref: /schemas/types.yaml#/definitions/uint32
>> minimum: 0
>> maximum: 15
>
> Yes, except your indentation is off. As-is, it's all 'description'. It
> should be like this:
>
> ti,beta-compensation:
> description:
> value to select beta correction range.
> $ref: /schemas/types.yaml#/definitions/uint32
> minimum: 0
> maximum: 15
>
> Rob
Now v3 is out with fixes on Rob's comments. Please review v3 instead.
next prev parent reply other threads:[~2022-04-13 14:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 13:52 [PATCH v2 0/2] hwmon/tmp401: add support of three advanced features Camel Guo
2022-04-12 13:52 ` [PATCH v2 1/2] dt-bindings: hwmon: Add TMP401, TMP411 and TMP43x Camel Guo
2022-04-12 16:30 ` Krzysztof Kozlowski
2022-04-12 21:36 ` Rob Herring
2022-04-13 9:13 ` Camel Guo
2022-04-13 13:34 ` Rob Herring
2022-04-13 14:16 ` Camel Guo [this message]
2022-04-12 13:52 ` [PATCH v2 2/2] hwmon: (tmp401) Add support of three advanced features Camel Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d399e1a0-1eeb-f4f5-024c-6b29546723e1@axis.com \
--to=camelg@axis.com \
--cc=Camel.Guo@axis.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=kernel@axis.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®