From: Hans de Goede <hdegoede@redhat.com>
To: Michael Straube <straube.linux@gmail.com>, gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: remove unused macros from ioctl_linux.c
Date: Fri, 10 Sep 2021 08:24:27 +0200 [thread overview]
Message-ID: <d39f410e-ac89-54e1-5c54-a17bdc5ebc49@redhat.com> (raw)
In-Reply-To: <20210909211922.24872-1-straube.linux@gmail.com>
Hi,
On 9/9/21 11:19 PM, Michael Straube wrote:
> These macros are not used in the driver, remove them.
> Found with GCC -Wunused-macros.
>
> Signed-off-by: Michael Straube <straube.linux@gmail.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> index 908022a17b3f..27fb1be036b8 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> @@ -15,20 +15,6 @@
>
> #define RTL_IOCTL_WPA_SUPPLICANT (SIOCIWFIRSTPRIV+30)
>
> -#define SCAN_ITEM_SIZE 768
> -#define MAX_CUSTOM_LEN 64
> -#define RATE_COUNT 4
> -
> -/* combo scan */
> -#define WEXT_CSCAN_HEADER "CSCAN S\x01\x00\x00S\x00"
> -#define WEXT_CSCAN_HEADER_SIZE 12
> -#define WEXT_CSCAN_SSID_SECTION 'S'
> -#define WEXT_CSCAN_CHANNEL_SECTION 'C'
> -#define WEXT_CSCAN_ACTV_DWELL_SECTION 'A'
> -#define WEXT_CSCAN_PASV_DWELL_SECTION 'P'
> -#define WEXT_CSCAN_HOME_DWELL_SECTION 'H'
> -#define WEXT_CSCAN_TYPE_SECTION 'T'
> -
> static int wpa_set_auth_algs(struct net_device *dev, u32 value)
> {
> struct adapter *padapter = rtw_netdev_priv(dev);
>
next prev parent reply other threads:[~2021-09-10 6:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 21:19 Michael Straube
2021-09-10 6:24 ` Hans de Goede [this message]
2021-09-10 8:12 ` Michael Straube
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d39f410e-ac89-54e1-5c54-a17bdc5ebc49@redhat.com \
--to=hdegoede@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®