* [PATCH][next][V3] rv: Fix addition on an uninitialized variable 'run'
@ 2023-04-24 9:47 Colin Ian King
2023-04-25 7:55 ` Daniel Bristot de Oliveira
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2023-04-24 9:47 UTC (permalink / raw)
To: Daniel Bristot de Oliveira, Steven Rostedt, linux-trace-devel
Cc: kernel-janitors, linux-kernel
The variable run is not initialized however it is being accumulated
by the return value from the call to ikm_run_monitor. Fix this by
initializing run to zero at the start of the function.
Fixes: 4bc4b131d44c ("rv: Add rv tool")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
V2: Initialize run rather than assign it from return from ikm_run_monitor
V3: Add missing V3 and next in patch subject
---
tools/verification/rv/src/rv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/verification/rv/src/rv.c b/tools/verification/rv/src/rv.c
index e601cd9c411e..1ddb85532816 100644
--- a/tools/verification/rv/src/rv.c
+++ b/tools/verification/rv/src/rv.c
@@ -74,7 +74,7 @@ static void rv_list(int argc, char **argv)
static void rv_mon(int argc, char **argv)
{
char *monitor_name;
- int i, run;
+ int i, run = 0;
static const char *const usage[] = {
"",
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH][next][V3] rv: Fix addition on an uninitialized variable 'run'
2023-04-24 9:47 [PATCH][next][V3] rv: Fix addition on an uninitialized variable 'run' Colin Ian King
@ 2023-04-25 7:55 ` Daniel Bristot de Oliveira
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Bristot de Oliveira @ 2023-04-25 7:55 UTC (permalink / raw)
To: Colin Ian King, Steven Rostedt, linux-trace-devel
Cc: kernel-janitors, linux-kernel
On 4/24/23 11:47, Colin Ian King wrote:
> The variable run is not initialized however it is being accumulated
> by the return value from the call to ikm_run_monitor. Fix this by
> initializing run to zero at the start of the function.
>
> Fixes: 4bc4b131d44c ("rv: Add rv tool")
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Acked-by: Daniel Bristot de Oliveira <bristot@kernel.org>
Thanks!
-- Daniel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-25 7:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-24 9:47 [PATCH][next][V3] rv: Fix addition on an uninitialized variable 'run' Colin Ian King
2023-04-25 7:55 ` Daniel Bristot de Oliveira
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®