From: Alexey Budankov <alexey.budankov@linux.intel.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
kernel-team@lge.com
Subject: Re: [PATCH v9 3/3]: perf record: extend trace writing to multi AIO
Date: Fri, 5 Oct 2018 10:54:57 +0300 [thread overview]
Message-ID: <d3e47f64-ebcd-c8a1-ede9-f7a756bc1263@linux.intel.com> (raw)
In-Reply-To: <20181005072248.GD3768@sejong>
Hi,
On 05.10.2018 10:22, Namhyung Kim wrote:
> On Wed, Oct 03, 2018 at 07:17:01PM +0300, Alexey Budankov wrote:
<SNIP>
>> @@ -1833,6 +1861,10 @@ static struct option __record_options[] = {
>> "signal"),
>> OPT_BOOLEAN(0, "dry-run", &dry_run,
>> "Parse options then exit"),
>> +#ifdef HAVE_AIO_SUPPORT
>> + OPT_INTEGER(0, "aio-cblocks", &record.opts.nr_cblocks,
>> + "Max number of simultaneous per-mmap trace writes (default: 0 - serial, max: 4)"),
>> +#endif
>> OPT_END()
>> };
>
> Please update the documentation for the new option and config
Accepted.
> variable. Perhaps it can provide the option always and check the
> availability at runtime (with a warning message if not enabled).
Not sure if this complication is really required.
So far NO_AIO define is possible at compile time.
Thanks,
Alexey
next prev parent reply other threads:[~2018-10-05 7:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 15:54 [PATCH v9 0/3]: perf: reduce data loss when profiling highly parallel CPU bound workloads Alexey Budankov
2018-10-03 16:01 ` [PATCH v9 1/3]: perf util: map data buffer for preserving collected data Alexey Budankov
2018-10-05 6:23 ` Namhyung Kim
2018-10-05 7:03 ` Alexey Budankov
2018-10-05 7:29 ` Alexey Budankov
2018-10-03 16:12 ` [PATCH v9 2/3]: perf record: enable asynchronous trace writing Alexey Budankov
2018-10-05 7:16 ` Namhyung Kim
2018-10-05 8:31 ` Alexey Budankov
2018-10-05 8:48 ` Namhyung Kim
2018-10-05 9:39 ` Alexey Budankov
2018-10-05 10:55 ` Namhyung Kim
2018-10-05 11:50 ` Alexey Budankov
2018-10-05 15:53 ` Alexey Budankov
2018-10-03 16:17 ` [PATCH v9 3/3]: perf record: extend trace writing to multi AIO Alexey Budankov
2018-10-05 7:22 ` Namhyung Kim
2018-10-05 7:54 ` Alexey Budankov [this message]
2018-10-05 13:35 [PATCH v10 0/3]: perf: reduce data loss when profiling highly parallel CPU bound workloads Alexey Budankov
2018-10-05 13:50 ` [PATCH v9 3/3]: perf record: extend trace writing to multi AIO Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3e47f64-ebcd-c8a1-ede9-f7a756bc1263@linux.intel.com \
--to=alexey.budankov@linux.intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome