* [PATCH] mailbox: stm32-ipcc: Use devm_clk_get_enabled() in stm32_ipcc_probe()
@ 2026-11-22 17:54 Markus Elfring
0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2026-11-22 17:54 UTC (permalink / raw)
To: linux-stm32, linux-arm-kernel, Alexandre Torgue, Fabien Dessenne,
Jassi Brar, Ludovic Barre, Maxime Coquelin
Cc: LKML, kernel-janitors, Andy Shevchenko, Christophe Jaillet,
Florian Fainelli, Frank Li, Michal Simek
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 22 Nov 2026 18:42:21 +0100
* Reuse existing functionality from devm_clk_get_enabled() instead of
keeping duplicate source code.
* Omit a clk_disable_unprepare() call on an error handling path.
* Delete the label “err_clk”.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/mailbox/stm32-ipcc.c | 18 ++++--------------
1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/drivers/mailbox/stm32-ipcc.c b/drivers/mailbox/stm32-ipcc.c
index e88e198436a6..25d8138a3695 100644
--- a/drivers/mailbox/stm32-ipcc.c
+++ b/drivers/mailbox/stm32-ipcc.c
@@ -242,29 +242,21 @@ static int stm32_ipcc_probe(struct platform_device *pdev)
ipcc->reg_proc = ipcc->reg_base + ipcc->proc_id * IPCC_PROC_OFFST;
/* clock */
- ipcc->clk = devm_clk_get(dev, NULL);
+ ipcc->clk = devm_clk_get_enabled(dev, NULL);
if (IS_ERR(ipcc->clk))
return PTR_ERR(ipcc->clk);
- ret = clk_prepare_enable(ipcc->clk);
- if (ret) {
- dev_err(dev, "can not enable the clock\n");
- return ret;
- }
-
/* irq */
for (i = 0; i < IPCC_IRQ_NUM; i++) {
ipcc->irqs[i] = platform_get_irq_byname(pdev, irq_name[i]);
- if (ipcc->irqs[i] < 0) {
- ret = ipcc->irqs[i];
- goto err_clk;
- }
+ if (ipcc->irqs[i] < 0)
+ return ipcc->irqs[i];
ret = devm_request_threaded_irq(dev, ipcc->irqs[i], NULL,
irq_thread[i], IRQF_ONESHOT,
dev_name(dev), ipcc);
if (ret)
- goto err_clk;
+ return ret;
}
/* mask and enable rx/tx irq */
@@ -323,8 +315,6 @@ static int stm32_ipcc_probe(struct platform_device *pdev)
dev_pm_clear_wake_irq(dev);
err_init_wkp:
device_set_wakeup_capable(dev, false);
-err_clk:
- clk_disable_unprepare(ipcc->clk);
return ret;
}
--
2.56.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-22 17:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-22 17:54 [PATCH] mailbox: stm32-ipcc: Use devm_clk_get_enabled() in stm32_ipcc_probe() Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®