* [PATCH] partitions/ldm: remove redundant pointer dgrp
@ 2018-07-02 7:13 Colin King
2018-07-02 14:26 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-07-02 7:13 UTC (permalink / raw)
To: Richard Russon, Jens Axboe, linux-ntfs-dev, linux-block
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer dgrp is being assigned but is never used hence it is redundant
and can be removed.
Cleans up clang warning:
warning: variable 'dgrp' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
block/partitions/ldm.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/block/partitions/ldm.c b/block/partitions/ldm.c
index 0417937dfe99..16766f267559 100644
--- a/block/partitions/ldm.c
+++ b/block/partitions/ldm.c
@@ -830,7 +830,6 @@ static bool ldm_parse_dgr4 (const u8 *buffer, int buflen, struct vblk *vb)
{
char buf[64];
int r_objid, r_name, r_id1, r_id2, len;
- struct vblk_dgrp *dgrp;
BUG_ON (!buffer || !vb);
@@ -853,8 +852,6 @@ static bool ldm_parse_dgr4 (const u8 *buffer, int buflen, struct vblk *vb)
if (len != get_unaligned_be32(buffer + 0x14))
return false;
- dgrp = &vb->vblk.dgrp;
-
ldm_get_vstr (buffer + 0x18 + r_objid, buf, sizeof (buf));
return true;
}
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] partitions/ldm: remove redundant pointer dgrp
2018-07-02 7:13 [PATCH] partitions/ldm: remove redundant pointer dgrp Colin King
@ 2018-07-02 14:26 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2018-07-02 14:26 UTC (permalink / raw)
To: Colin King, Richard Russon, linux-ntfs-dev, linux-block
Cc: kernel-janitors, linux-kernel
On 7/2/18 1:13 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer dgrp is being assigned but is never used hence it is redundant
> and can be removed.
>
> Cleans up clang warning:
> warning: variable 'dgrp' set but not used [-Wunused-but-set-variable]
Applied for 4.19, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-02 14:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-02 7:13 [PATCH] partitions/ldm: remove redundant pointer dgrp Colin King
2018-07-02 14:26 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome