Re: [PATCH] irqchip: or1k-pic: Fix interrupt system.

Re: [PATCH] irqchip: or1k-pic: Fix interrupt system.

[Stafford Horne]

+CC Kernel List

On Fri, Jun 30, 2017 at 08:33:56AM -0300, Pedro H. Penna wrote:
> Usually, hardware implicitly acknowledges interruts when
> reading them. However, if this is not the case, the IRQ
> gets fired over and over again in the current implementation.
> 
> This patch uses the right mask acknowledge function to handle the
> aforementioned situation on or1k processors that interact with
> such kind of hardware.
> 
> Signed-off-by: Pedro H. Penna <pedrohenriquepenna@gmail.com>

Acked-by: Stafford Horne

I am ok to take this patch into my tree if no one objects.  But if someone
wants to take it through the drive tree I am fine too.

> ---
>  drivers/irqchip/irq-or1k-pic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-or1k-pic.c b/drivers/irqchip/irq-or1k-pic.c
> index 6a9a3e7..dd9d5d1 100644
> --- a/drivers/irqchip/irq-or1k-pic.c
> +++ b/drivers/irqchip/irq-or1k-pic.c
> @@ -70,7 +70,7 @@ static struct or1k_pic_dev or1k_pic_level = {
>  		.name = "or1k-PIC-level",
>  		.irq_unmask = or1k_pic_unmask,
>  		.irq_mask = or1k_pic_mask,
> -		.irq_mask_ack = or1k_pic_mask,
> +		.irq_mask_ack = or1k_pic_mask_ack,
>  	},
>  	.handle = handle_level_irq,
>  	.flags = IRQ_LEVEL | IRQ_NOPROBE,
> -- 
> 2.7.4
> 

Re: [PATCH] irqchip: or1k-pic: Fix interrupt system.

[Marc Zyngier]

On 30/06/17 14:04, Stafford Horne wrote:
> +CC Kernel List
> 
> On Fri, Jun 30, 2017 at 08:33:56AM -0300, Pedro H. Penna wrote:
>> Usually, hardware implicitly acknowledges interruts when
>> reading them. However, if this is not the case, the IRQ
>> gets fired over and over again in the current implementation.
>>
>> This patch uses the right mask acknowledge function to handle the
>> aforementioned situation on or1k processors that interact with
>> such kind of hardware.
>>
>> Signed-off-by: Pedro H. Penna <pedrohenriquepenna@gmail.com>
> 
> Acked-by: Stafford Horne

Can you please Ack it with an email address?

> 
> I am ok to take this patch into my tree if no one objects.  But if someone
> wants to take it through the drive tree I am fine too.

I'll queue it through my tree, as I have some last minute fixes to send
to Thomas.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

Re: [PATCH] irqchip: or1k-pic: Fix interrupt system.

[Stafford Horne]

On Fri, Jun 30, 2017 at 02:09:32PM +0100, Marc Zyngier wrote:
> On 30/06/17 14:04, Stafford Horne wrote:
> > +CC Kernel List
> > 
> > On Fri, Jun 30, 2017 at 08:33:56AM -0300, Pedro H. Penna wrote:
> >> Usually, hardware implicitly acknowledges interruts when
> >> reading them. However, if this is not the case, the IRQ
> >> gets fired over and over again in the current implementation.
> >>
> >> This patch uses the right mask acknowledge function to handle the
> >> aforementioned situation on or1k processors that interact with
> >> such kind of hardware.
> >>
> >> Signed-off-by: Pedro H. Penna <pedrohenriquepenna@gmail.com>
> > 
> > Acked-by: Stafford Horne
> 
> Can you please Ack it with an email address?

Sorry about that:

Acked-by: Stafford Horne <shorne@gmail.com>

> > 
> > I am ok to take this patch into my tree if no one objects.  But if someone
> > wants to take it through the drive tree I am fine too.
> 
> I'll queue it through my tree, as I have some last minute fixes to send
> to Thomas.

Thanks,

-Stafford