From: Joe Perches <joe@perches.com>
To: Paul Cercueil <paul@crapouillou.net>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: balbi@kernel.org, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] usb: phy: jz4770: Add a missing '\n' in a log message
Date: Sat, 11 Apr 2020 08:46:49 -0700 [thread overview]
Message-ID: <d42889be3ae1c77c6ca33d9dbd87ab46c749cfff.camel@perches.com> (raw)
In-Reply-To: <ZQKM8Q.561QQF8CXZTU3@crapouillou.net>
On Sat, 2020-04-11 at 15:13 +0200, Paul Cercueil wrote:
> Hi Christophe,
>
> Le sam. 11 avril 2020 à 8:38, Christophe JAILLET
> <christophe.jaillet@wanadoo.fr> a écrit :
> > Message logged by 'dev_xxx()' or 'pr_xxx()' should end with a '\n'.
>
> Is that so?
> From what I could see these macros add the \n themselves if needed.
Not so.
> So the \n were omitted on purpose.
Just a trivial oversight really.
AFAIK: It's an issue _only_ in two cases:
p another process emits a printk with KERN_CONT (or pr_cont)
that might extend this message in the log on the same line.
o this message wukk not be emitted into the log until another
message arrives
next prev parent reply other threads:[~2020-04-11 15:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 6:38 Christophe JAILLET
2020-04-11 13:13 ` Paul Cercueil
2020-04-11 15:46 ` Joe Perches [this message]
2020-04-14 9:31 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d42889be3ae1c77c6ca33d9dbd87ab46c749cfff.camel@perches.com \
--to=joe@perches.com \
--cc=balbi@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®