From: Jeff Layton <jlayton@kernel.org>
To: Chen Ni <nichen@iscas.ac.cn>, trondmy@kernel.org, anna@kernel.org
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfs: nfs4proc: Convert comma to semicolon
Date: Tue, 03 Feb 2026 08:32:06 -0500 [thread overview]
Message-ID: <d4461ad8bdd78b0d0d4a5dd4b857053602e4175f.camel@kernel.org> (raw)
In-Reply-To: <20260203010940.366106-1-nichen@iscas.ac.cn>
On Tue, 2026-02-03 at 09:09 +0800, Chen Ni wrote:
> Replace comma between expressions with semicolons.
>
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
>
> Found by inspection.
> No functional change intended.
> Compile tested only.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> fs/nfs/nfs4proc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index 7c9cf0983366..dacd330fc623 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -5016,7 +5016,7 @@ static void nfs4_proc_rename_setup(struct rpc_message *msg,
> if (same_parent)
> nfs_request_directory_delegation(same_parent);
> msg->rpc_proc = &nfs4_procedures[NFSPROC4_CLNT_RENAME];
> - res->server = server,
> + res->server = server;
> nfs4_init_sequence(server->nfs_client, &arg->seq_args,
> &res->seq_res, 1, 0);
> }
Almost certainly a typo.
Reviewed-by: Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2026-02-03 13:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 1:09 Chen Ni
2026-02-03 13:32 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4461ad8bdd78b0d0d4a5dd4b857053602e4175f.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=anna@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=nichen@iscas.ac.cn \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®