* [PATCH] nfs: nfs4proc: Convert comma to semicolon
@ 2026-02-03 1:09 Chen Ni
2026-02-03 13:32 ` Jeff Layton
0 siblings, 1 reply; 2+ messages in thread
From: Chen Ni @ 2026-02-03 1:09 UTC (permalink / raw)
To: trondmy, anna; +Cc: linux-nfs, linux-kernel, Chen Ni
Replace comma between expressions with semicolons.
Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it is seems best to use ';'
unless ',' is intended.
Found by inspection.
No functional change intended.
Compile tested only.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
fs/nfs/nfs4proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 7c9cf0983366..dacd330fc623 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -5016,7 +5016,7 @@ static void nfs4_proc_rename_setup(struct rpc_message *msg,
if (same_parent)
nfs_request_directory_delegation(same_parent);
msg->rpc_proc = &nfs4_procedures[NFSPROC4_CLNT_RENAME];
- res->server = server,
+ res->server = server;
nfs4_init_sequence(server->nfs_client, &arg->seq_args,
&res->seq_res, 1, 0);
}
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] nfs: nfs4proc: Convert comma to semicolon
2026-02-03 1:09 [PATCH] nfs: nfs4proc: Convert comma to semicolon Chen Ni
@ 2026-02-03 13:32 ` Jeff Layton
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Layton @ 2026-02-03 13:32 UTC (permalink / raw)
To: Chen Ni, trondmy, anna; +Cc: linux-nfs, linux-kernel
On Tue, 2026-02-03 at 09:09 +0800, Chen Ni wrote:
> Replace comma between expressions with semicolons.
>
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
>
> Found by inspection.
> No functional change intended.
> Compile tested only.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> fs/nfs/nfs4proc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index 7c9cf0983366..dacd330fc623 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -5016,7 +5016,7 @@ static void nfs4_proc_rename_setup(struct rpc_message *msg,
> if (same_parent)
> nfs_request_directory_delegation(same_parent);
> msg->rpc_proc = &nfs4_procedures[NFSPROC4_CLNT_RENAME];
> - res->server = server,
> + res->server = server;
> nfs4_init_sequence(server->nfs_client, &arg->seq_args,
> &res->seq_res, 1, 0);
> }
Almost certainly a typo.
Reviewed-by: Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-03 13:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-03 1:09 [PATCH] nfs: nfs4proc: Convert comma to semicolon Chen Ni
2026-02-03 13:32 ` Jeff Layton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®