* [PATCH] [media] media: imx: use setup_timer
@ 2017-08-13 18:39 Cihangir Akturk
2017-08-14 7:26 ` Philipp Zabel
2017-08-14 23:05 ` Steve Longerbeam
0 siblings, 2 replies; 3+ messages in thread
From: Cihangir Akturk @ 2017-08-13 18:39 UTC (permalink / raw)
Cc: Cihangir Akturk, Steve Longerbeam, Philipp Zabel,
Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media, devel,
linux-kernel
Use setup_timer function instead of initializing timer with the
function and data fields.
Generated by: scripts/coccinelle/api/setup_timer.cocci.
Signed-off-by: Cihangir Akturk <cakturk@gmail.com>
---
drivers/staging/media/imx/imx-ic-prpencvf.c | 5 ++---
drivers/staging/media/imx/imx-media-csi.c | 5 ++---
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/media/imx/imx-ic-prpencvf.c b/drivers/staging/media/imx/imx-ic-prpencvf.c
index ed363fe..65f5729 100644
--- a/drivers/staging/media/imx/imx-ic-prpencvf.c
+++ b/drivers/staging/media/imx/imx-ic-prpencvf.c
@@ -1278,9 +1278,8 @@ static int prp_init(struct imx_ic_priv *ic_priv)
priv->ic_priv = ic_priv;
spin_lock_init(&priv->irqlock);
- init_timer(&priv->eof_timeout_timer);
- priv->eof_timeout_timer.data = (unsigned long)priv;
- priv->eof_timeout_timer.function = prp_eof_timeout;
+ setup_timer(&priv->eof_timeout_timer, prp_eof_timeout,
+ (unsigned long)priv);
priv->vdev = imx_media_capture_device_init(&ic_priv->sd,
PRPENCVF_SRC_PAD);
diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
index a2d2669..8fef5f1 100644
--- a/drivers/staging/media/imx/imx-media-csi.c
+++ b/drivers/staging/media/imx/imx-media-csi.c
@@ -1731,9 +1731,8 @@ static int imx_csi_probe(struct platform_device *pdev)
priv->csi_id = pdata->csi;
priv->smfc_id = (priv->csi_id == 0) ? 0 : 2;
- init_timer(&priv->eof_timeout_timer);
- priv->eof_timeout_timer.data = (unsigned long)priv;
- priv->eof_timeout_timer.function = csi_idmac_eof_timeout;
+ setup_timer(&priv->eof_timeout_timer, csi_idmac_eof_timeout,
+ (unsigned long)priv);
spin_lock_init(&priv->irqlock);
v4l2_subdev_init(&priv->sd, &csi_subdev_ops);
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [media] media: imx: use setup_timer
2017-08-13 18:39 [PATCH] [media] media: imx: use setup_timer Cihangir Akturk
@ 2017-08-14 7:26 ` Philipp Zabel
2017-08-14 23:05 ` Steve Longerbeam
1 sibling, 0 replies; 3+ messages in thread
From: Philipp Zabel @ 2017-08-14 7:26 UTC (permalink / raw)
To: Cihangir Akturk
Cc: Steve Longerbeam, Mauro Carvalho Chehab, Greg Kroah-Hartman,
linux-media, devel, linux-kernel
On Sun, 2017-08-13 at 21:39 +0300, Cihangir Akturk wrote:
> Use setup_timer function instead of initializing timer with the
> function and data fields.
>
> Generated by: scripts/coccinelle/api/setup_timer.cocci.
>
> Signed-off-by: Cihangir Akturk <cakturk@gmail.com>
> ---
> drivers/staging/media/imx/imx-ic-prpencvf.c | 5 ++---
> drivers/staging/media/imx/imx-media-csi.c | 5 ++---
> 2 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx-ic-prpencvf.c
> b/drivers/staging/media/imx/imx-ic-prpencvf.c
> index ed363fe..65f5729 100644
> --- a/drivers/staging/media/imx/imx-ic-prpencvf.c
> +++ b/drivers/staging/media/imx/imx-ic-prpencvf.c
> @@ -1278,9 +1278,8 @@ static int prp_init(struct imx_ic_priv
> *ic_priv)
> priv->ic_priv = ic_priv;
>
> spin_lock_init(&priv->irqlock);
> - init_timer(&priv->eof_timeout_timer);
> - priv->eof_timeout_timer.data = (unsigned long)priv;
> - priv->eof_timeout_timer.function = prp_eof_timeout;
> + setup_timer(&priv->eof_timeout_timer, prp_eof_timeout,
> + (unsigned long)priv);
>
> priv->vdev = imx_media_capture_device_init(&ic_priv->sd,
> PRPENCVF_SRC_PAD)
> ;
> diff --git a/drivers/staging/media/imx/imx-media-csi.c
> b/drivers/staging/media/imx/imx-media-csi.c
> index a2d2669..8fef5f1 100644
> --- a/drivers/staging/media/imx/imx-media-csi.c
> +++ b/drivers/staging/media/imx/imx-media-csi.c
> @@ -1731,9 +1731,8 @@ static int imx_csi_probe(struct platform_device
> *pdev)
> priv->csi_id = pdata->csi;
> priv->smfc_id = (priv->csi_id == 0) ? 0 : 2;
>
> - init_timer(&priv->eof_timeout_timer);
> - priv->eof_timeout_timer.data = (unsigned long)priv;
> - priv->eof_timeout_timer.function = csi_idmac_eof_timeout;
> + setup_timer(&priv->eof_timeout_timer, csi_idmac_eof_timeout,
> + (unsigned long)priv);
> spin_lock_init(&priv->irqlock);
>
> v4l2_subdev_init(&priv->sd, &csi_subdev_ops);
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [media] media: imx: use setup_timer
2017-08-13 18:39 [PATCH] [media] media: imx: use setup_timer Cihangir Akturk
2017-08-14 7:26 ` Philipp Zabel
@ 2017-08-14 23:05 ` Steve Longerbeam
1 sibling, 0 replies; 3+ messages in thread
From: Steve Longerbeam @ 2017-08-14 23:05 UTC (permalink / raw)
To: Cihangir Akturk
Cc: Philipp Zabel, Mauro Carvalho Chehab, Greg Kroah-Hartman,
linux-media, devel, linux-kernel
Thanks,
Reviewed-by: Steve Longerbeam <steve_longerbeam@mentor.com>
Tested-by: Steve Longerbeam <steve_longerbeam@mentor.com>
Steve
On 08/13/2017 11:39 AM, Cihangir Akturk wrote:
> Use setup_timer function instead of initializing timer with the
> function and data fields.
>
> Generated by: scripts/coccinelle/api/setup_timer.cocci.
>
> Signed-off-by: Cihangir Akturk <cakturk@gmail.com>
> ---
> drivers/staging/media/imx/imx-ic-prpencvf.c | 5 ++---
> drivers/staging/media/imx/imx-media-csi.c | 5 ++---
> 2 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx-ic-prpencvf.c b/drivers/staging/media/imx/imx-ic-prpencvf.c
> index ed363fe..65f5729 100644
> --- a/drivers/staging/media/imx/imx-ic-prpencvf.c
> +++ b/drivers/staging/media/imx/imx-ic-prpencvf.c
> @@ -1278,9 +1278,8 @@ static int prp_init(struct imx_ic_priv *ic_priv)
> priv->ic_priv = ic_priv;
>
> spin_lock_init(&priv->irqlock);
> - init_timer(&priv->eof_timeout_timer);
> - priv->eof_timeout_timer.data = (unsigned long)priv;
> - priv->eof_timeout_timer.function = prp_eof_timeout;
> + setup_timer(&priv->eof_timeout_timer, prp_eof_timeout,
> + (unsigned long)priv);
>
> priv->vdev = imx_media_capture_device_init(&ic_priv->sd,
> PRPENCVF_SRC_PAD);
> diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
> index a2d2669..8fef5f1 100644
> --- a/drivers/staging/media/imx/imx-media-csi.c
> +++ b/drivers/staging/media/imx/imx-media-csi.c
> @@ -1731,9 +1731,8 @@ static int imx_csi_probe(struct platform_device *pdev)
> priv->csi_id = pdata->csi;
> priv->smfc_id = (priv->csi_id == 0) ? 0 : 2;
>
> - init_timer(&priv->eof_timeout_timer);
> - priv->eof_timeout_timer.data = (unsigned long)priv;
> - priv->eof_timeout_timer.function = csi_idmac_eof_timeout;
> + setup_timer(&priv->eof_timeout_timer, csi_idmac_eof_timeout,
> + (unsigned long)priv);
> spin_lock_init(&priv->irqlock);
>
> v4l2_subdev_init(&priv->sd, &csi_subdev_ops);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-14 23:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-13 18:39 [PATCH] [media] media: imx: use setup_timer Cihangir Akturk
2017-08-14 7:26 ` Philipp Zabel
2017-08-14 23:05 ` Steve Longerbeam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome