From: Shuah Khan <skhan@linuxfoundation.org>
To: "Mickaël Salaün" <mic@digikod.net>,
"Kees Cook" <keescook@chromium.org>,
"Shuah Khan" <shuah@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
"Tycho Andersen" <tycho@tycho.pizza>,
"Mickaël Salaün" <mic@linux.microsoft.com>,
"Shuah Khan" <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests/seccomp: Update kernel config
Date: Tue, 10 Nov 2020 14:36:56 -0700 [thread overview]
Message-ID: <d4723ea9-d561-fc0c-c4c5-24c6fd454064@linuxfoundation.org> (raw)
In-Reply-To: <20201030121819.764395-1-mic@digikod.net>
On 10/30/20 6:18 AM, Mickaël Salaün wrote:
> seccomp_bpf.c uses unshare(CLONE_NEWPID), which requires CONFIG_PID_NS
> to be set.
>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: Tycho Andersen <tycho@tycho.pizza>
> Fixes: 6a21cc50f0c7 ("seccomp: add a return code to trap to userspace")
> Signed-off-by: Mickaël Salaün <mic@linux.microsoft.com>
> ---
> tools/testing/selftests/seccomp/config | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/seccomp/config b/tools/testing/selftests/seccomp/config
> index 64c19d8eba79..ad431a5178fb 100644
> --- a/tools/testing/selftests/seccomp/config
> +++ b/tools/testing/selftests/seccomp/config
> @@ -1,3 +1,4 @@
> +CONFIG_PID_NS=y
> CONFIG_SECCOMP=y
> CONFIG_SECCOMP_FILTER=y
> CONFIG_USER_NS=y
>
> base-commit: 3650b228f83adda7e5ee532e2b90429c03f7b9ec
>
Your from and Signed-off-by don't match. Please send the patch
from your igned-off-by address.
WARNING: From:/Signed-off-by: email address mismatch: 'From: "Mickaël
Salaün" <mic@digikod.net>' != 'Signed-off-by: Mickaël Salaün
<mic@linux.microsoft.com>'
thanks,
-- Shuah
next prev parent reply other threads:[~2020-11-10 21:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 12:18 Mickaël Salaün
2020-11-10 21:36 ` Shuah Khan [this message]
2020-12-02 16:26 Mickaël Salaün
2020-12-02 19:22 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4723ea9-d561-fc0c-c4c5-24c6fd454064@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mic@digikod.net \
--cc=mic@linux.microsoft.com \
--cc=shuah@kernel.org \
--cc=tycho@tycho.pizza \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®