* [RFC PATCH] platform/x86: asus-nb-wmi: Ignore unknown event 0xCF
@ 2024-11-23 22:47 Armin Wolf
2024-11-25 9:39 ` Hans de Goede
2024-12-02 17:03 ` Ilpo Järvinen
0 siblings, 2 replies; 4+ messages in thread
From: Armin Wolf @ 2024-11-23 22:47 UTC (permalink / raw)
To: pespin, corentin.chary, luke
Cc: hdegoede, ilpo.jarvinen, platform-driver-x86, linux-kernel
On the Asus X541UAK an unknown event 0xCF is emited when the charger
is plugged in. This is caused by the following AML code:
If (ACPS ())
{
ACPF = One
Local0 = 0x58
If (ATKP)
{
^^^^ATKD.IANE (0xCF)
}
}
Else
{
ACPF = Zero
Local0 = 0x57
}
Notify (AC0, 0x80) // Status Change
If (ATKP)
{
^^^^ATKD.IANE (Local0)
}
Sleep (0x64)
PNOT ()
Sleep (0x0A)
NBAT (0x80)
Ignore the 0xCF event to silence the unknown event warning.
Reported-by: Pau Espin Pedrol <pespin@espeweb.net>
Closes: https://lore.kernel.org/platform-driver-x86/54d4860b-ec9c-4992-acf6-db3f90388293@espeweb.net
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
---
drivers/platform/x86/asus-nb-wmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
index ef04d396f61c..a5933980ade3 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86/asus-nb-wmi.c
@@ -623,6 +623,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
{ KE_KEY, 0xC4, { KEY_KBDILLUMUP } },
{ KE_KEY, 0xC5, { KEY_KBDILLUMDOWN } },
{ KE_IGNORE, 0xC6, }, /* Ambient Light Sensor notification */
+ { KE_IGNORE, 0xCF, }, /* AC mode */
{ KE_KEY, 0xFA, { KEY_PROG2 } }, /* Lid flip action */
{ KE_KEY, 0xBD, { KEY_PROG2 } }, /* Lid flip action on ROG xflow laptops */
{ KE_END, 0},
--
2.39.5
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [RFC PATCH] platform/x86: asus-nb-wmi: Ignore unknown event 0xCF
2024-11-23 22:47 [RFC PATCH] platform/x86: asus-nb-wmi: Ignore unknown event 0xCF Armin Wolf
@ 2024-11-25 9:39 ` Hans de Goede
2024-11-29 19:30 ` Armin Wolf
2024-12-02 17:03 ` Ilpo Järvinen
1 sibling, 1 reply; 4+ messages in thread
From: Hans de Goede @ 2024-11-25 9:39 UTC (permalink / raw)
To: Armin Wolf, pespin, corentin.chary, luke
Cc: ilpo.jarvinen, platform-driver-x86, linux-kernel
Hi,
On 23-Nov-24 11:47 PM, Armin Wolf wrote:
> On the Asus X541UAK an unknown event 0xCF is emited when the charger
> is plugged in. This is caused by the following AML code:
>
> If (ACPS ())
> {
> ACPF = One
> Local0 = 0x58
> If (ATKP)
> {
> ^^^^ATKD.IANE (0xCF)
> }
> }
> Else
> {
> ACPF = Zero
> Local0 = 0x57
> }
>
> Notify (AC0, 0x80) // Status Change
> If (ATKP)
> {
> ^^^^ATKD.IANE (Local0)
> }
>
> Sleep (0x64)
> PNOT ()
> Sleep (0x0A)
> NBAT (0x80)
>
> Ignore the 0xCF event to silence the unknown event warning.
>
> Reported-by: Pau Espin Pedrol <pespin@espeweb.net>
> Closes: https://lore.kernel.org/platform-driver-x86/54d4860b-ec9c-4992-acf6-db3f90388293@espeweb.net
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/platform/x86/asus-nb-wmi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> index ef04d396f61c..a5933980ade3 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -623,6 +623,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
> { KE_KEY, 0xC4, { KEY_KBDILLUMUP } },
> { KE_KEY, 0xC5, { KEY_KBDILLUMDOWN } },
> { KE_IGNORE, 0xC6, }, /* Ambient Light Sensor notification */
> + { KE_IGNORE, 0xCF, }, /* AC mode */
> { KE_KEY, 0xFA, { KEY_PROG2 } }, /* Lid flip action */
> { KE_KEY, 0xBD, { KEY_PROG2 } }, /* Lid flip action on ROG xflow laptops */
> { KE_END, 0},
> --
> 2.39.5
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [RFC PATCH] platform/x86: asus-nb-wmi: Ignore unknown event 0xCF
2024-11-25 9:39 ` Hans de Goede
@ 2024-11-29 19:30 ` Armin Wolf
0 siblings, 0 replies; 4+ messages in thread
From: Armin Wolf @ 2024-11-29 19:30 UTC (permalink / raw)
To: Hans de Goede, pespin, corentin.chary, luke
Cc: ilpo.jarvinen, platform-driver-x86, linux-kernel
Am 25.11.24 um 10:39 schrieb Hans de Goede:
> Hi,
>
> On 23-Nov-24 11:47 PM, Armin Wolf wrote:
>> On the Asus X541UAK an unknown event 0xCF is emited when the charger
>> is plugged in. This is caused by the following AML code:
>>
>> If (ACPS ())
>> {
>> ACPF = One
>> Local0 = 0x58
>> If (ATKP)
>> {
>> ^^^^ATKD.IANE (0xCF)
>> }
>> }
>> Else
>> {
>> ACPF = Zero
>> Local0 = 0x57
>> }
>>
>> Notify (AC0, 0x80) // Status Change
>> If (ATKP)
>> {
>> ^^^^ATKD.IANE (Local0)
>> }
>>
>> Sleep (0x64)
>> PNOT ()
>> Sleep (0x0A)
>> NBAT (0x80)
>>
>> Ignore the 0xCF event to silence the unknown event warning.
>>
>> Reported-by: Pau Espin Pedrol <pespin@espeweb.net>
>> Closes: https://lore.kernel.org/platform-driver-x86/54d4860b-ec9c-4992-acf6-db3f90388293@espeweb.net
>> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> Thanks, patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> Regards,
>
> Hans
Any updates on this?
Thanks,
Armin Wolf
>> ---
>> drivers/platform/x86/asus-nb-wmi.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
>> index ef04d396f61c..a5933980ade3 100644
>> --- a/drivers/platform/x86/asus-nb-wmi.c
>> +++ b/drivers/platform/x86/asus-nb-wmi.c
>> @@ -623,6 +623,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
>> { KE_KEY, 0xC4, { KEY_KBDILLUMUP } },
>> { KE_KEY, 0xC5, { KEY_KBDILLUMDOWN } },
>> { KE_IGNORE, 0xC6, }, /* Ambient Light Sensor notification */
>> + { KE_IGNORE, 0xCF, }, /* AC mode */
>> { KE_KEY, 0xFA, { KEY_PROG2 } }, /* Lid flip action */
>> { KE_KEY, 0xBD, { KEY_PROG2 } }, /* Lid flip action on ROG xflow laptops */
>> { KE_END, 0},
>> --
>> 2.39.5
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC PATCH] platform/x86: asus-nb-wmi: Ignore unknown event 0xCF
2024-11-23 22:47 [RFC PATCH] platform/x86: asus-nb-wmi: Ignore unknown event 0xCF Armin Wolf
2024-11-25 9:39 ` Hans de Goede
@ 2024-12-02 17:03 ` Ilpo Järvinen
1 sibling, 0 replies; 4+ messages in thread
From: Ilpo Järvinen @ 2024-12-02 17:03 UTC (permalink / raw)
To: pespin, corentin.chary, luke, Armin Wolf
Cc: hdegoede, platform-driver-x86, linux-kernel
On Sat, 23 Nov 2024 23:47:00 +0100, Armin Wolf wrote:
> On the Asus X541UAK an unknown event 0xCF is emited when the charger
> is plugged in. This is caused by the following AML code:
>
> If (ACPS ())
> {
> ACPF = One
> Local0 = 0x58
> If (ATKP)
> {
> ^^^^ATKD.IANE (0xCF)
> }
> }
> Else
> {
> ACPF = Zero
> Local0 = 0x57
> }
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/1] platform/x86: asus-nb-wmi: Ignore unknown event 0xCF
commit: e9fba20c29e27dc99e55e1c550573a114561bf8c
--
i.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-12-02 17:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-23 22:47 [RFC PATCH] platform/x86: asus-nb-wmi: Ignore unknown event 0xCF Armin Wolf
2024-11-25 9:39 ` Hans de Goede
2024-11-29 19:30 ` Armin Wolf
2024-12-02 17:03 ` Ilpo Järvinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®