* [PATCH] arm64: dts: exynos: gs101-oriole: add regulators for USB phy
@ 2024-06-17 16:52 André Draszik
2024-06-17 17:31 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: André Draszik @ 2024-06-17 16:52 UTC (permalink / raw)
To: Peter Griffin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Alim Akhtar
Cc: Tudor Ambarus, Will McVicker, Roy Luo, kernel-team,
linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
André Draszik
The USB phy requires various power supplies to work.
While we don't have a PMIC driver yet, they should still be added to
the DT. Do so.
Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
Note that this patch depends on the updated DT binding from
https://lore.kernel.org/r/20240617-usb-phy-gs101-v3-0-b66de9ae7424@linaro.org
---
arch/arm64/boot/dts/exynos/google/gs101-oriole.dts | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
index 5e8ffe065081..1a79d9ab3be0 100644
--- a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
+++ b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
@@ -145,6 +145,13 @@ &usbdrd31_dwc3 {
};
&usbdrd31_phy {
+ /* TODO: Update these once PMIC is implemented */
+ pll-supply = <0>;
+ dvdd-usb20-supply = <0>;
+ vddh-usb20-supply = <0>;
+ vdd33-usb20-supply = <0>;
+ vdda-usbdp-supply = <0>;
+ vddh-usbdp-supply = <0>;
status = "okay";
};
---
base-commit: 6906a84c482f098d31486df8dc98cead21cce2d0
change-id: 20240617-gs101-usb-regulators-in-dt-bdbbcea25fe9
Best regards,
--
André Draszik <andre.draszik@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: exynos: gs101-oriole: add regulators for USB phy
2024-06-17 16:52 [PATCH] arm64: dts: exynos: gs101-oriole: add regulators for USB phy André Draszik
@ 2024-06-17 17:31 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2024-06-17 17:31 UTC (permalink / raw)
To: André Draszik, Peter Griffin, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
Cc: Tudor Ambarus, Will McVicker, Roy Luo, kernel-team,
linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel
On 17/06/2024 18:52, André Draszik wrote:
> The USB phy requires various power supplies to work.
>
> While we don't have a PMIC driver yet, they should still be added to
> the DT. Do so.
>
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
> Note that this patch depends on the updated DT binding from
> https://lore.kernel.org/r/20240617-usb-phy-gs101-v3-0-b66de9ae7424@linaro.org
> ---
> arch/arm64/boot/dts/exynos/google/gs101-oriole.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> index 5e8ffe065081..1a79d9ab3be0 100644
> --- a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> +++ b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> @@ -145,6 +145,13 @@ &usbdrd31_dwc3 {
> };
>
> &usbdrd31_phy {
> + /* TODO: Update these once PMIC is implemented */
Rather provide fixed regulators with such remark that they substitute
missing PMIC.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-17 17:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-17 16:52 [PATCH] arm64: dts: exynos: gs101-oriole: add regulators for USB phy André Draszik
2024-06-17 17:31 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®