From: Florian Fainelli <f.fainelli@gmail.com>
To: Wen Yang <wen.yang99@zte.com.cn>, liviu.dudau@arm.com
Cc: sudeep.holla@arm.com, lorenzo.pieralisi@arm.com,
linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kgene@kernel.org, krzk@kernel.org,
linux-samsung-soc@vger.kernel.org, michal.simek@xilinx.com,
afaerber@suse.de, manivannan.sadhasivam@linaro.org,
dinguyen@kernel.org, heiko@sntech.de,
linux-rockchip@lists.infradead.org, rjui@broadcom.com,
sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com,
linus.walleij@linaro.org, avifishman70@gmail.com,
tmaimon77@gmail.com, venture@google.com, yuenn@google.com,
brendanhiggins@google.com, openbmc@lists.ozlabs.org,
xuwei5@hisilicon.com, maxime.ripard@bootlin.com, wens@csie.org,
catalin.marinas@arm.com, will.deacon@arm.com, horms@verge.net.au,
magnus.damm@gmail.com, linux-renesas-soc@vger.kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, fabio.estevam@nxp.com, linux-imx@nxp.com,
wang.yi59@zte.com.cn
Subject: Re: [PATCH 02/15] ARM: bcm: fix a leaked reference by addingmissing of_node_put
Date: Fri, 1 Mar 2019 10:28:59 -0800 [thread overview]
Message-ID: <d4e943ba-d817-2559-1872-81a5d6785c83@gmail.com> (raw)
In-Reply-To: <1551430616-42014-2-git-send-email-wen.yang99@zte.com.cn>
On 3/1/19 12:56 AM, Wen Yang wrote:
> The call to of_get_next_child returns a node pointer with refcount
> incremented thus it must be explicitly decremented after the last
> usage.
>
> Detected by coccinelle with the following warnings:
> ./arch/arm/mach-bcm/board_bcm281xx.c:43:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 35, but without a corresponding object release within this function.
This looks fine, if you resubmit, can you add a missing space between
"adding" and "missing"? This applies to all of your patches, so I am
assuming you somehow scripted that, which should be easy to fix.
With that changed:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2019-03-01 18:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 8:56 [PATCH 01/15] ARM: actions: " Wen Yang
2019-03-01 8:56 ` [PATCH 02/15] ARM: bcm: " Wen Yang
2019-03-01 18:28 ` Florian Fainelli [this message]
2019-03-01 8:56 ` [PATCH 03/15] ARM: exynos: " Wen Yang
2019-03-01 9:14 ` Krzysztof Kozlowski
2019-03-01 8:56 ` [PATCH 04/15] ARM: hisi: " Wen Yang
2019-03-01 8:56 ` [PATCH 05/15] ARM: imx51: " Wen Yang
2019-03-04 5:37 ` Shawn Guo
2019-03-01 8:56 ` [PATCH 06/15] arm: npcm: " Wen Yang
2019-03-04 15:39 ` Avi Fishman
2019-03-01 8:56 ` [PATCH 07/15] ARM: rockchip: " Wen Yang
2019-03-01 8:56 ` [PATCH 08/15] ARM: shmobile: " Wen Yang
2019-03-01 9:51 ` Geert Uytterhoeven
2019-03-04 10:24 ` Simon Horman
2019-03-01 8:56 ` [PATCH 09/15] ARM: socfpga: " Wen Yang
2019-03-01 8:56 ` [PATCH 10/15] ARM: sunxi: " Wen Yang
2019-03-01 8:56 ` [PATCH 11/15] ARM: versatile: " Wen Yang
2019-03-01 13:30 ` Linus Walleij
2019-03-01 8:56 ` [PATCH 12/15] ARM: vexpress: " Wen Yang
2019-03-04 14:46 ` Sudeep Holla
2019-03-01 8:56 ` [PATCH 13/15] ARM: zynq: " Wen Yang
2019-03-01 8:56 ` [PATCH 14/15] arm64: cpu_ops: " Wen Yang
2019-03-01 8:56 ` [PATCH 15/15] ARM: axxia: " Wen Yang
2019-03-01 15:55 ` [PATCH 01/15] ARM: actions: " Manivannan Sadhasivam
2019-03-04 12:29 ` Linus Walleij
2019-03-04 14:48 ` Manivannan Sadhasivam
2019-03-04 22:37 ` Linus Walleij
[not found] ` <CAOZjjhnDYHkWCd-zDqkFpg5FPoj-UxxNwVxfbg6QEahiASm10w@mail.gmail.com>
2019-03-05 9:55 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4e943ba-d817-2559-1872-81a5d6785c83@gmail.com \
--to=f.fainelli@gmail.com \
--cc=afaerber@suse.de \
--cc=avifishman70@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brendanhiggins@google.com \
--cc=catalin.marinas@arm.com \
--cc=dinguyen@kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=heiko@sntech.de \
--cc=horms@verge.net.au \
--cc=kernel@pengutronix.de \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=liviu.dudau@arm.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=magnus.damm@gmail.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=maxime.ripard@bootlin.com \
--cc=michal.simek@xilinx.com \
--cc=openbmc@lists.ozlabs.org \
--cc=rjui@broadcom.com \
--cc=s.hauer@pengutronix.de \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
--cc=wens@csie.org \
--cc=will.deacon@arm.com \
--cc=xuwei5@hisilicon.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome