From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Wen Yang" <wen.yang99@zte.com.cn>,
"Liviu Dudau" <liviu.dudau@arm.com>,
"Sudeep Holla" <sudeep.holla@arm.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Russell King" <linux@armlinux.org.uk>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Kukjin Kim" <kgene@kernel.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
linux-samsung-soc@vger.kernel.org,
"Michal Simek" <michal.simek@xilinx.com>,
"Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Dinh Nguyen" <dinguyen@kernel.org>,
"Heiko Stuebner" <heiko@sntech.de>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
"Linus Walleij" <linus.walleij@linaro.org>,
avifishman70@gmail.com, tmaimon77@gmail.com, venture@google.com,
yuenn@google.com, brendanhiggins@google.com,
openbmc@lists.ozlabs.org, "Wei Xu" <xuwei5@hisilicon.com>,
"Maxime Ripard" <maxime.ripard@bootlin.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will.deacon@arm.com>,
"Magnus Damm" <magnus.damm@gmail.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Sascha Hauer" <kernel@pengutronix.de>,
"Fabio Estevam" <fabio.estevam@nxp.com>,
linux-imx@nxp.com, wang.yi59@zte.com.cn
Subject: Re: [PATCH 08/15] ARM: shmobile: fix a leaked reference by addingmissing of_node_put
Date: Mon, 4 Mar 2019 11:24:24 +0100 [thread overview]
Message-ID: <20190304102423.bipib6frc6ma2ltv@verge.net.au> (raw)
In-Reply-To: <CAMuHMdWrY0UNhCA7a8oHVfdVNXaB=15qFuWqvuU9OZpf7-ecmg@mail.gmail.com>
On Fri, Mar 01, 2019 at 10:51:27AM +0100, Geert Uytterhoeven wrote:
> On Fri, Mar 1, 2019 at 9:57 AM Wen Yang <wen.yang99@zte.com.cn> wrote:
> > The call to of_get_next_child returns a node pointer with refcount
> > incremented thus it must be explicitly decremented after the last
> > usage.
> >
> > Detected by coccinelle with the following warnings:
> > ./arch/arm/mach-shmobile/pm-rcar-gen2.c:77:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function.
> > ./arch/arm/mach-shmobile/pm-rcar-gen2.c:85:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function.
> > ./arch/arm/mach-shmobile/pm-rcar-gen2.c:90:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function.
> >
> > Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thanks, applied for v5.2.
next prev parent reply other threads:[~2019-03-04 10:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 8:56 [PATCH 01/15] ARM: actions: " Wen Yang
2019-03-01 8:56 ` [PATCH 02/15] ARM: bcm: " Wen Yang
2019-03-01 18:28 ` Florian Fainelli
2019-03-01 8:56 ` [PATCH 03/15] ARM: exynos: " Wen Yang
2019-03-01 9:14 ` Krzysztof Kozlowski
2019-03-01 8:56 ` [PATCH 04/15] ARM: hisi: " Wen Yang
2019-03-01 8:56 ` [PATCH 05/15] ARM: imx51: " Wen Yang
2019-03-04 5:37 ` Shawn Guo
2019-03-01 8:56 ` [PATCH 06/15] arm: npcm: " Wen Yang
2019-03-04 15:39 ` Avi Fishman
2019-03-01 8:56 ` [PATCH 07/15] ARM: rockchip: " Wen Yang
2019-03-01 8:56 ` [PATCH 08/15] ARM: shmobile: " Wen Yang
2019-03-01 9:51 ` Geert Uytterhoeven
2019-03-04 10:24 ` Simon Horman [this message]
2019-03-01 8:56 ` [PATCH 09/15] ARM: socfpga: " Wen Yang
2019-03-01 8:56 ` [PATCH 10/15] ARM: sunxi: " Wen Yang
2019-03-01 8:56 ` [PATCH 11/15] ARM: versatile: " Wen Yang
2019-03-01 13:30 ` Linus Walleij
2019-03-01 8:56 ` [PATCH 12/15] ARM: vexpress: " Wen Yang
2019-03-04 14:46 ` Sudeep Holla
2019-03-01 8:56 ` [PATCH 13/15] ARM: zynq: " Wen Yang
2019-03-01 8:56 ` [PATCH 14/15] arm64: cpu_ops: " Wen Yang
2019-03-01 8:56 ` [PATCH 15/15] ARM: axxia: " Wen Yang
2019-03-01 15:55 ` [PATCH 01/15] ARM: actions: " Manivannan Sadhasivam
2019-03-04 12:29 ` Linus Walleij
2019-03-04 14:48 ` Manivannan Sadhasivam
2019-03-04 22:37 ` Linus Walleij
[not found] ` <CAOZjjhnDYHkWCd-zDqkFpg5FPoj-UxxNwVxfbg6QEahiASm10w@mail.gmail.com>
2019-03-05 9:55 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304102423.bipib6frc6ma2ltv@verge.net.au \
--to=horms@verge.net.au \
--cc=afaerber@suse.de \
--cc=avifishman70@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brendanhiggins@google.com \
--cc=catalin.marinas@arm.com \
--cc=dinguyen@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=geert@linux-m68k.org \
--cc=heiko@sntech.de \
--cc=kernel@pengutronix.de \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=liviu.dudau@arm.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=magnus.damm@gmail.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=maxime.ripard@bootlin.com \
--cc=michal.simek@xilinx.com \
--cc=openbmc@lists.ozlabs.org \
--cc=rjui@broadcom.com \
--cc=s.hauer@pengutronix.de \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
--cc=wens@csie.org \
--cc=will.deacon@arm.com \
--cc=xuwei5@hisilicon.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®