From: Jyothi Kumar Seerapu <jyothi.seerapu@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Mark Brown <broonie@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Frank Li <Frank.Li@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/6] dt-bindings: dma: qcom-gpi: Add QSPI protocol identifier
Date: Tue, 17 Nov 2026 20:08:54 +0530 [thread overview]
Message-ID: <d55bbf0a-3556-420f-852d-7a15ed8d5aac@oss.qualcomm.com> (raw)
In-Reply-To: <4c3bf92c-2434-46e8-8a3a-ab34cc50c72d@kernel.org>
On 11/16/2026 6:56 PM, Krzysztof Kozlowski wrote:
> On 16/11/2026 11:36, Jyothi Kumar Seerapu wrote:
>>
>>
>> On 11/12/2026 7:27 PM, Krzysztof Kozlowski wrote:
>>> On 12/11/2026 14:47, Jyothi Kumar Seerapu wrote:
>>>>
>>>>
>>>> On 11/11/2026 6:07 PM, Krzysztof Kozlowski wrote:
>>>>> On Mon, Nov 09, 2026 at 08:03:29PM +0530, Jyothi Kumar Seerapu wrote:
>>>>>>
>>>>>>
>>>>>> On 11/9/2026 7:12 PM, Krzysztof Kozlowski wrote:
>>>>>>> On Fri, Nov 06, 2026 at 08:31:20PM +0530, Jyothi Kumar Seerapu wrote:
>>>>>>>> Add QCOM_GPI_QSPI to identify QSPI (Quad SPI) channels in GPI DMA
>>>>>>>> specifiers. Its value, 9, matches the GENI serial engine firmware
>>>>>>>> protocol ID for QSPI.
>>>>>>>
>>>>>>> What is GENI serial engine firmware? How does the Linux rely on it that
>>>>>>> we add bindings for it?
>>>>>>
>>>>>> Hi Krzysztof,
>>>>>> GENI firmware runs on the serial engine’s programmable sequencers and
>>>>>> implements protocols such as SPI and QSPI. Linux configures the engine and
>>>>>> submits transfers to it.
>>>>>> The existing GPI DMA specifier includes a client protocol ID. Linux programs
>>>>>> this ID into the DMA channel and selects the corresponding descriptor
>>>>>> format. QCOM_GPI_QSPI adds the QSPI protocol encoding 9 to that interface.
>>>>>> I will clarify this in the commit description in V2.
>>>>>
>>>>> Does not really answer. I see no reason why GENI firmware needs ABI for
>>>>> Linux.
>>>>>
>>>> This extends the existing GPI DMA binding, not a GENI firmware ABI.
>>>
>>> OK, so it is not ABI for the firmware. Period. Let's stop discussing this.
>>>
>>>>
>>>> The third argument of the DMA specifier in the dmas property selects
>>>> the peripheral protocol. The GPI driver programs this value into the
>>>
>>> Yes, so the third argument can be value of 6 because it has no meaning
>>> for the firmware.
>>>
>>> Again, follow standard DT bindings ABI rules, you don't get an exception.
>>
>> The existing GPI DMA driver and binding uses its third cell to identify
>> the client protocol. The driver takes that value from DT and programs it
>> directly into the channel's SCRATCH_0 protocol field.
>
> So register value? Not a binding...
>
>> Its mandatory to maintain protocol ID-9 for QSPI.
>
> How can it be mandatory if we did not define in the bindings so far...
>
Hi Krzysztof,
Existing SPI, UART and I2C use the same number for the DT identifier
and hardware encoding. gpi_of_dma_xlate() stores the third DMA
argument in gchan->protocol, and gpi_alloc_chan() writes it directly
into SCRATCH_0 without translation.
Neither 6 nor 9 has been defined in the upstream binding yet.
Would it be acceptable to follow the existing SPI, UART and I2C
approach and use 9 for both the DT identifier and hardware encoding?
Or should I use 6 for QCOM_GPI_QSPI and explicitly translate it to
hardware protocol ID 9 when programming SCRATCH_0?
Regards,
JyothiKumar
>>
>> Other protocol IDs which are not part of upstream are for AFC (6), SPMI
>> (7), HID_QSPI (8).
>
>
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2026-11-17 14:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 15:01 [PATCH 0/6] spi: qcom-geni: Add QSPI support over GPI DMA Jyothi Kumar Seerapu
2026-11-06 15:01 ` [PATCH 1/6] spi: spi-geni-qcom: Add transfer_one_message() support Jyothi Kumar Seerapu
2026-11-06 15:01 ` [PATCH 2/6] dt-bindings: dma: qcom-gpi: Add QSPI protocol identifier Jyothi Kumar Seerapu
2026-11-09 13:42 ` Krzysztof Kozlowski
2026-11-09 14:33 ` Jyothi Kumar Seerapu
2026-11-11 12:37 ` Krzysztof Kozlowski
2026-11-12 13:47 ` Jyothi Kumar Seerapu
2026-11-12 13:57 ` Krzysztof Kozlowski
2026-11-13 10:14 ` Konrad Dybcio
2026-11-16 10:36 ` Jyothi Kumar Seerapu
2026-11-16 10:36 ` Jyothi Kumar Seerapu
2026-11-16 13:26 ` Krzysztof Kozlowski
2026-11-17 14:38 ` Jyothi Kumar Seerapu [this message]
2026-11-17 15:04 ` Krzysztof Kozlowski
2026-11-06 15:01 ` [PATCH 3/6] dt-bindings: spi: qcom,spi-geni-qcom: Document QSPI support Jyothi Kumar Seerapu
2026-11-09 13:46 ` Krzysztof Kozlowski
2026-11-06 15:01 ` [PATCH 4/6] soc: qcom: geni-se: Define the QSPI firmware protocol Jyothi Kumar Seerapu
2026-11-09 13:44 ` Krzysztof Kozlowski
2026-11-09 14:43 ` Jyothi Kumar Seerapu
2026-11-11 12:40 ` Krzysztof Kozlowski
2026-11-12 13:48 ` Jyothi Kumar Seerapu
2026-11-12 13:56 ` Krzysztof Kozlowski
2026-11-09 14:47 ` Konrad Dybcio
2026-11-09 16:45 ` Jyothi Kumar Seerapu
2026-11-06 15:01 ` [PATCH 5/6] dmaengine: qcom: gpi: Add QSPI protocol support Jyothi Kumar Seerapu
2026-11-06 15:01 ` [PATCH 6/6] spi: spi-geni-qcom: Add QSPI support over GPI DMA Jyothi Kumar Seerapu
2026-11-08 15:18 ` [PATCH 0/6] spi: qcom-geni: " Mark Brown
2026-11-09 7:10 ` Jyothi Kumar Seerapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d55bbf0a-3556-420f-852d-7a15ed8d5aac@oss.qualcomm.com \
--to=jyothi.seerapu@oss.qualcomm.com \
--cc=Frank.Li@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®