* [PATCH] kdb: delete unexecuted if-block in kdb_get_kbd_char()
@ 2025-10-03 15:12 Matvey Kovalev
2025-10-03 16:39 ` Doug Anderson
0 siblings, 1 reply; 3+ messages in thread
From: Matvey Kovalev @ 2025-10-03 15:12 UTC (permalink / raw)
To: Jason Wessel
Cc: Matvey Kovalev, Daniel Thompson, Douglas Anderson,
kgdb-bugreport, linux-kernel, lvc-project
Bits of scancode are dropped except 7 low-order ones.
So, scancode can't be equal 0xe0.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Matvey Kovalev <matvey.kovalev@ispras.ru>
---
kernel/debug/kdb/kdb_keyboard.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/kernel/debug/kdb/kdb_keyboard.c b/kernel/debug/kdb/kdb_keyboard.c
index 3a74604fdb8a7..386d30e530b78 100644
--- a/kernel/debug/kdb/kdb_keyboard.c
+++ b/kernel/debug/kdb/kdb_keyboard.c
@@ -145,9 +145,6 @@ int kdb_get_kbd_char(void)
return CTRL('F');
}
- if (scancode == 0xe0)
- return -1;
-
/*
* For Japanese 86/106 keyboards
* See comment in drivers/char/pc_keyb.c.
--
2.43.0.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] kdb: delete unexecuted if-block in kdb_get_kbd_char()
2025-10-03 15:12 [PATCH] kdb: delete unexecuted if-block in kdb_get_kbd_char() Matvey Kovalev
@ 2025-10-03 16:39 ` Doug Anderson
2025-10-06 5:27 ` matvey.kovalev
0 siblings, 1 reply; 3+ messages in thread
From: Doug Anderson @ 2025-10-03 16:39 UTC (permalink / raw)
To: Matvey Kovalev
Cc: Jason Wessel, Daniel Thompson, kgdb-bugreport, linux-kernel, lvc-project
Hi,
On Fri, Oct 3, 2025 at 8:13 AM Matvey Kovalev <matvey.kovalev@ispras.ru> wrote:
>
> Bits of scancode are dropped except 7 low-order ones.
> So, scancode can't be equal 0xe0.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Matvey Kovalev <matvey.kovalev@ispras.ru>
> ---
> kernel/debug/kdb/kdb_keyboard.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/kernel/debug/kdb/kdb_keyboard.c b/kernel/debug/kdb/kdb_keyboard.c
> index 3a74604fdb8a7..386d30e530b78 100644
> --- a/kernel/debug/kdb/kdb_keyboard.c
> +++ b/kernel/debug/kdb/kdb_keyboard.c
> @@ -145,9 +145,6 @@ int kdb_get_kbd_char(void)
> return CTRL('F');
> }
>
> - if (scancode == 0xe0)
> - return -1;
> -
The same patch has already been sent and was landed:
https://lore.kernel.org/all/20250507104337.201695-1-colin.i.king@gmail.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-06 5:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-03 15:12 [PATCH] kdb: delete unexecuted if-block in kdb_get_kbd_char() Matvey Kovalev
2025-10-03 16:39 ` Doug Anderson
2025-10-06 5:27 ` matvey.kovalev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®