* [PATCH] drm/amd/pm: Fix error code in vega10_hwmgr_backend_init()
@ 2024-05-04 11:26 Dan Carpenter
2024-05-04 17:13 ` Markus Elfring
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2024-05-04 11:26 UTC (permalink / raw)
To: Evan Quan
Cc: Alex Deucher, Christian König, Pan, Xinhui, David Airlie,
Daniel Vetter, Tim Huang, Lijo Lazar, Jesse Zhang, Ma Jun,
Ruan Jinjie, amd-gfx, dri-devel, linux-kernel, kernel-janitors
Return -EINVAL on error instead of success. Also on the success path,
return a literal zero instead of "return result;"
Fixes: e098bc9612c2 ("drm/amd/pm: optimize the power related source code layout")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c
index 37c915d7723c..9b9f8615070a 100644
--- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c
+++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c
@@ -924,7 +924,7 @@ static int vega10_hwmgr_backend_init(struct pp_hwmgr *hwmgr)
data->total_active_cus = adev->gfx.cu_info.number;
if (!hwmgr->not_vf)
- return result;
+ return -EINVAL;
/* Setup default Overdrive Fan control settings */
data->odn_fan_table.target_fan_speed =
@@ -947,7 +947,7 @@ static int vega10_hwmgr_backend_init(struct pp_hwmgr *hwmgr)
"Mem Channel Index Exceeded maximum!",
return -EINVAL);
- return result;
+ return 0;
}
static int vega10_init_sclk_threshold(struct pp_hwmgr *hwmgr)
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drm/amd/pm: Fix error code in vega10_hwmgr_backend_init()
2024-05-04 11:26 [PATCH] drm/amd/pm: Fix error code in vega10_hwmgr_backend_init() Dan Carpenter
@ 2024-05-04 17:13 ` Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2024-05-04 17:13 UTC (permalink / raw)
To: Dan Carpenter, amd-gfx, dri-devel, kernel-janitors, Alex Deucher,
Christian König, Daniel Vetter, David Airlie, Evan Quan,
Jesse Zhang, Lijo Lazar, Ma Jun, Tim Huang, Xinhui Pan
Cc: LKML, Ruan Jinjie
> Return -EINVAL on error instead of success. Also on the success path,
> return a literal zero instead of "return result;"
How do you think about to omit the initialisation for the variable “result”
in another update step?
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-04 17:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-04 11:26 [PATCH] drm/amd/pm: Fix error code in vega10_hwmgr_backend_init() Dan Carpenter
2024-05-04 17:13 ` Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®