* [PATCH 1/1] dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml
@ 2026-08-26 21:14 Frank.Li
2026-08-30 9:53 ` Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Frank.Li @ 2026-08-26 21:14 UTC (permalink / raw)
To: Guenter Roeck, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Frank Li, Wensheng Wang, Cosmo Chou, Colin Huang, Nuno Sá,
Dixit Parmar, Antoni Pokusinski, Eddie James, Thorsten Blum,
open list:HARDWARE MONITORING,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
From: Frank Li <Frank.Li@nxp.com>
Move ti,tmp103 binding from trivial-devices.yaml to ti,tmp102.yaml. Both
devices are single temperature sensors and update "#thermal-sensor-cells"
property to accept values 0 and 1 (passing no argument is equivalent to
passing 0 as the first argument)
Fix below CHECK_DTBS warnings:
arch/arm/boot/dts/nxp/imx/imx6dl-plym2m.dtb: temperature-sensor@70 (ti,tmp103): '#thermal-sensor-cells' does not match any of the regexes: '^pinctrl-[0-9]+$'
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml | 5 +++--
Documentation/devicetree/bindings/trivial-devices.yaml | 2 --
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
index 96b2e4969f78a..cd96b1d8a2d5e 100644
--- a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
+++ b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
@@ -4,7 +4,7 @@
$id: http://devicetree.org/schemas/hwmon/ti,tmp102.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
-title: TMP102 temperature sensor
+title: TMP102/TMP103 temperature sensor
maintainers:
- Krzysztof Kozlowski <krzk@kernel.org>
@@ -13,6 +13,7 @@ properties:
compatible:
enum:
- ti,tmp102
+ - ti,tmp103
interrupts:
maxItems: 1
@@ -25,7 +26,7 @@ properties:
A descriptive name for this channel, like "ambient" or "psu".
"#thermal-sensor-cells":
- const: 1
+ enum: [0, 1]
vcc-supply:
description: Power supply for tmp102
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 05f88cf81d6c6..3cdf9e0d8322d 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -506,8 +506,6 @@ properties:
- ti,lm74
# Temperature sensor with integrated fan control
- ti,lm96000
- # Low Power Digital Temperature Sensor with SMBUS/Two Wire Serial Interface
- - ti,tmp103
# Thermometer with SPI interface
- ti,tmp121
- ti,tmp122
--
2.43.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml
2026-08-26 21:14 [PATCH 1/1] dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml Frank.Li
@ 2026-08-30 9:53 ` Krzysztof Kozlowski
2026-08-30 15:38 ` Guenter Roeck
2026-08-30 20:53 ` Krzysztof Kozlowski
2026-08-31 18:03 ` Guenter Roeck
2 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-08-30 9:53 UTC (permalink / raw)
To: Frank.Li
Cc: Guenter Roeck, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Frank Li, Wensheng Wang, Cosmo Chou, Colin Huang, Nuno Sá,
Dixit Parmar, Antoni Pokusinski, Eddie James, Thorsten Blum,
open list:HARDWARE MONITORING,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
On Wed, Aug 26, 2026 at 05:14:19PM -0400, Frank.Li@oss.nxp.com wrote:
> From: Frank Li <Frank.Li@nxp.com>
>
> Move ti,tmp103 binding from trivial-devices.yaml to ti,tmp102.yaml. Both
> devices are single temperature sensors and update "#thermal-sensor-cells"
> property to accept values 0 and 1 (passing no argument is equivalent to
> passing 0 as the first argument)
Why updating the property? If there are single sensors, then what is the
cell for?
>
> Fix below CHECK_DTBS warnings:
> arch/arm/boot/dts/nxp/imx/imx6dl-plym2m.dtb: temperature-sensor@70 (ti,tmp103): '#thermal-sensor-cells' does not match any of the regexes: '^pinctrl-[0-9]+$'
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml | 5 +++--
> Documentation/devicetree/bindings/trivial-devices.yaml | 2 --
> 2 files changed, 3 insertions(+), 4 deletions(-)
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml
2026-08-30 9:53 ` Krzysztof Kozlowski
@ 2026-08-30 15:38 ` Guenter Roeck
0 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2026-08-30 15:38 UTC (permalink / raw)
To: Krzysztof Kozlowski, Frank.Li
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li,
Wensheng Wang, Cosmo Chou, Colin Huang, Nuno Sá,
Dixit Parmar, Antoni Pokusinski, Eddie James, Thorsten Blum,
open list:HARDWARE MONITORING,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
On 8/30/26 02:53, Krzysztof Kozlowski wrote:
> On Wed, Aug 26, 2026 at 05:14:19PM -0400, Frank.Li@oss.nxp.com wrote:
>> From: Frank Li <Frank.Li@nxp.com>
>>
>> Move ti,tmp103 binding from trivial-devices.yaml to ti,tmp102.yaml. Both
>> devices are single temperature sensors and update "#thermal-sensor-cells"
>> property to accept values 0 and 1 (passing no argument is equivalent to
>> passing 0 as the first argument)
>
> Why updating the property? If there are single sensors, then what is the
> cell for?
>
It registers as temperature sensor with the thermal subsystem. The documentation
of #thermal-sensor-cells states that the property is mandatory and "... Will be
0 on sensor nodes with only a single sensor". I don't claim to understand how
this is supposed to work, but the thermal subsystem code looking for it does
seem to suggest that the property is mandatory, even if there is only a single
sensor.
Thanks,
Guenter
>>
>> Fix below CHECK_DTBS warnings:
>> arch/arm/boot/dts/nxp/imx/imx6dl-plym2m.dtb: temperature-sensor@70 (ti,tmp103): '#thermal-sensor-cells' does not match any of the regexes: '^pinctrl-[0-9]+$'
>>
>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
>> ---
>> Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml | 5 +++--
>> Documentation/devicetree/bindings/trivial-devices.yaml | 2 --
>> 2 files changed, 3 insertions(+), 4 deletions(-)
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml
2026-08-26 21:14 [PATCH 1/1] dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml Frank.Li
2026-08-30 9:53 ` Krzysztof Kozlowski
@ 2026-08-30 20:53 ` Krzysztof Kozlowski
2026-08-31 18:03 ` Guenter Roeck
2 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-08-30 20:53 UTC (permalink / raw)
To: Frank.Li, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Frank Li, Wensheng Wang, Cosmo Chou, Colin Huang,
Nuno Sá,
Dixit Parmar, Antoni Pokusinski, Eddie James, Thorsten Blum,
open list:HARDWARE MONITORING,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
On 26/08/2026 23:14, Frank.Li@oss.nxp.com wrote:
> From: Frank Li <Frank.Li@nxp.com>
>
> Move ti,tmp103 binding from trivial-devices.yaml to ti,tmp102.yaml. Both
> devices are single temperature sensors and update "#thermal-sensor-cells"
> property to accept values 0 and 1 (passing no argument is equivalent to
> passing 0 as the first argument)
>
> Fix below CHECK_DTBS warnings:
> arch/arm/boot/dts/nxp/imx/imx6dl-plym2m.dtb: temperature-sensor@70 (ti,tmp103): '#thermal-sensor-cells' does not match any of the regexes: '^pinctrl-[0-9]+$'
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml | 5 +++--
> Documentation/devicetree/bindings/trivial-devices.yaml | 2 --
> 2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> index 96b2e4969f78a..cd96b1d8a2d5e 100644
> --- a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> @@ -4,7 +4,7 @@
> $id: http://devicetree.org/schemas/hwmon/ti,tmp102.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> -title: TMP102 temperature sensor
> +title: TMP102/TMP103 temperature sensor
>
> maintainers:
> - Krzysztof Kozlowski <krzk@kernel.org>
> @@ -13,6 +13,7 @@ properties:
> compatible:
> enum:
> - ti,tmp102
> + - ti,tmp103
>
> interrupts:
> maxItems: 1
> @@ -25,7 +26,7 @@ properties:
> A descriptive name for this channel, like "ambient" or "psu".
>
> "#thermal-sensor-cells":
> - const: 1
> + enum: [0, 1]
I missed that old value was '1' which was not really correct. Looks good.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml
2026-08-26 21:14 [PATCH 1/1] dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml Frank.Li
2026-08-30 9:53 ` Krzysztof Kozlowski
2026-08-30 20:53 ` Krzysztof Kozlowski
@ 2026-08-31 18:03 ` Guenter Roeck
2 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2026-08-31 18:03 UTC (permalink / raw)
To: Frank.Li
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li,
Wensheng Wang, Cosmo Chou, Colin Huang, Nuno Sá,
Dixit Parmar, Antoni Pokusinski, Eddie James, Thorsten Blum,
open list:HARDWARE MONITORING,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
On Wed, Aug 26, 2026 at 05:14:19PM -0400, Frank.Li@oss.nxp.com wrote:
> From: Frank Li <Frank.Li@nxp.com>
>
> Move ti,tmp103 binding from trivial-devices.yaml to ti,tmp102.yaml. Both
> devices are single temperature sensors and update "#thermal-sensor-cells"
> property to accept values 0 and 1 (passing no argument is equivalent to
> passing 0 as the first argument)
>
> Fix below CHECK_DTBS warnings:
> arch/arm/boot/dts/nxp/imx/imx6dl-plym2m.dtb: temperature-sensor@70 (ti,tmp103): '#thermal-sensor-cells' does not match any of the regexes: '^pinctrl-[0-9]+$'
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-08-31 18:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-26 21:14 [PATCH 1/1] dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml Frank.Li
2026-08-30 9:53 ` Krzysztof Kozlowski
2026-08-30 15:38 ` Guenter Roeck
2026-08-30 20:53 ` Krzysztof Kozlowski
2026-08-31 18:03 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®