From: Paul Moore <paul@paul-moore.com>
To: Canfeng Guo <guocanfeng@uniontech.com>
Cc: stephen.smalley.work@gmail.com, omosnace@redhat.com,
selinux@vger.kernel.org, linux-kernel@vger.kernel.org,
Canfeng Guo <guocanfeng@uniontech.com>
Subject: Re: [PATCH] selinux: Use 1UL for EBITMAP_BIT to match maps type
Date: Tue, 02 Jul 2024 11:41:04 -0400 [thread overview]
Message-ID: <d5b7485edf9a4cdbc85b6b191b00e572@paul-moore.com> (raw)
In-Reply-To: <20240629041012.156495-1-guocanfeng@uniontech.com>
On Jun 29, 2024 Canfeng Guo <guocanfeng@uniontech.com> wrote:
>
> This patch modifies the definition of EBITMAP_BIT in
> security/selinux/ss/ebitmap.h from 1ULL to 1UL to match the type
> of elements in the ebitmap_node maps array.
>
> This change does not affect the functionality or correctness of
> the code but aims to enhance code quality by adhering to good
> programming practices and avoiding unnecessary type conversions.
>
> Signed-off-by: Canfeng Guo <guocanfeng@uniontech.com>
> ---
> security/selinux/ss/ebitmap.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, this looks good to me, and it's trivial enough that I think it
is safe to merge at this point in the release cycle; merged to
selinux/dev.
--
paul-moore.com
prev parent reply other threads:[~2024-07-02 15:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-29 4:10 Canfeng Guo
2024-07-02 15:41 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5b7485edf9a4cdbc85b6b191b00e572@paul-moore.com \
--to=paul@paul-moore.com \
--cc=guocanfeng@uniontech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=omosnace@redhat.com \
--cc=selinux@vger.kernel.org \
--cc=stephen.smalley.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®