[PATCH] selinux: Use 1UL for EBITMAP_BIT to match maps type

[PATCH] selinux: Use 1UL for EBITMAP_BIT to match maps type

[Canfeng Guo]

This patch modifies the definition of EBITMAP_BIT in
security/selinux/ss/ebitmap.h from 1ULL to 1UL to match the type
of elements in the ebitmap_node maps array.

This change does not affect the functionality or correctness of
the code but aims to enhance code quality by adhering to good
programming practices and avoiding unnecessary type conversions.

Signed-off-by: Canfeng Guo <guocanfeng@uniontech.com>
---
 security/selinux/ss/ebitmap.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/selinux/ss/ebitmap.h b/security/selinux/ss/ebitmap.h
index 24d7d8b3cda3..ba2ac3da1153 100644
--- a/security/selinux/ss/ebitmap.h
+++ b/security/selinux/ss/ebitmap.h
@@ -29,7 +29,7 @@
 	 sizeof(unsigned long))
 #define EBITMAP_UNIT_SIZE BITS_PER_LONG
 #define EBITMAP_SIZE	  (EBITMAP_UNIT_NUMS * EBITMAP_UNIT_SIZE)
-#define EBITMAP_BIT	  1ULL
+#define EBITMAP_BIT	  1UL
 #define EBITMAP_SHIFT_UNIT_SIZE(x) \
 	(((x) >> EBITMAP_UNIT_SIZE / 2) >> EBITMAP_UNIT_SIZE / 2)
 
-- 
2.20.1

Re: [PATCH] selinux: Use 1UL for EBITMAP_BIT to match maps type

[Paul Moore]

On Jun 29, 2024 Canfeng Guo <guocanfeng@uniontech.com> wrote:
> 
> This patch modifies the definition of EBITMAP_BIT in
> security/selinux/ss/ebitmap.h from 1ULL to 1UL to match the type
> of elements in the ebitmap_node maps array.
> 
> This change does not affect the functionality or correctness of
> the code but aims to enhance code quality by adhering to good
> programming practices and avoiding unnecessary type conversions.
> 
> Signed-off-by: Canfeng Guo <guocanfeng@uniontech.com>
> ---
>  security/selinux/ss/ebitmap.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, this looks good to me, and it's trivial enough that I think it
is safe to merge at this point in the release cycle; merged to
selinux/dev.

--
paul-moore.com