* [PATCH v2 RESEND] drm/udl: Increase GET_URB_TIMEOUT
@ 2025-11-06 10:35 oushixiong1025
2025-11-06 11:21 ` Thomas Zimmermann
0 siblings, 1 reply; 4+ messages in thread
From: oushixiong1025 @ 2025-11-06 10:35 UTC (permalink / raw)
To: Dave Airlie
Cc: Sean Paul, Thomas Zimmermann, Maarten Lankhorst, Maxime Ripard,
David Airlie, Simona Vetter, dri-devel, linux-kernel,
Shixiong Ou
From: Shixiong Ou <oushixiong@kylinos.cn>
[WHY]
A situation has occurred where udl_handle_damage() executed successfully
and the kernel log appears normal, but the display fails to show any output.
This is because the call to udl_get_urb() in udl_crtc_helper_atomic_enable()
failed without generating any error message.
[HOW]
1. Increase GET_URB_TIMEOUT.
2. Add error messages when calling udl_get_urb() failed in
udl_crtc_helper_atomic_enable().
Signed-off-by: Shixiong Ou <oushixiong@kylinos.cn>
---
drivers/gpu/drm/udl/udl_main.c | 2 +-
drivers/gpu/drm/udl/udl_modeset.c | 5 ++++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c
index bc58991a6f14..dd9576fd4ff0 100644
--- a/drivers/gpu/drm/udl/udl_main.c
+++ b/drivers/gpu/drm/udl/udl_main.c
@@ -285,7 +285,7 @@ static struct urb *udl_get_urb_locked(struct udl_device *udl, long timeout)
return unode->urb;
}
-#define GET_URB_TIMEOUT HZ
+#define GET_URB_TIMEOUT (HZ * 2)
struct urb *udl_get_urb(struct udl_device *udl)
{
struct urb *urb;
diff --git a/drivers/gpu/drm/udl/udl_modeset.c b/drivers/gpu/drm/udl/udl_modeset.c
index 231e829bd709..2df5bd291b0a 100644
--- a/drivers/gpu/drm/udl/udl_modeset.c
+++ b/drivers/gpu/drm/udl/udl_modeset.c
@@ -21,6 +21,7 @@
#include <drm/drm_gem_framebuffer_helper.h>
#include <drm/drm_gem_shmem_helper.h>
#include <drm/drm_modeset_helper_vtables.h>
+#include <drm/drm_print.h>
#include <drm/drm_probe_helper.h>
#include <drm/drm_vblank.h>
@@ -342,8 +343,10 @@ static void udl_crtc_helper_atomic_enable(struct drm_crtc *crtc, struct drm_atom
return;
urb = udl_get_urb(udl);
- if (!urb)
+ if (!urb) {
+ drm_err_ratelimited(dev, "Get urb failed when enabling crtc\n");
goto out;
+ }
buf = (char *)urb->transfer_buffer;
buf = udl_vidreg_lock(buf);
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 RESEND] drm/udl: Increase GET_URB_TIMEOUT
2025-11-06 10:35 [PATCH v2 RESEND] drm/udl: Increase GET_URB_TIMEOUT oushixiong1025
@ 2025-11-06 11:21 ` Thomas Zimmermann
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Zimmermann @ 2025-11-06 11:21 UTC (permalink / raw)
To: oushixiong1025, Dave Airlie
Cc: Sean Paul, Maarten Lankhorst, Maxime Ripard, David Airlie,
Simona Vetter, dri-devel, linux-kernel, Shixiong Ou
Am 06.11.25 um 11:35 schrieb oushixiong1025@163.com:
> From: Shixiong Ou <oushixiong@kylinos.cn>
>
> [WHY]
> A situation has occurred where udl_handle_damage() executed successfully
> and the kernel log appears normal, but the display fails to show any output.
> This is because the call to udl_get_urb() in udl_crtc_helper_atomic_enable()
> failed without generating any error message.
>
> [HOW]
> 1. Increase GET_URB_TIMEOUT.
> 2. Add error messages when calling udl_get_urb() failed in
> udl_crtc_helper_atomic_enable().
>
> Signed-off-by: Shixiong Ou <oushixiong@kylinos.cn>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/udl/udl_main.c | 2 +-
> drivers/gpu/drm/udl/udl_modeset.c | 5 ++++-
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c
> index bc58991a6f14..dd9576fd4ff0 100644
> --- a/drivers/gpu/drm/udl/udl_main.c
> +++ b/drivers/gpu/drm/udl/udl_main.c
> @@ -285,7 +285,7 @@ static struct urb *udl_get_urb_locked(struct udl_device *udl, long timeout)
> return unode->urb;
> }
>
> -#define GET_URB_TIMEOUT HZ
> +#define GET_URB_TIMEOUT (HZ * 2)
> struct urb *udl_get_urb(struct udl_device *udl)
> {
> struct urb *urb;
> diff --git a/drivers/gpu/drm/udl/udl_modeset.c b/drivers/gpu/drm/udl/udl_modeset.c
> index 231e829bd709..2df5bd291b0a 100644
> --- a/drivers/gpu/drm/udl/udl_modeset.c
> +++ b/drivers/gpu/drm/udl/udl_modeset.c
> @@ -21,6 +21,7 @@
> #include <drm/drm_gem_framebuffer_helper.h>
> #include <drm/drm_gem_shmem_helper.h>
> #include <drm/drm_modeset_helper_vtables.h>
> +#include <drm/drm_print.h>
> #include <drm/drm_probe_helper.h>
> #include <drm/drm_vblank.h>
>
> @@ -342,8 +343,10 @@ static void udl_crtc_helper_atomic_enable(struct drm_crtc *crtc, struct drm_atom
> return;
>
> urb = udl_get_urb(udl);
> - if (!urb)
> + if (!urb) {
> + drm_err_ratelimited(dev, "Get urb failed when enabling crtc\n");
> goto out;
> + }
>
> buf = (char *)urb->transfer_buffer;
> buf = udl_vidreg_lock(buf);
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 RESEND] drm/udl: Increase GET_URB_TIMEOUT
2026-04-24 8:56 oushixiong1025
@ 2026-04-24 9:06 ` Thomas Zimmermann
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Zimmermann @ 2026-04-24 9:06 UTC (permalink / raw)
To: oushixiong1025, Dave Airlie
Cc: Sean Paul, Maarten Lankhorst, Maxime Ripard, David Airlie,
Simona Vetter, dri-devel, linux-kernel, Shixiong Ou
Hi,
apologies, I think I missed the first submission of this patch.
Am 24.04.26 um 10:56 schrieb oushixiong1025@163.com:
> From: Shixiong Ou <oushixiong@kylinos.cn>
>
> [WHY]
> A situation has occurred where udl_handle_damage() executed successfully
> and the kernel log appears normal, but the display fails to show any output.
> This is because the call to udl_get_urb() in udl_crtc_helper_atomic_enable()
> failed without generating any error message.
>
> [HOW]
> 1. Increase GET_URB_TIMEOUT.
> 2. Add error messages when calling udl_get_urb() failed in
> udl_crtc_helper_atomic_enable().
>
> Signed-off-by: Shixiong Ou <oushixiong@kylinos.cn>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/udl/udl_main.c | 2 +-
> drivers/gpu/drm/udl/udl_modeset.c | 5 ++++-
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c
> index bc58991a6f14..dd9576fd4ff0 100644
> --- a/drivers/gpu/drm/udl/udl_main.c
> +++ b/drivers/gpu/drm/udl/udl_main.c
> @@ -285,7 +285,7 @@ static struct urb *udl_get_urb_locked(struct udl_device *udl, long timeout)
> return unode->urb;
> }
>
> -#define GET_URB_TIMEOUT HZ
> +#define GET_URB_TIMEOUT (HZ * 2)
Could you please remove the define and directly pass 2 * HZ to
udl_get_urb_locked() instead.
I always wanted to remove the URB caching locking and allocate them when
needed. So that timeout is likely going away at some point.
Best regards
Thomas
> struct urb *udl_get_urb(struct udl_device *udl)
> {
> struct urb *urb;
> diff --git a/drivers/gpu/drm/udl/udl_modeset.c b/drivers/gpu/drm/udl/udl_modeset.c
> index 231e829bd709..2df5bd291b0a 100644
> --- a/drivers/gpu/drm/udl/udl_modeset.c
> +++ b/drivers/gpu/drm/udl/udl_modeset.c
> @@ -21,6 +21,7 @@
> #include <drm/drm_gem_framebuffer_helper.h>
> #include <drm/drm_gem_shmem_helper.h>
> #include <drm/drm_modeset_helper_vtables.h>
> +#include <drm/drm_print.h>
> #include <drm/drm_probe_helper.h>
> #include <drm/drm_vblank.h>
>
> @@ -342,8 +343,10 @@ static void udl_crtc_helper_atomic_enable(struct drm_crtc *crtc, struct drm_atom
> return;
>
> urb = udl_get_urb(udl);
> - if (!urb)
> + if (!urb) {
> + drm_err_ratelimited(dev, "Get urb failed when enabling crtc\n");
> goto out;
> + }
>
> buf = (char *)urb->transfer_buffer;
> buf = udl_vidreg_lock(buf);
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 RESEND] drm/udl: Increase GET_URB_TIMEOUT
@ 2026-04-24 8:56 oushixiong1025
2026-04-24 9:06 ` Thomas Zimmermann
0 siblings, 1 reply; 4+ messages in thread
From: oushixiong1025 @ 2026-04-24 8:56 UTC (permalink / raw)
To: Dave Airlie
Cc: Sean Paul, Thomas Zimmermann, Maarten Lankhorst, Maxime Ripard,
David Airlie, Simona Vetter, dri-devel, linux-kernel,
Shixiong Ou
From: Shixiong Ou <oushixiong@kylinos.cn>
[WHY]
A situation has occurred where udl_handle_damage() executed successfully
and the kernel log appears normal, but the display fails to show any output.
This is because the call to udl_get_urb() in udl_crtc_helper_atomic_enable()
failed without generating any error message.
[HOW]
1. Increase GET_URB_TIMEOUT.
2. Add error messages when calling udl_get_urb() failed in
udl_crtc_helper_atomic_enable().
Signed-off-by: Shixiong Ou <oushixiong@kylinos.cn>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/udl/udl_main.c | 2 +-
drivers/gpu/drm/udl/udl_modeset.c | 5 ++++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c
index bc58991a6f14..dd9576fd4ff0 100644
--- a/drivers/gpu/drm/udl/udl_main.c
+++ b/drivers/gpu/drm/udl/udl_main.c
@@ -285,7 +285,7 @@ static struct urb *udl_get_urb_locked(struct udl_device *udl, long timeout)
return unode->urb;
}
-#define GET_URB_TIMEOUT HZ
+#define GET_URB_TIMEOUT (HZ * 2)
struct urb *udl_get_urb(struct udl_device *udl)
{
struct urb *urb;
diff --git a/drivers/gpu/drm/udl/udl_modeset.c b/drivers/gpu/drm/udl/udl_modeset.c
index 231e829bd709..2df5bd291b0a 100644
--- a/drivers/gpu/drm/udl/udl_modeset.c
+++ b/drivers/gpu/drm/udl/udl_modeset.c
@@ -21,6 +21,7 @@
#include <drm/drm_gem_framebuffer_helper.h>
#include <drm/drm_gem_shmem_helper.h>
#include <drm/drm_modeset_helper_vtables.h>
+#include <drm/drm_print.h>
#include <drm/drm_probe_helper.h>
#include <drm/drm_vblank.h>
@@ -342,8 +343,10 @@ static void udl_crtc_helper_atomic_enable(struct drm_crtc *crtc, struct drm_atom
return;
urb = udl_get_urb(udl);
- if (!urb)
+ if (!urb) {
+ drm_err_ratelimited(dev, "Get urb failed when enabling crtc\n");
goto out;
+ }
buf = (char *)urb->transfer_buffer;
buf = udl_vidreg_lock(buf);
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-04-24 9:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-06 10:35 [PATCH v2 RESEND] drm/udl: Increase GET_URB_TIMEOUT oushixiong1025
2025-11-06 11:21 ` Thomas Zimmermann
2026-04-24 8:56 oushixiong1025
2026-04-24 9:06 ` Thomas Zimmermann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®