* [PATCH v2] accel/qaic: initialize ret variable to 0
@ 2023-05-17 16:56 Jeffrey Hugo
2023-05-17 17:10 ` Carl Vanderlip
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jeffrey Hugo @ 2023-05-17 16:56 UTC (permalink / raw)
To: trix, ogabbay, nathan, ndesaulniers, jacek.lawrynowicz,
quic_carlv, stanislaw.gruszka, quic_pkanojiy
Cc: linux-arm-msm, dri-devel, linux-kernel, llvm, Jeffrey Hugo
From: Tom Rix <trix@redhat.com>
clang static analysis reports
drivers/accel/qaic/qaic_data.c:610:2: warning: Undefined or garbage
value returned to caller [core.uninitialized.UndefReturn]
return ret;
^~~~~~~~~~
From a code analysis of the function, the ret variable is only set some
of the time but is always returned. This suggests ret can return
uninitialized garbage. However BO allocation will ensure ret is always
set in reality.
Initialize ret to 0 to silence the warning.
Fixes: ff13be830333 ("accel/qaic: Add datapath")
Signed-off-by: Tom Rix <trix@redhat.com>
[jhugo: Reword commit text]
Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
---
drivers/accel/qaic/qaic_data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accel/qaic/qaic_data.c b/drivers/accel/qaic/qaic_data.c
index 8ab26e64b231..e42c1f9ffff8 100644
--- a/drivers/accel/qaic/qaic_data.c
+++ b/drivers/accel/qaic/qaic_data.c
@@ -591,7 +591,7 @@ static int qaic_gem_object_mmap(struct drm_gem_object *obj, struct vm_area_struc
struct qaic_bo *bo = to_qaic_bo(obj);
unsigned long offset = 0;
struct scatterlist *sg;
- int ret;
+ int ret = 0;
if (obj->import_attach)
return -EINVAL;
--
2.40.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] accel/qaic: initialize ret variable to 0
2023-05-17 16:56 [PATCH v2] accel/qaic: initialize ret variable to 0 Jeffrey Hugo
@ 2023-05-17 17:10 ` Carl Vanderlip
2023-05-18 5:59 ` Pranjal Ramajor Asha Kanojiya
2023-05-23 15:56 ` Jeffrey Hugo
2 siblings, 0 replies; 4+ messages in thread
From: Carl Vanderlip @ 2023-05-17 17:10 UTC (permalink / raw)
To: Jeffrey Hugo, trix, ogabbay, nathan, ndesaulniers,
jacek.lawrynowicz, stanislaw.gruszka, quic_pkanojiy
Cc: linux-arm-msm, dri-devel, linux-kernel, llvm
On 5/17/2023 9:56 AM, Jeffrey Hugo wrote:
> From: Tom Rix <trix@redhat.com>
>
> clang static analysis reports
> drivers/accel/qaic/qaic_data.c:610:2: warning: Undefined or garbage
> value returned to caller [core.uninitialized.UndefReturn]
> return ret;
> ^~~~~~~~~~
>
>>From a code analysis of the function, the ret variable is only set some
> of the time but is always returned. This suggests ret can return
> uninitialized garbage. However BO allocation will ensure ret is always
> set in reality.
>
> Initialize ret to 0 to silence the warning.
>
> Fixes: ff13be830333 ("accel/qaic: Add datapath")
> Signed-off-by: Tom Rix <trix@redhat.com>
> [jhugo: Reword commit text]
> Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
> ---
> drivers/accel/qaic/qaic_data.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accel/qaic/qaic_data.c b/drivers/accel/qaic/qaic_data.c
> index 8ab26e64b231..e42c1f9ffff8 100644
> --- a/drivers/accel/qaic/qaic_data.c
> +++ b/drivers/accel/qaic/qaic_data.c
> @@ -591,7 +591,7 @@ static int qaic_gem_object_mmap(struct drm_gem_object *obj, struct vm_area_struc
> struct qaic_bo *bo = to_qaic_bo(obj);
> unsigned long offset = 0;
> struct scatterlist *sg;
> - int ret;
> + int ret = 0;
>
> if (obj->import_attach)
> return -EINVAL;
LGTM
Reviewed-by: Carl Vanderlip <quic_carlv@quicinc.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] accel/qaic: initialize ret variable to 0
2023-05-17 16:56 [PATCH v2] accel/qaic: initialize ret variable to 0 Jeffrey Hugo
2023-05-17 17:10 ` Carl Vanderlip
@ 2023-05-18 5:59 ` Pranjal Ramajor Asha Kanojiya
2023-05-23 15:56 ` Jeffrey Hugo
2 siblings, 0 replies; 4+ messages in thread
From: Pranjal Ramajor Asha Kanojiya @ 2023-05-18 5:59 UTC (permalink / raw)
To: Jeffrey Hugo, trix, ogabbay, nathan, ndesaulniers,
jacek.lawrynowicz, quic_carlv, stanislaw.gruszka
Cc: linux-arm-msm, dri-devel, linux-kernel, llvm
On 5/17/2023 10:26 PM, Jeffrey Hugo wrote:
> From: Tom Rix <trix@redhat.com>
>
> clang static analysis reports
> drivers/accel/qaic/qaic_data.c:610:2: warning: Undefined or garbage
> value returned to caller [core.uninitialized.UndefReturn]
> return ret;
> ^~~~~~~~~~
>
> From a code analysis of the function, the ret variable is only set some
> of the time but is always returned. This suggests ret can return
> uninitialized garbage. However BO allocation will ensure ret is always
> set in reality.
>
> Initialize ret to 0 to silence the warning.
>
> Fixes: ff13be830333 ("accel/qaic: Add datapath")
> Signed-off-by: Tom Rix <trix@redhat.com>
> [jhugo: Reword commit text]
> Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
> ---
> drivers/accel/qaic/qaic_data.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accel/qaic/qaic_data.c b/drivers/accel/qaic/qaic_data.c
> index 8ab26e64b231..e42c1f9ffff8 100644
> --- a/drivers/accel/qaic/qaic_data.c
> +++ b/drivers/accel/qaic/qaic_data.c
> @@ -591,7 +591,7 @@ static int qaic_gem_object_mmap(struct drm_gem_object *obj, struct vm_area_struc
> struct qaic_bo *bo = to_qaic_bo(obj);
> unsigned long offset = 0;
> struct scatterlist *sg;
> - int ret;
> + int ret = 0;
>
> if (obj->import_attach)
> return -EINVAL;
Reviewed-by: Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@quicinc.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] accel/qaic: initialize ret variable to 0
2023-05-17 16:56 [PATCH v2] accel/qaic: initialize ret variable to 0 Jeffrey Hugo
2023-05-17 17:10 ` Carl Vanderlip
2023-05-18 5:59 ` Pranjal Ramajor Asha Kanojiya
@ 2023-05-23 15:56 ` Jeffrey Hugo
2 siblings, 0 replies; 4+ messages in thread
From: Jeffrey Hugo @ 2023-05-23 15:56 UTC (permalink / raw)
To: trix, ogabbay, nathan, ndesaulniers, jacek.lawrynowicz,
quic_carlv, stanislaw.gruszka, quic_pkanojiy
Cc: linux-arm-msm, dri-devel, linux-kernel, llvm
On 5/17/2023 10:56 AM, Jeffrey Hugo wrote:
> From: Tom Rix <trix@redhat.com>
>
> clang static analysis reports
> drivers/accel/qaic/qaic_data.c:610:2: warning: Undefined or garbage
> value returned to caller [core.uninitialized.UndefReturn]
> return ret;
> ^~~~~~~~~~
>
> From a code analysis of the function, the ret variable is only set some
> of the time but is always returned. This suggests ret can return
> uninitialized garbage. However BO allocation will ensure ret is always
> set in reality.
>
> Initialize ret to 0 to silence the warning.
>
> Fixes: ff13be830333 ("accel/qaic: Add datapath")
> Signed-off-by: Tom Rix <trix@redhat.com>
> [jhugo: Reword commit text]
> Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Pushed to drm-misc-fixes
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-23 15:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-17 16:56 [PATCH v2] accel/qaic: initialize ret variable to 0 Jeffrey Hugo
2023-05-17 17:10 ` Carl Vanderlip
2023-05-18 5:59 ` Pranjal Ramajor Asha Kanojiya
2023-05-23 15:56 ` Jeffrey Hugo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®