From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <seanjc@google.com>,
Carlos Bilbao <carlos.bilbao@amd.com>
Cc: tglx@linutronix.de, bp@alien8.de, mingo@redhat.com,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
venu.busireddy@oracle.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, "Lendacky,
Thomas" <Thomas.Lendacky@amd.com>,
bilbao@vt.edu
Subject: Re: [PATCH] KVM: SVM: Fix reserved fields of struct sev_es_save_area
Date: Sat, 22 Oct 2022 09:46:04 +0200 [thread overview]
Message-ID: <d64d2144-449e-0dec-6bc1-a5478a0febc0@redhat.com> (raw)
In-Reply-To: <YzxfdQ7DrT9X6t7j@google.com>
On 10/4/22 18:29, Sean Christopherson wrote:
> If we really want to the number to have any kind of meaning without needing a pile
> of churn for every update, the best idea I can think of is to name them reserved_<offset>.
> That way only the affected reserved field needs to be modified when adding new
> legal fields. But that has it's own flavor of maintenance burden as calculating
> and verifying the offset is a waste of everyone's time.
Finding the right offsets is usually pretty quick because they can be
found in the manual (or something close to the offset can be found
there) and verifying them can be done with BUILD_BUG_ON.
If Carlos prepared a patch using offsets (with BUILD_BUG_ON to ensure no
future bitrot) I would apply it gladly. If it's just renumbering as in
this one, however, I'd just ignore it.
Paolo
Paolo
next prev parent reply other threads:[~2022-10-22 10:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 14:05 Carlos Bilbao
2022-10-04 14:28 ` Carlos Bilbao
2022-10-04 16:29 ` Sean Christopherson
2022-10-04 17:12 ` Carlos Bilbao
2022-10-04 18:51 ` Sean Christopherson
2022-10-04 19:06 ` Carlos Bilbao
2022-10-22 7:46 ` Paolo Bonzini [this message]
2022-10-24 16:35 ` Carlos Bilbao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d64d2144-449e-0dec-6bc1-a5478a0febc0@redhat.com \
--to=pbonzini@redhat.com \
--cc=Thomas.Lendacky@amd.com \
--cc=bilbao@vt.edu \
--cc=bp@alien8.de \
--cc=carlos.bilbao@amd.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=venu.busireddy@oracle.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome