mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: pinctrl: samsung: Require clocks for Exynos9610 pinctrl nodes
@ 2026-09-22 12:15 Alexandru Chimac
  2026-09-22 14:25 ` Alexandru Chimac
  2026-09-23 14:58 ` Krzysztof Kozlowski
  0 siblings, 2 replies; 4+ messages in thread
From: Alexandru Chimac @ 2026-09-22 12:15 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Sylwester Nawrocki, Peter Griffin,
	Alim Akhtar, Linus Walleij, Rob Herring, Conor Dooley,
	Tomasz Figa
  Cc: linux-arm-kernel, linux-samsung-soc, linux-gpio, devicetree,
	linux-kernel, Alexandru Chimac

All Exynos9610 pin controllers (except PINCTRL_TOP) have clocks assigned
to them, so force the nodes to have clocks assigned to them.

Signed-off-by: Alexandru Chimac <alex@chimac.ro>
---
Most Samsung Exynos9610 pin controllers (except TOP) have clocks
designated for them, so allow the device tree node to include clock
information for the driver.
---
 Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml
index 1feb6a6fc690..e4fdedb29631 100644
--- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml
@@ -140,6 +140,7 @@ allOf:
             enum:
               - google,gs101-pinctrl
               - samsung,exynos8890-pinctrl
+              - samsung,exynos9610-pinctrl
     then:
       required:
         - clocks

---
base-commit: c2cd463d6ee7d55a3ec0719d93c49ff99022d58f
change-id: 20260922-exynos9610-pinctrl-patch-e0cc7118dc97

Best regards,
--  
Alexandru Chimac <alex@chimac.ro>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: pinctrl: samsung: Require clocks for Exynos9610 pinctrl nodes
  2026-09-22 12:15 [PATCH] dt-bindings: pinctrl: samsung: Require clocks for Exynos9610 pinctrl nodes Alexandru Chimac
@ 2026-09-22 14:25 ` Alexandru Chimac
  2026-09-23 14:58 ` Krzysztof Kozlowski
  1 sibling, 0 replies; 4+ messages in thread
From: Alexandru Chimac @ 2026-09-22 14:25 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Sylwester Nawrocki, Peter Griffin,
	Alim Akhtar, Linus Walleij, Rob Herring, Conor Dooley,
	Tomasz Figa
  Cc: linux-arm-kernel, linux-samsung-soc, linux-gpio, devicetree,
	linux-kernel

Sorry for the spam, I had some issues with the mail host but they're all
fixed now.

> On 09/22/2026 3:15 PM EEST Alexandru Chimac <alex@chimac.ro> wrote:
> 
>  
> All Exynos9610 pin controllers (except PINCTRL_TOP) have clocks assigned
> to them, so force the nodes to have clocks assigned to them.
> 
> Signed-off-by: Alexandru Chimac <alex@chimac.ro>
> ---
> Most Samsung Exynos9610 pin controllers (except TOP) have clocks
> designated for them, so allow the device tree node to include clock
> information for the driver.
> ---
>  Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml
> index 1feb6a6fc690..e4fdedb29631 100644
> --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml
> @@ -140,6 +140,7 @@ allOf:
>              enum:
>                - google,gs101-pinctrl
>                - samsung,exynos8890-pinctrl
> +              - samsung,exynos9610-pinctrl
>      then:
>        required:
>          - clocks
> 
> ---
> base-commit: c2cd463d6ee7d55a3ec0719d93c49ff99022d58f
> change-id: 20260922-exynos9610-pinctrl-patch-e0cc7118dc97
> 
> Best regards,
> --  
> Alexandru Chimac <alex@chimac.ro>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: pinctrl: samsung: Require clocks for Exynos9610 pinctrl nodes
  2026-09-22 12:15 [PATCH] dt-bindings: pinctrl: samsung: Require clocks for Exynos9610 pinctrl nodes Alexandru Chimac
  2026-09-22 14:25 ` Alexandru Chimac
@ 2026-09-23 14:58 ` Krzysztof Kozlowski
  1 sibling, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-09-23 14:58 UTC (permalink / raw)
  To: Alexandru Chimac, Sylwester Nawrocki, Peter Griffin, Alim Akhtar,
	Linus Walleij, Rob Herring, Conor Dooley, Tomasz Figa
  Cc: linux-arm-kernel, linux-samsung-soc, linux-gpio, devicetree,
	linux-kernel

On 22/09/2026 14:15, Alexandru Chimac wrote:
> All Exynos9610 pin controllers (except PINCTRL_TOP) have clocks assigned
> to them, so force the nodes to have clocks assigned to them.
> 
> Signed-off-by: Alexandru Chimac <alex@chimac.ro>
> ---
> Most Samsung Exynos9610 pin controllers (except TOP) have clocks
> designated for them, so allow the device tree node to include clock

I don't understand above. It's contradictory to commit msg which says
ALL. Here you say most.


Why two commit msgs?

> information for the driver.

that's ABI break without reason.


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] dt-bindings: pinctrl: samsung: Require clocks for Exynos9610 pinctrl nodes
@ 2026-09-22 12:07 Alexandru Chimac
  0 siblings, 0 replies; 4+ messages in thread
From: Alexandru Chimac @ 2026-09-22 12:07 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Sylwester Nawrocki, Peter Griffin,
	Alim Akhtar, Linus Walleij, Rob Herring, Conor Dooley,
	Tomasz Figa
  Cc: linux-arm-kernel, linux-samsung-soc, linux-gpio, devicetree,
	linux-kernel, Alexandru Chimac

All Exynos9610 pin controllers (except PINCTRL_TOP) have clocks assigned
to them, so force the nodes to have clocks assigned to them.

Signed-off-by: Alexandru Chimac <alex@chimac.ro>
---
Most Samsung Exynos9610 pin controllers (except TOP) have clocks
designated for them, so allow the device tree node to include clock
information for the driver.
---
 Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml
index 1feb6a6fc690..e4fdedb29631 100644
--- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml
@@ -140,6 +140,7 @@ allOf:
             enum:
               - google,gs101-pinctrl
               - samsung,exynos8890-pinctrl
+              - samsung,exynos9610-pinctrl
     then:
       required:
         - clocks

---
base-commit: c2cd463d6ee7d55a3ec0719d93c49ff99022d58f
change-id: 20260922-exynos9610-pinctrl-patch-e0cc7118dc97

Best regards,
--  
Alexandru Chimac <alex@chimac.ro>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-09-23 14:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-22 12:15 [PATCH] dt-bindings: pinctrl: samsung: Require clocks for Exynos9610 pinctrl nodes Alexandru Chimac
2026-09-22 14:25 ` Alexandru Chimac
2026-09-23 14:58 ` Krzysztof Kozlowski
  -- strict thread matches above, loose matches on Subject: below --
2026-09-22 12:07 Alexandru Chimac

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®