mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] mt76: mt7915: expose device tree match table
@ 2023-02-18 11:29 Lorenz Brun
  2023-02-20  9:04 ` AngeloGioacchino Del Regno
  0 siblings, 1 reply; 2+ messages in thread
From: Lorenz Brun @ 2023-02-18 11:29 UTC (permalink / raw)
  To: Felix Fietkau, Lorenzo Bianconi, Ryder Lee, Shayne Chen,
	Sean Wang, Kalle Valo, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Matthias Brugger,
	AngeloGioacchino Del Regno, Bo Jiao, Peter Chiu, Sujuan Chen
  Cc: linux-wireless, netdev, linux-kernel, linux-arm-kernel, linux-mediatek

On MT7986 the WiFi driver currently does not get automatically loaded,
requiring manual modprobing because the device tree compatibles are not
exported into metadata.

Add the missing MODULE_DEVICE_TABLE macro to fix this.

Fixes: 99ad32a4ca3a2 ("mt76: mt7915: add support for MT7986")
Signed-off-by: Lorenz Brun <lorenz@brun.one>
---
 drivers/net/wireless/mediatek/mt76/mt7915/soc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/soc.c b/drivers/net/wireless/mediatek/mt76/mt7915/soc.c
index 2ac0a0f2859cb..32c137066e7f7 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/soc.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/soc.c
@@ -1239,6 +1239,8 @@ static const struct of_device_id mt7986_wmac_of_match[] = {
 	{},
 };
 
+MODULE_DEVICE_TABLE(of, mt7986_wmac_of_match);
+
 struct platform_driver mt7986_wmac_driver = {
 	.driver = {
 		.name = "mt7986-wmac",
-- 
2.39.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mt76: mt7915: expose device tree match table
  2023-02-18 11:29 [PATCH] mt76: mt7915: expose device tree match table Lorenz Brun
@ 2023-02-20  9:04 ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 2+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-02-20  9:04 UTC (permalink / raw)
  To: Lorenz Brun, Felix Fietkau, Lorenzo Bianconi, Ryder Lee,
	Shayne Chen, Sean Wang, Kalle Valo, David S. Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni, Matthias Brugger,
	Bo Jiao, Peter Chiu, Sujuan Chen
  Cc: linux-wireless, netdev, linux-kernel, linux-arm-kernel, linux-mediatek

Il 18/02/23 12:29, Lorenz Brun ha scritto:
> On MT7986 the WiFi driver currently does not get automatically loaded,
> requiring manual modprobing because the device tree compatibles are not
> exported into metadata.
> 
> Add the missing MODULE_DEVICE_TABLE macro to fix this.
> 
> Fixes: 99ad32a4ca3a2 ("mt76: mt7915: add support for MT7986")
> Signed-off-by: Lorenz Brun <lorenz@brun.one>

I don't think that this commit needs a Fixes tag, as you're only adding (good)
auto-load commodity.

Regardless of that:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-02-20  9:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-18 11:29 [PATCH] mt76: mt7915: expose device tree match table Lorenz Brun
2023-02-20  9:04 ` AngeloGioacchino Del Regno

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome