From: John Youn <John.Youn@synopsys.com>
To: Leo Yan <leo.yan@linaro.org>, John Youn <John.Youn@synopsys.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
John Stultz <john.stultz@linaro.org>,
"Guodong Xu" <guodong.xu@linaro.org>,
"zhangfei.gao@linaro.org" <zhangfei.gao@linaro.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Steve Muckle <steve.muckle@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Robert Baldyga <r.baldyga@samsung.com>
Subject: Re: [PATCH] Revert "usb: dwc2: gadget: fix TX FIFO size and address initialization"
Date: Fri, 28 Oct 2016 11:22:48 -0700 [thread overview]
Message-ID: <d6b4322d-1c2b-2036-79cf-cf5aaa14f2e1@synopsys.com> (raw)
In-Reply-To: <1477669902-24032-1-git-send-email-leo.yan@linaro.org>
On 10/28/2016 8:52 AM, Leo Yan wrote:
> This reverts commit aa381a7259c3f53727bcaa8c5f9359e940a0e3fd.
>
> Reverting this patch, as it incorrectly assumes TX FIFO size is fixed
> and cannot change FIFO size; it removes all related dt binding code
> and have no chance to set FIFO size at init phase.
>
> As result, Hi6220 cannot set correct FIFO size for gadget driver and
> ethernet on USB function driver is easily to hang. And in the kernel
> there also have other platforms set FIFO size for usb controller,
> e.g. arch/arm64/boot/dts/rockchip/rk3368.dtsi.
>
> This patch re-enables dt binding to set FIFO size.
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
This is already queued for 4.9-rc in Felipe's tree.
Hi Felipe,
It seems like your fixes branch for 4.9-rc2 didn't get merged
upstream. Can we get them pulled for the next -rc? There are platforms
that are broken on 4.9 without them.
Thanks,
John
prev parent reply other threads:[~2016-10-28 18:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 15:51 Leo Yan
2016-10-28 18:22 ` John Youn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6b4322d-1c2b-2036-79cf-cf5aaa14f2e1@synopsys.com \
--to=john.youn@synopsys.com \
--cc=dietmar.eggemann@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=guodong.xu@linaro.org \
--cc=john.stultz@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=r.baldyga@samsung.com \
--cc=steve.muckle@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®