* Re: [PATCH] perf: arm-ni: Fix missing platform_set_drvdata()
[not found] <20250401054248.3985814-1-andy.xu@hj-micro.com>
@ 2025-04-01 14:04 ` Robin Murphy
2025-04-17 14:27 ` Will Deacon
1 sibling, 0 replies; 2+ messages in thread
From: Robin Murphy @ 2025-04-01 14:04 UTC (permalink / raw)
To: Hongbo Yao, will
Cc: mark.rutland, linux-arm-kernel, linux-kernel, allen.wang, peter.du
On 2025-04-01 6:42 am, Hongbo Yao wrote:
> Add missing platform_set_drvdata in arm_ni_probe(), otherwise
> calling platform_get_drvdata() in remove returns NULL.
Oops, indeed. Not sure how that got lost...
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
> Fixes: 4d5a7680f2b4 ("perf: Add driver for Arm NI-700 interconnect PMU")
> Signed-off-by: Hongbo Yao <andy.xu@hj-micro.com>
> ---
> drivers/perf/arm-ni.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/perf/arm-ni.c b/drivers/perf/arm-ni.c
> index ee85577e86b9..da1907b7391d 100644
> --- a/drivers/perf/arm-ni.c
> +++ b/drivers/perf/arm-ni.c
> @@ -666,6 +666,7 @@ static int arm_ni_probe(struct platform_device *pdev)
> ni->num_cds = num_cds;
> ni->part = part;
> ni->id = atomic_fetch_inc(&id);
> + platform_set_drvdata(pdev, ni);
>
> for (int v = 0; v < cfg.num_components; v++) {
> reg = readl_relaxed(cfg.base + NI_CHILD_PTR(v));
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] perf: arm-ni: Fix missing platform_set_drvdata()
[not found] <20250401054248.3985814-1-andy.xu@hj-micro.com>
2025-04-01 14:04 ` [PATCH] perf: arm-ni: Fix missing platform_set_drvdata() Robin Murphy
@ 2025-04-17 14:27 ` Will Deacon
1 sibling, 0 replies; 2+ messages in thread
From: Will Deacon @ 2025-04-17 14:27 UTC (permalink / raw)
To: robin.murphy, Hongbo Yao
Cc: catalin.marinas, kernel-team, Will Deacon, mark.rutland,
linux-arm-kernel, linux-kernel, allen.wang, peter.du
On Tue, 01 Apr 2025 13:42:48 +0800, Hongbo Yao wrote:
> Add missing platform_set_drvdata in arm_ni_probe(), otherwise
> calling platform_get_drvdata() in remove returns NULL.
>
>
Applied to will (for-next/perf), thanks!
[1/1] perf: arm-ni: Fix missing platform_set_drvdata()
https://git.kernel.org/will/c/fc5106088d6d
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-17 14:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20250401054248.3985814-1-andy.xu@hj-micro.com>
2025-04-01 14:04 ` [PATCH] perf: arm-ni: Fix missing platform_set_drvdata() Robin Murphy
2025-04-17 14:27 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®