From: Jens Axboe <axboe@kernel.dk>
To: Jianchao Wang <jianchao.w.wang@oracle.com>, ming.lei@redhat.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk-mq: return when BLK_MQ_S_STOPPED in blk_mq_run_work_fn
Date: Mon, 4 Jun 2018 10:21:14 -0600 [thread overview]
Message-ID: <d6cee6a0-d20a-0055-24f7-a3e625c2f5b3@kernel.dk> (raw)
In-Reply-To: <1528103035-8009-1-git-send-email-jianchao.w.wang@oracle.com>
On 6/4/18 3:03 AM, Jianchao Wang wrote:
> if hctx is stopped, don't run the queue in blk_mq_run_work_fn.
I was puzzled, so had to look up those changes. That's definitely
a regression caused by 15fe8a9, as you highlighted. Looks good to
me, I'll apply it.
BTW, this should have been explained in the commit message. I'll
change it a bit.
--
Jens Axboe
prev parent reply other threads:[~2018-06-04 16:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 9:03 Jianchao Wang
2018-06-04 10:43 ` Ming Lei
2018-06-04 11:36 ` Bart Van Assche
2018-06-04 16:21 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6cee6a0-d20a-0055-24f7-a3e625c2f5b3@kernel.dk \
--to=axboe@kernel.dk \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®