From: Markus Elfring <Markus.Elfring@web.de>
To: Yi Wang <wang.yi59@zte.com.cn>,
Liao Pingfang <liao.pingfang@zte.com.cn>,
linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
Wang Liang <wang.liang82@zte.com.cn>,
Xue Zhihong <xue.zhihong@zte.com.cn>
Subject: Re: [PATCH] ARM: milbeaut: Add missing of_node_put()
Date: Thu, 23 Jul 2020 09:00:11 +0200 [thread overview]
Message-ID: <d6df080c-f2cc-0e9a-7a7d-fb977323f92b@web.de> (raw)
> After finishing using device node got from of_find_compatible_node(),
> of_node_put() needs to be called.
* An imperative wording can be preferred for the change description,
can't it?
* Will the tag “Fixes” become helpful for the commit message?
Regards,
Markus
next reply other threads:[~2020-07-23 7:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 7:00 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-07-23 1:24 Yi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6df080c-f2cc-0e9a-7a7d-fb977323f92b@web.de \
--to=markus.elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=liao.pingfang@zte.com.cn \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=wang.liang82@zte.com.cn \
--cc=wang.yi59@zte.com.cn \
--cc=xue.zhihong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®