* Re: [PATCH] ARM: milbeaut: Add missing of_node_put()
@ 2020-07-23 7:00 Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2020-07-23 7:00 UTC (permalink / raw)
To: Yi Wang, Liao Pingfang, linux-arm-kernel
Cc: linux-kernel, kernel-janitors, Russell King, Wang Liang, Xue Zhihong
> After finishing using device node got from of_find_compatible_node(),
> of_node_put() needs to be called.
* An imperative wording can be preferred for the change description,
can't it?
* Will the tag “Fixes” become helpful for the commit message?
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] ARM: milbeaut: Add missing of_node_put()
@ 2020-07-23 1:24 Yi Wang
0 siblings, 0 replies; 2+ messages in thread
From: Yi Wang @ 2020-07-23 1:24 UTC (permalink / raw)
To: linux
Cc: linux-arm-kernel, linux-kernel, xue.zhihong, wang.yi59,
wang.liang82, Liao Pingfang
From: Liao Pingfang <liao.pingfang@zte.com.cn>
After finishing using device node got from of_find_compatible_node(),
of_node_put() needs to be called.
Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
---
arch/arm/mach-milbeaut/platsmp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-milbeaut/platsmp.c b/arch/arm/mach-milbeaut/platsmp.c
index 3ea880f..1f1ff21 100644
--- a/arch/arm/mach-milbeaut/platsmp.c
+++ b/arch/arm/mach-milbeaut/platsmp.c
@@ -53,6 +53,7 @@ static void m10v_smp_init(unsigned int max_cpus)
return;
m10v_smp_base = of_iomap(np, 0);
+ of_node_put(np);
if (!m10v_smp_base)
return;
--
2.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-23 7:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-23 7:00 [PATCH] ARM: milbeaut: Add missing of_node_put() Markus Elfring
-- strict thread matches above, loose matches on Subject: below --
2020-07-23 1:24 Yi Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®