From: Joe Perches <joe@perches.com>
To: sachin agarwal <asachin591@gmail.com>, Eugeniy.Paltsev@synopsys.com
Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] GPIO: creg-snps: fixed a typo
Date: Sat, 18 Jan 2020 09:29:26 -0800 [thread overview]
Message-ID: <d7010f3bc07d2666e6bbde3140d51acd539cb55b.camel@perches.com> (raw)
In-Reply-To: <20200118104506.68524-1-sachinagarwal@sachins-MacBook-2.local>
On Sat, 2020-01-18 at 16:15 +0530, sachin agarwal wrote:
> From: Sachin agarwal <asachin591@gmail.com>
>
> we had written "valiue" rather than "value".
[]
> diff --git a/drivers/gpio/gpio-creg-snps.c b/drivers/gpio/gpio-creg-snps.c
[]
> @@ -64,11 +64,11 @@ static int creg_gpio_validate_pg(struct device *dev, struct creg_gpio *hcg,
> if (layout->bit_per_gpio[i] < 1 || layout->bit_per_gpio[i] > 8)
> return -EINVAL;
>
> - /* Check that on valiue fits it's placeholder */
> + /* Check that on value fits it's placeholder */
Might as well fix the it's/its usages too.
> if (GENMASK(31, layout->bit_per_gpio[i]) & layout->on[i])
> return -EINVAL;
>
> - /* Check that off valiue fits it's placeholder */
> + /* Check that off value fits it's placeholder */
> if (GENMASK(31, layout->bit_per_gpio[i]) & layout->off[i])
> return -EINVAL;
>
next prev parent reply other threads:[~2020-01-18 17:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-18 10:45 sachin agarwal
2020-01-18 17:29 ` Joe Perches [this message]
2020-01-18 20:06 sachin agarwal
2020-01-29 14:52 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7010f3bc07d2666e6bbde3140d51acd539cb55b.camel@perches.com \
--to=joe@perches.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=asachin591@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®