* [PATCH 4/4] GPIO: creg-snps: fixed a typo
@ 2020-01-18 10:45 sachin agarwal
2020-01-18 17:29 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: sachin agarwal @ 2020-01-18 10:45 UTC (permalink / raw)
To: Eugeniy.Paltsev
Cc: linus.walleij, bgolaszewski, linux-gpio, linux-kernel, asachin591
From: Sachin agarwal <asachin591@gmail.com>
we had written "valiue" rather than "value".
Signed-off-by: Sachin Agarwal <asachin591@gmail.com>
---
drivers/gpio/gpio-creg-snps.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-creg-snps.c b/drivers/gpio/gpio-creg-snps.c
index ff19a8ad5663..3705cf993c7e 100644
--- a/drivers/gpio/gpio-creg-snps.c
+++ b/drivers/gpio/gpio-creg-snps.c
@@ -64,11 +64,11 @@ static int creg_gpio_validate_pg(struct device *dev, struct creg_gpio *hcg,
if (layout->bit_per_gpio[i] < 1 || layout->bit_per_gpio[i] > 8)
return -EINVAL;
- /* Check that on valiue fits it's placeholder */
+ /* Check that on value fits it's placeholder */
if (GENMASK(31, layout->bit_per_gpio[i]) & layout->on[i])
return -EINVAL;
- /* Check that off valiue fits it's placeholder */
+ /* Check that off value fits it's placeholder */
if (GENMASK(31, layout->bit_per_gpio[i]) & layout->off[i])
return -EINVAL;
--
2.24.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 4/4] GPIO: creg-snps: fixed a typo
2020-01-18 10:45 [PATCH 4/4] GPIO: creg-snps: fixed a typo sachin agarwal
@ 2020-01-18 17:29 ` Joe Perches
0 siblings, 0 replies; 4+ messages in thread
From: Joe Perches @ 2020-01-18 17:29 UTC (permalink / raw)
To: sachin agarwal, Eugeniy.Paltsev
Cc: linus.walleij, bgolaszewski, linux-gpio, linux-kernel
On Sat, 2020-01-18 at 16:15 +0530, sachin agarwal wrote:
> From: Sachin agarwal <asachin591@gmail.com>
>
> we had written "valiue" rather than "value".
[]
> diff --git a/drivers/gpio/gpio-creg-snps.c b/drivers/gpio/gpio-creg-snps.c
[]
> @@ -64,11 +64,11 @@ static int creg_gpio_validate_pg(struct device *dev, struct creg_gpio *hcg,
> if (layout->bit_per_gpio[i] < 1 || layout->bit_per_gpio[i] > 8)
> return -EINVAL;
>
> - /* Check that on valiue fits it's placeholder */
> + /* Check that on value fits it's placeholder */
Might as well fix the it's/its usages too.
> if (GENMASK(31, layout->bit_per_gpio[i]) & layout->on[i])
> return -EINVAL;
>
> - /* Check that off valiue fits it's placeholder */
> + /* Check that off value fits it's placeholder */
> if (GENMASK(31, layout->bit_per_gpio[i]) & layout->off[i])
> return -EINVAL;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 4/4] GPIO: creg-snps: fixed a typo
@ 2020-01-18 20:06 sachin agarwal
2020-01-29 14:52 ` Bartosz Golaszewski
0 siblings, 1 reply; 4+ messages in thread
From: sachin agarwal @ 2020-01-18 20:06 UTC (permalink / raw)
To: Eugeniy.Paltsev
Cc: linus.walleij, bgolaszewski, linux-gpio, linux-kernel,
asachin591, sachin agarwal
we had written "valiue" rather than "value" and "it's" rather than "its".
Signed-off-by: Sachin Agarwal <asachin591@gmail.com>
---
drivers/gpio/gpio-creg-snps.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-creg-snps.c b/drivers/gpio/gpio-creg-snps.c
index ff19a8ad5663..1d0827e79703 100644
--- a/drivers/gpio/gpio-creg-snps.c
+++ b/drivers/gpio/gpio-creg-snps.c
@@ -64,11 +64,11 @@ static int creg_gpio_validate_pg(struct device *dev, struct creg_gpio *hcg,
if (layout->bit_per_gpio[i] < 1 || layout->bit_per_gpio[i] > 8)
return -EINVAL;
- /* Check that on valiue fits it's placeholder */
+ /* Check that on value fits its placeholder */
if (GENMASK(31, layout->bit_per_gpio[i]) & layout->on[i])
return -EINVAL;
- /* Check that off valiue fits it's placeholder */
+ /* Check that off value fits its placeholder */
if (GENMASK(31, layout->bit_per_gpio[i]) & layout->off[i])
return -EINVAL;
--
2.24.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 4/4] GPIO: creg-snps: fixed a typo
2020-01-18 20:06 sachin agarwal
@ 2020-01-29 14:52 ` Bartosz Golaszewski
0 siblings, 0 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2020-01-29 14:52 UTC (permalink / raw)
To: sachin agarwal
Cc: Eugeniy.Paltsev, Linus Walleij, linux-gpio, LKML, sachin agarwal
sob., 18 sty 2020 o 21:06 sachin agarwal <asachin591@gmail.com> napisał(a):
>
> we had written "valiue" rather than "value" and "it's" rather than "its".
>
> Signed-off-by: Sachin Agarwal <asachin591@gmail.com>
> ---
> drivers/gpio/gpio-creg-snps.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-creg-snps.c b/drivers/gpio/gpio-creg-snps.c
> index ff19a8ad5663..1d0827e79703 100644
> --- a/drivers/gpio/gpio-creg-snps.c
> +++ b/drivers/gpio/gpio-creg-snps.c
> @@ -64,11 +64,11 @@ static int creg_gpio_validate_pg(struct device *dev, struct creg_gpio *hcg,
> if (layout->bit_per_gpio[i] < 1 || layout->bit_per_gpio[i] > 8)
> return -EINVAL;
>
> - /* Check that on valiue fits it's placeholder */
> + /* Check that on value fits its placeholder */
> if (GENMASK(31, layout->bit_per_gpio[i]) & layout->on[i])
> return -EINVAL;
>
> - /* Check that off valiue fits it's placeholder */
> + /* Check that off value fits its placeholder */
> if (GENMASK(31, layout->bit_per_gpio[i]) & layout->off[i])
> return -EINVAL;
>
> --
> 2.24.1
>
The subject should be 'gpio: <driver name: ...' and this looks like a
new version of the series, so please mark it as such and describe the
differences between versions.
Please refer to Documentation/process/development-process.rst on how
to submit patches.
Bartosz
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-29 14:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-18 10:45 [PATCH 4/4] GPIO: creg-snps: fixed a typo sachin agarwal
2020-01-18 17:29 ` Joe Perches
2020-01-18 20:06 sachin agarwal
2020-01-29 14:52 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®