[PATCH] drm: panel-backlight-quirks: Add Framework 16 panel

[PATCH] drm: panel-backlight-quirks: Add Framework 16 panel

[Mark Dietzer]

Similarly for the Framework 13 panels already handled in those quirks, the 16 can be helped by the same kind of patch.

I have run this on my own 16 for multiple months (hard coding the value to 0 before the quirks made it upstream) and it has resulted in a darker minimum brightness (as expected) and no issues.

The Framework community threads between the 13 and 16 for this improvement are the same one, so user reports in the link below will be mixed and likely more focused on the 13.

Link: https://community.frame.work/t/solved-even-lower-screen-brightness/25711/60

---
 drivers/gpu/drm/drm_panel_backlight_quirks.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_backlight_quirks.c b/drivers/gpu/drm/drm_panel_backlight_quirks.c
index c477d98ade2b..52aa2a7fa63e 100644
--- a/drivers/gpu/drm/drm_panel_backlight_quirks.c
+++ b/drivers/gpu/drm/drm_panel_backlight_quirks.c
@@ -41,6 +41,14 @@ static const struct drm_panel_min_backlight_quirk drm_panel_min_backlight_quirks
                .ident.name = "NE135A1M-NY1",
                .min_brightness = 0,
        },
+       /* 16 inch panel */
+       {
+               .dmi_match.field = DMI_BOARD_VENDOR,
+               .dmi_match.value = "Framework",
+               .ident.panel_id = drm_edid_encode_panel_id('B', 'O', 'E', 0x0cb4),
+               .ident.name = "NE160QDM-NZ6",
+               .min_brightness = 0,
+       },
 };

 static bool drm_panel_min_backlight_quirk_matches(const struct drm_panel_min_backlight_quirk *quirk,
--
2.48.1

Re: [PATCH] drm: panel-backlight-quirks: Add Framework 16 panel

[Thomas Weißschuh]

Hi Mark!

On 2025-02-27 18:40:12-0800, Mark Dietzer wrote:
> Similarly for the Framework 13 panels already handled in those quirks, the 16 can be helped by the same kind of patch.
> 
> I have run this on my own 16 for multiple months (hard coding the value to 0 before the quirks made it upstream) and it has resulted in a darker minimum brightness (as expected) and no issues.
> 
> The Framework community threads between the 13 and 16 for this improvement are the same one, so user reports in the link below will be mixed and likely more focused on the 13.
> 
> Link: https://community.frame.work/t/solved-even-lower-screen-brightness/25711/60

The patch itself looks good, so:
Reviewed-by: Thomas Weißschuh <linux@weissschuh.net>

However there are a few process issues:

* Commit message should be wrapped to 75 characters.
* Signed-off-by is missing
* The patch is not sent to the maintainers, so it will most likely be
  overlooked.

Please use scripts/get_maintainer.pl and scripts/checkpatch.pl to fix up
these issues (or b4 for the whole process handling).
Then add my Reviewed-by tag and resend the patch with a "v2" marker.

In case of any questions let me know.
Feel free to also send your patch to me privately to check the
formalities.


Thomas

> ---
>  drivers/gpu/drm/drm_panel_backlight_quirks.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_backlight_quirks.c b/drivers/gpu/drm/drm_panel_backlight_quirks.c
> index c477d98ade2b..52aa2a7fa63e 100644
> --- a/drivers/gpu/drm/drm_panel_backlight_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_backlight_quirks.c
> @@ -41,6 +41,14 @@ static const struct drm_panel_min_backlight_quirk drm_panel_min_backlight_quirks
>                 .ident.name = "NE135A1M-NY1",
>                 .min_brightness = 0,
>         },
> +       /* 16 inch panel */
> +       {
> +               .dmi_match.field = DMI_BOARD_VENDOR,
> +               .dmi_match.value = "Framework",
> +               .ident.panel_id = drm_edid_encode_panel_id('B', 'O', 'E', 0x0cb4),
> +               .ident.name = "NE160QDM-NZ6",
> +               .min_brightness = 0,
> +       },
>  };
> 
>  static bool drm_panel_min_backlight_quirk_matches(const struct drm_panel_min_backlight_quirk *quirk,
> --
> 2.48.1

Re: [PATCH] drm: panel-backlight-quirks: Add Framework 16 panel

[Mario Limonciello]

On 2/27/2025 20:40, Mark Dietzer wrote:
> Similarly for the Framework 13 panels already handled in those quirks, the 16 can be helped by the same kind of patch.
> 
> I have run this on my own 16 for multiple months (hard coding the value to 0 before the quirks made it upstream) and it has resulted in a darker minimum brightness (as expected) and no issues.
> 
> The Framework community threads between the 13 and 16 for this improvement are the same one, so user reports in the link below will be mixed and likely more focused on the 13.
> 
> Link: https://community.frame.work/t/solved-even-lower-screen-brightness/25711/60
> 

As an alternative to this patch can you please have a try this patch series?

https://lore.kernel.org/amd-gfx/20250228185145.186319-1-mario.limonciello@amd.com/T/#mfa68d07facf78498776fe12bf64d4dd122d5a4c4

I'm not sure off hand if there is a custom brightness curve on Framework 
16, but if there is the interpolation of the lowest value may get your 
desired outcome without a quirk.

> ---
>   drivers/gpu/drm/drm_panel_backlight_quirks.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_backlight_quirks.c b/drivers/gpu/drm/drm_panel_backlight_quirks.c
> index c477d98ade2b..52aa2a7fa63e 100644
> --- a/drivers/gpu/drm/drm_panel_backlight_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_backlight_quirks.c
> @@ -41,6 +41,14 @@ static const struct drm_panel_min_backlight_quirk drm_panel_min_backlight_quirks
>                  .ident.name = "NE135A1M-NY1",
>                  .min_brightness = 0,
>          },
> +       /* 16 inch panel */
> +       {
> +               .dmi_match.field = DMI_BOARD_VENDOR,
> +               .dmi_match.value = "Framework",
> +               .ident.panel_id = drm_edid_encode_panel_id('B', 'O', 'E', 0x0cb4),
> +               .ident.name = "NE160QDM-NZ6",
> +               .min_brightness = 0,
> +       },
>   };
> 
>   static bool drm_panel_min_backlight_quirk_matches(const struct drm_panel_min_backlight_quirk *quirk,
> --
> 2.48.1
>