[PATCH] irqchip/qcom-pdc: fix builtin vs. module build error

[PATCH] irqchip/qcom-pdc: fix builtin vs. module build error

[Randy Dunlap]

When CONFIG_QCOM_SCM=m and CONFIG_QCOM_PDC=y, the build fails with
aarch64-linux-ld: drivers/irqchip/qcom-pdc.o: in function `qcom_pdc_probe':
qcom-pdc.c:(.text+0x1060): undefined reference to `qcom_scm_is_available'
aarch64-linux-ld: qcom-pdc.c:(.text+0x1094): undefined reference to `qcom_scm_io_writel'

[ARCH_QCOM=y, COMPILE_TEST=y]

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Maulik Shah <maulik.shah@oss.qualcomm.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Cc: Thomas Gleixner <tglx@kernel.org>
Cc: Radu Rendec <radu@rendec.net>
Cc: Bjorn Andersson <andersson@kernel.org>
Cc: Konrad Dybcio <konradybcio@kernel.org>
Cc: Abel Vesa <abelvesa@kernel.org>
Cc: linux-arm-msm@vger.kernel.org

 drivers/irqchip/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20261005.orig/drivers/irqchip/Kconfig
+++ linux-next-20261005/drivers/irqchip/Kconfig
@@ -523,6 +523,7 @@ config GOLDFISH_PIC
 config QCOM_PDC
 	tristate "Qualcomm PDC"
 	depends on ARCH_QCOM || COMPILE_TEST
+	depends on QCOM_SCM
 	select IRQ_DOMAIN_HIERARCHY
 	default ARCH_QCOM
 	help

Re: [PATCH] irqchip/qcom-pdc: fix builtin vs. module build error

[Maulik Shah]

On 07-10-2026 04:48, Randy Dunlap wrote:
> When CONFIG_QCOM_SCM=m and CONFIG_QCOM_PDC=y, the build fails with
> aarch64-linux-ld: drivers/irqchip/qcom-pdc.o: in function `qcom_pdc_probe':
> qcom-pdc.c:(.text+0x1060): undefined reference to `qcom_scm_is_available'
> aarch64-linux-ld: qcom-pdc.c:(.text+0x1094): undefined reference to `qcom_scm_io_writel'
>
> [ARCH_QCOM=y, COMPILE_TEST=y]
This should have fixes tag.

Fixes: ad01c2b2f291 ("irqchip/qcom-pdc: Configure PDC to pass through mode")

with the tag added,

Reviewed-by: Maulik Shah <maulik.shah@oss.qualcomm.com>

Thanks,
Maulik

Re: [PATCH] irqchip/qcom-pdc: fix builtin vs. module build error

[Krzysztof Kozlowski]

On 07/10/2026 01:18, Randy Dunlap wrote:
> When CONFIG_QCOM_SCM=m and CONFIG_QCOM_PDC=y, the build fails with
> aarch64-linux-ld: drivers/irqchip/qcom-pdc.o: in function `qcom_pdc_probe':
> qcom-pdc.c:(.text+0x1060): undefined reference to `qcom_scm_is_available'
> aarch64-linux-ld: qcom-pdc.c:(.text+0x1094): undefined reference to `qcom_scm_io_writel'
> 
> [ARCH_QCOM=y, COMPILE_TEST=y]
> 


Posted 3 weeks ago by Arnd already:
https://lore.kernel.org/all/20260915195948.3521662-1-arnd@kernel.org/

Got also review and that patch should be picked up.

Best regards,
Krzysztof

Re: [PATCH] irqchip/qcom-pdc: fix builtin vs. module build error

[Randy Dunlap]

On 10/8/26 12:34 AM, Krzysztof Kozlowski wrote:
> On 07/10/2026 01:18, Randy Dunlap wrote:
>> When CONFIG_QCOM_SCM=m and CONFIG_QCOM_PDC=y, the build fails with
>> aarch64-linux-ld: drivers/irqchip/qcom-pdc.o: in function `qcom_pdc_probe':
>> qcom-pdc.c:(.text+0x1060): undefined reference to `qcom_scm_is_available'
>> aarch64-linux-ld: qcom-pdc.c:(.text+0x1094): undefined reference to `qcom_scm_io_writel'
>>
>> [ARCH_QCOM=y, COMPILE_TEST=y]
>>
> 
> 
> Posted 3 weeks ago by Arnd already:
> https://lore.kernel.org/all/20260915195948.3521662-1-arnd@kernel.org/
> 
> Got also review and that patch should be picked up.

I agree. I guess that there has been a bit of travel time
in the last 3 weeks. :)

-- 
~Randy