mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] powerpc/pseries/iommu: Add check for iommu_pseries_alloc_group()
@ 2026-06-22 16:38 Haoxiang Li
  2026-06-22 16:50 ` Gaurav Batra
  0 siblings, 1 reply; 2+ messages in thread
From: Haoxiang Li @ 2026-06-22 16:38 UTC (permalink / raw)
  To: maddy, mpe, npiggin, chleroy, gbatra, kees
  Cc: linuxppc-dev, linux-kernel, Haoxiang Li

Add check for the return value of iommu_pseries_alloc_group()
to prevent a potential null pointer dereference.

Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>
---
 arch/powerpc/platforms/pseries/iommu.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/powerpc/platforms/pseries/iommu.c b/arch/powerpc/platforms/pseries/iommu.c
index 3e1f915fe4f6..3b49a0f76df9 100644
--- a/arch/powerpc/platforms/pseries/iommu.c
+++ b/arch/powerpc/platforms/pseries/iommu.c
@@ -1875,6 +1875,9 @@ static void pci_dma_dev_setup_pSeriesLP(struct pci_dev *dev)
 	pci = PCI_DN(pdn);
 	if (!pci->table_group) {
 		pci->table_group = iommu_pseries_alloc_group(pci->phb->node);
+		if (!pci->table_group)
+			return;
+
 		tbl = pci->table_group->tables[0];
 
 		iommu_table_setparms_common(tbl, pci->phb->bus->number,
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] powerpc/pseries/iommu: Add check for iommu_pseries_alloc_group()
  2026-06-22 16:38 [PATCH] powerpc/pseries/iommu: Add check for iommu_pseries_alloc_group() Haoxiang Li
@ 2026-06-22 16:50 ` Gaurav Batra
  0 siblings, 0 replies; 2+ messages in thread
From: Gaurav Batra @ 2026-06-22 16:50 UTC (permalink / raw)
  To: Haoxiang Li, maddy, mpe, npiggin, chleroy, kees
  Cc: linuxppc-dev, linux-kernel

Hello Haoxiang,

Please add this check for pci_dma_bus_setup_pSeriesLP() as well.

Thanks,

Gaurav

On 6/22/26 11:38 AM, Haoxiang Li wrote:
> Add check for the return value of iommu_pseries_alloc_group()
> to prevent a potential null pointer dereference.
>
> Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>
> ---
>   arch/powerpc/platforms/pseries/iommu.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/arch/powerpc/platforms/pseries/iommu.c b/arch/powerpc/platforms/pseries/iommu.c
> index 3e1f915fe4f6..3b49a0f76df9 100644
> --- a/arch/powerpc/platforms/pseries/iommu.c
> +++ b/arch/powerpc/platforms/pseries/iommu.c
> @@ -1875,6 +1875,9 @@ static void pci_dma_dev_setup_pSeriesLP(struct pci_dev *dev)
>   	pci = PCI_DN(pdn);
>   	if (!pci->table_group) {
>   		pci->table_group = iommu_pseries_alloc_group(pci->phb->node);
> +		if (!pci->table_group)
> +			return;
> +
>   		tbl = pci->table_group->tables[0];
>   
>   		iommu_table_setparms_common(tbl, pci->phb->bus->number,

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-06-22 16:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-22 16:38 [PATCH] powerpc/pseries/iommu: Add check for iommu_pseries_alloc_group() Haoxiang Li
2026-06-22 16:50 ` Gaurav Batra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®