From: Juergen Gross <jgross@suse.com>
To: Teddy Astie <teddy.astie@vates.tech>, xen-devel@lists.xenproject.org
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/8] xen: Add gpa conversion helpers
Date: Wed, 11 Nov 2026 07:48:19 +0100 [thread overview]
Message-ID: <d74cbff5-ead6-4c26-b300-ffd8c2fbbd4a@suse.com> (raw)
In-Reply-To: <1792170395.8631fc262581453bbf619ec5b2062170.1a145ae07870008425@vates.tech>
[-- Attachment #1.1: Type: text/plain, Size: 878 bytes --]
On 16.10.26 19:06, Teddy Astie wrote:
> Introduce various helpers to convert between GPA and virt/paddr.
>
> Signed-off-by: Teddy Astie <teddy.astie@vates.tech>
Reviewed-by: Juergen Gross <jgross@suse.com>
If you are up to it, there is some potential for cleaning up the Xen related
page.h include files.
You are adding the same definitions to the x86 and arm specific page.h files,
which are located at different positions regarding the arch trees.
I think this should be cleaned up by moving the common parts into
include/xen/page.h. The arch specific include files should both be under
include/xen/<arch>/page.h, I think (using arch/<arch>/include/asm/xen/page.h
won't work, as the arm file is used by arm and arm64).
In case you don't want to do that, I'm fine to do that later, e.g. when the
riscv Xen port is arriving in the kernel.
Juergen
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2026-11-11 6:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1792170295.8631fc262581453bbf619ec5b2062170.1a145ac82530008425@vates.tech>
[not found] ` <1792170392.8631fc262581453bbf619ec5b2062170.1a145adfbff0008425@vates.tech>
2026-10-16 17:33 ` [PATCH v2 1/8] x86/xen/pv: Don't setup runstate area too early Andrew Cooper
2026-10-16 18:04 ` Andrew Cooper
2026-10-19 9:06 ` Teddy Astie
2026-10-19 9:20 ` Teddy Astie
[not found] ` <20261016170613.173406-2-teddy.astie@vates.tech>
[not found] ` <1792170394.8631fc262581453bbf619ec5b2062170.1a145ae01ed0008425@vates.tech>
2026-11-11 6:36 ` [PATCH v2 2/8] xen: Refactor xen/features{.c,.h} Juergen Gross
[not found] ` <1792170395.8631fc262581453bbf619ec5b2062170.1a145ae07870008425@vates.tech>
2026-11-11 6:48 ` Juergen Gross [this message]
[not found] ` <1792170396.8631fc262581453bbf619ec5b2062170.1a145ae0a4a0008425@vates.tech>
2026-11-11 6:49 ` [PATCH v2 4/8] x86/xen/time: Correct xen_save_time_memory_area() failure message Juergen Gross
[not found] ` <1792170396.8631fc262581453bbf619ec5b2062170.1a145ae0c950008425@vates.tech>
2026-11-11 6:59 ` [PATCH v2 5/8] x86/xen/time: Clear xen_clock mapping later Juergen Gross
[not found] ` <1792170397.8631fc262581453bbf619ec5b2062170.1a145ae0f160008425@vates.tech>
2026-11-11 7:00 ` [PATCH v2 6/8] x86/xen/time: Mark xen_setup_vsyscall_time_info() __init Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d74cbff5-ead6-4c26-b300-ffd8c2fbbd4a@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr_tyshchenko@epam.com \
--cc=sstabellini@kernel.org \
--cc=teddy.astie@vates.tech \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®