mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] drm/amd/powerplay: remove redundant memset
@ 2019-07-15 11:43 Fuqian Huang
  2019-07-15 13:22 ` Markus Elfring
  0 siblings, 1 reply; 2+ messages in thread
From: Fuqian Huang @ 2019-07-15 11:43 UTC (permalink / raw)
  Cc: Rex Zhu, Evan Quan, Alex Deucher, Christian König,
	David Zhou, David Airlie, Daniel Vetter, amd-gfx, dri-devel,
	linux-kernel, Fuqian Huang

kzalloc has already zeroed the memory.
So the memset is unneeded.

Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
---
 drivers/gpu/drm/amd/powerplay/vega20_ppt.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/powerplay/vega20_ppt.c b/drivers/gpu/drm/amd/powerplay/vega20_ppt.c
index 8fafcbdb1dfd..0fb6066997b2 100644
--- a/drivers/gpu/drm/amd/powerplay/vega20_ppt.c
+++ b/drivers/gpu/drm/amd/powerplay/vega20_ppt.c
@@ -1295,7 +1295,6 @@ static int vega20_set_default_od8_setttings(struct smu_context *smu)
 	if (!table_context->od8_settings)
 		return -ENOMEM;
 
-	memset(table_context->od8_settings, 0, sizeof(struct vega20_od8_settings));
 	od8_settings = (struct vega20_od8_settings *)table_context->od8_settings;
 
 	if (smu_feature_is_enabled(smu, FEATURE_DPM_SOCCLK_BIT)) {
-- 
2.11.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: drm/amd/powerplay: remove redundant memset
  2019-07-15 11:43 [PATCH] drm/amd/powerplay: remove redundant memset Fuqian Huang
@ 2019-07-15 13:22 ` Markus Elfring
  0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2019-07-15 13:22 UTC (permalink / raw)
  To: Fuqian Huang, Alex Deucher, amd-gfx, dri-devel
  Cc: linux-kernel, kernel-janitors, Christian König,
	Daniel Vetter, David Airlie, David Zhou, Evan Quan, Rex Zhu

> kzalloc has already zeroed the memory.
> So the memset is unneeded.

See also a previous patch:
drm/amd/powerplay: Delete a redundant memory setting in vega20_set_default_od8_setttings()
https://lore.kernel.org/lkml/de3f6a5e-8ac4-bc8e-0d0c-3a4a5db283e9@web.de/
https://lore.kernel.org/patchwork/patch/1089691/
https://lkml.org/lkml/2019/6/17/460

Regards,
Markus

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-07-15 13:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-15 11:43 [PATCH] drm/amd/powerplay: remove redundant memset Fuqian Huang
2019-07-15 13:22 ` Markus Elfring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®