From: Andrew Lunn <andrew@lunn.ch>
To: Bastien Curutchet <bastien.curutchet@bootlin.com>
Cc: "Woojung Huh" <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Marek Vasut" <marex@denx.de>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Miquèl Raynal" <miquel.raynal@bootlin.com>,
"Pascal Eberhard" <pascal.eberhard@se.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 3/3] net: dsa: microchip: Set SPI as bus interface during reset for KSZ8463
Date: Tue, 16 Sep 2025 00:00:15 +0200 [thread overview]
Message-ID: <d7554ede-1405-4e93-8305-2085fbf38701@lunn.ch> (raw)
In-Reply-To: <20250912-ksz-strap-pins-v2-3-6d97270c6926@bootlin.com>
On Fri, Sep 12, 2025 at 11:09:14AM +0200, Bastien Curutchet wrote:
> At reset, the KSZ8463 uses a strap-based configuration to set SPI as
> bus interface. SPI is the only bus supported by the driver. If the
> required pull-ups/pull-downs are missing (by mistake or by design to
> save power) the pins may float and the configuration can go wrong
> preventing any communication with the switch.
>
> Introduce a ksz8463_configure_straps_spi() function called during the
> device reset. It relies on the 'strap-rxd*-gpios' OF properties and the
> 'reset' pinmux configuration to enforce SPI as bus interface.
>
> Signed-off-by: Bastien Curutchet (Schneider Electric) <bastien.curutchet@bootlin.com>
Thanks for updating the commit messages, it is now a lot clearer why
this is needed.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
prev parent reply other threads:[~2025-09-15 22:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 9:09 [PATCH net-next v2 0/3] net: dsa: microchip: Add strap description to set SPI as interface bus Bastien Curutchet (Schneider Electric)
2025-09-12 9:09 ` [PATCH net-next v2 1/3] dt-bindings: net: dsa: microchip: Group if clause under allOf tag Bastien Curutchet (Schneider Electric)
2025-09-15 21:12 ` Rob Herring (Arm)
2025-09-12 9:09 ` [PATCH net-next v2 2/3] dt-bindings: net: dsa: microchip: Add strap description to set SPI mode Bastien Curutchet (Schneider Electric)
2025-09-15 21:10 ` Rob Herring
2025-09-12 9:09 ` [PATCH net-next v2 3/3] net: dsa: microchip: Set SPI as bus interface during reset for KSZ8463 Bastien Curutchet
2025-09-15 22:00 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7554ede-1405-4e93-8305-2085fbf38701@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=bastien.curutchet@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=pascal.eberhard@se.com \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®