* [PATCH] fs: cifs: drop unneeded likely() call around IS_ERR()
@ 2019-06-05 21:14 Enrico Weigelt, metux IT consult
2019-06-05 21:52 ` Steve French
0 siblings, 1 reply; 3+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-06-05 21:14 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-cifs
From: Enrico Weigelt <info@metux.net>
IS_ERR() already calls unlikely(), so this extra unlikely() call
around IS_ERR() is not needed.
Signed-off-by: Enrico Weigelt <info@metux.net>
---
fs/cifs/dfs_cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/cifs/dfs_cache.c b/fs/cifs/dfs_cache.c
index e3e1c13..1692c0c 100644
--- a/fs/cifs/dfs_cache.c
+++ b/fs/cifs/dfs_cache.c
@@ -492,7 +492,7 @@ static struct dfs_cache_entry *__find_cache_entry(unsigned int hash,
#ifdef CONFIG_CIFS_DEBUG2
char *name = get_tgt_name(ce);
- if (unlikely(IS_ERR(name))) {
+ if (IS_ERR(name)) {
rcu_read_unlock();
return ERR_CAST(name);
}
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] fs: cifs: drop unneeded likely() call around IS_ERR()
2019-06-05 21:14 [PATCH] fs: cifs: drop unneeded likely() call around IS_ERR() Enrico Weigelt, metux IT consult
@ 2019-06-05 21:52 ` Steve French
2019-06-06 0:41 ` Enrico Weigelt, metux IT consult
0 siblings, 1 reply; 3+ messages in thread
From: Steve French @ 2019-06-05 21:52 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult; +Cc: LKML, CIFS, Kefeng Wang
This duplicates a patch submitted earlier by Kefeng Wang
<wangkefeng.wang@huawei.com> which I plan to merge later today into
cifs-2.6.git for-next
On Wed, Jun 5, 2019 at 4:14 PM Enrico Weigelt, metux IT consult
<info@metux.net> wrote:
>
> From: Enrico Weigelt <info@metux.net>
>
> IS_ERR() already calls unlikely(), so this extra unlikely() call
> around IS_ERR() is not needed.
>
> Signed-off-by: Enrico Weigelt <info@metux.net>
> ---
> fs/cifs/dfs_cache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/dfs_cache.c b/fs/cifs/dfs_cache.c
> index e3e1c13..1692c0c 100644
> --- a/fs/cifs/dfs_cache.c
> +++ b/fs/cifs/dfs_cache.c
> @@ -492,7 +492,7 @@ static struct dfs_cache_entry *__find_cache_entry(unsigned int hash,
> #ifdef CONFIG_CIFS_DEBUG2
> char *name = get_tgt_name(ce);
>
> - if (unlikely(IS_ERR(name))) {
> + if (IS_ERR(name)) {
> rcu_read_unlock();
> return ERR_CAST(name);
> }
> --
> 1.9.1
>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] fs: cifs: drop unneeded likely() call around IS_ERR()
2019-06-05 21:52 ` Steve French
@ 2019-06-06 0:41 ` Enrico Weigelt, metux IT consult
0 siblings, 0 replies; 3+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-06-06 0:41 UTC (permalink / raw)
To: Steve French, Enrico Weigelt, metux IT consult; +Cc: LKML, CIFS, Kefeng Wang
On 05.06.19 21:52, Steve French wrote:
> This duplicates a patch submitted earlier by Kefeng Wang
> <wangkefeng.wang@huawei.com> which I plan to merge later today into
> cifs-2.6.git for-next
Great :)
Just ignore my patch.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-06 0:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-05 21:14 [PATCH] fs: cifs: drop unneeded likely() call around IS_ERR() Enrico Weigelt, metux IT consult
2019-06-05 21:52 ` Steve French
2019-06-06 0:41 ` Enrico Weigelt, metux IT consult
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®