mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: ti: k3-am62a-main: Enable crypto accelerator
@ 2024-06-17 10:22 Kamlesh Gurudasani
  2024-06-17 15:51 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 3+ messages in thread
From: Kamlesh Gurudasani @ 2024-06-17 10:22 UTC (permalink / raw)
  To: Nishanth Menon, Vignesh Raghavendra
  Cc: Tero Kristo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-kernel, devicetree, linux-kernel, Jayesh Choudhary,
	Kamlesh Gurudasani

Add the node for sa3ul crypto accelerator.

Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
Signed-off-by: Kamlesh Gurudasani <kamlesh@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
index ce4a2f105630..298d0c91fc0a 100644
--- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
@@ -216,6 +216,18 @@ k3_reset: reset-controller {
 		};
 	};
 
+	crypto: crypto@40900000 {
+		compatible = "ti,am62-sa3ul";
+		reg = <0x00 0x40900000 0x00 0x1200>;
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;
+
+		dmas = <&main_pktdma 0xf501 0>, <&main_pktdma 0x7506 0>,
+		       <&main_pktdma 0x7507 0>;
+		dma-names = "tx", "rx1", "rx2";
+	};
+
 	secure_proxy_sa3: mailbox@43600000 {
 		compatible = "ti,am654-secure-proxy";
 		#mbox-cells = <1>;

---
base-commit: 6906a84c482f098d31486df8dc98cead21cce2d0
change-id: 20240617-crytpo-am62a-bb6b71643cc7

Best regards,
-- 
Kamlesh Gurudasani <kamlesh@ti.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: ti: k3-am62a-main: Enable crypto accelerator
  2024-06-17 10:22 [PATCH] arm64: dts: ti: k3-am62a-main: Enable crypto accelerator Kamlesh Gurudasani
@ 2024-06-17 15:51 ` Krzysztof Kozlowski
  2024-06-18 11:15   ` Kamlesh Gurudasani
  0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-06-17 15:51 UTC (permalink / raw)
  To: Kamlesh Gurudasani, Nishanth Menon, Vignesh Raghavendra
  Cc: Tero Kristo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-kernel, devicetree, linux-kernel, Jayesh Choudhary

On 17/06/2024 12:22, Kamlesh Gurudasani wrote:
> Add the node for sa3ul crypto accelerator.
> 
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> Signed-off-by: Kamlesh Gurudasani <kamlesh@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
> index ce4a2f105630..298d0c91fc0a 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
> @@ -216,6 +216,18 @@ k3_reset: reset-controller {
>  		};
>  	};
>  
> +	crypto: crypto@40900000 {
> +		compatible = "ti,am62-sa3ul";
> +		reg = <0x00 0x40900000 0x00 0x1200>;
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;

Why do you need ranges? No children here.

Anyway, keep the order as in DTS coding style.


Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: ti: k3-am62a-main: Enable crypto accelerator
  2024-06-17 15:51 ` Krzysztof Kozlowski
@ 2024-06-18 11:15   ` Kamlesh Gurudasani
  0 siblings, 0 replies; 3+ messages in thread
From: Kamlesh Gurudasani @ 2024-06-18 11:15 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Nishanth Menon, Vignesh Raghavendra
  Cc: Tero Kristo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-kernel, devicetree, linux-kernel, Jayesh Choudhary

Krzysztof Kozlowski <krzk@kernel.org> writes:

...
>> +	crypto: crypto@40900000 {
>> +		compatible = "ti,am62-sa3ul";
>> +		reg = <0x00 0x40900000 0x00 0x1200>;
>> +		#address-cells = <2>;
>> +		#size-cells = <2>;
>> +		ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;
>
> Why do you need ranges? No children here.
Thanks for correcting, Krzysztof.

This got carried from a device with child node.
Sending a v2.

Kamlesh
>
> Anyway, keep the order as in DTS coding style.
>
>
> Best regards,
> Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-06-18 11:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-17 10:22 [PATCH] arm64: dts: ti: k3-am62a-main: Enable crypto accelerator Kamlesh Gurudasani
2024-06-17 15:51 ` Krzysztof Kozlowski
2024-06-18 11:15   ` Kamlesh Gurudasani

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®